From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBC82A00C3; Wed, 7 Dec 2022 19:00:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE6BA410D7; Wed, 7 Dec 2022 19:00:54 +0100 (CET) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by mails.dpdk.org (Postfix) with ESMTP id 32CB940156 for ; Wed, 7 Dec 2022 19:00:53 +0100 (CET) Received: by mail-ot1-f52.google.com with SMTP id q18-20020a056830441200b006704633f258so5406225otv.0 for ; Wed, 07 Dec 2022 10:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XVHNX9lOPYFQw8xuoe7GhOahZU2h5ij3soAROq15DWI=; b=QZie3bdanMc0Frej5nEVMGxmKMRIYfMvS/5Dty9o0LbfirZbv8tQzBSxNPzRsfBJI0 a5YIk+kI70tGs39HP10v83V6E78/ZypSVIVBXd5qdM43j3g2EVJeel1/dSGjXqiB6gK/ uFxf4VblzCNN61787oRyV5LeUQGIjG7EjQhpg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XVHNX9lOPYFQw8xuoe7GhOahZU2h5ij3soAROq15DWI=; b=f0ZU9nD6WijJ14WHdl4NSYK0GDvsdraDnn7p/jRSAYmrda4JEx4+ZKR1h9zdkXTEp+ 8/Rl0GFZeDzgaxP2bmMCL1TOCacWz68lay4u8SSZ6OhY0t1rTRJs/gFjj1DvQ+5LUr1A BE16tDGRndFDnaxd/RtqmUj1AGuqy+2iYR2m4ZqWULaD7cdqZMEcwi9TbiJKB+e19eCE H3unbL44Bm/mGFY+wigczn7HYKaicSoD5OLyWWzJ4jz4oGmpK3d4gCrXdYJ6FlaAzw01 nYIkWVPR6w0xQFPdIIEQcDrdHVekPehamTboJaUdXhvMwuQIeB9WFfCQa8tYLq0HU9Fq /xww== X-Gm-Message-State: ANoB5pmbVhGMLZsNq0spz+KIpAYj1KQl03lenkwMo5JR+SA6r3Yw1FmG DUWhZ4c2ox+fVyQE70MU2pKC47vcfe6PzTdnX8l2rg== X-Google-Smtp-Source: AA0mqf6DFQuv3mTLl/wqijVNrsgvA8jypZ/8/TwCbVEyds00MA0UjKuDXLintZ0JvQMrhCQnsAH+uV7EbPjRq0zriu4= X-Received: by 2002:a9d:6f05:0:b0:670:5f77:25a8 with SMTP id n5-20020a9d6f05000000b006705f7725a8mr3156423otq.44.1670436052292; Wed, 07 Dec 2022 10:00:52 -0800 (PST) MIME-Version: 1.0 References: <20221129140032.35940-1-david.marchand@redhat.com> <1923653.yKVeVyVuyW@thomas> <734b4cca-331a-9a6e-8300-3bf024e326d9@amd.com> <16994d83-8f31-1ee6-94b5-abfefb8566fb@amd.com> In-Reply-To: <16994d83-8f31-1ee6-94b5-abfefb8566fb@amd.com> From: Patrick Robb Date: Wed, 7 Dec 2022 13:00:41 -0500 Message-ID: Subject: Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted To: Ferruh Yigit Cc: David Marchand , Thomas Monjalon , Akhil Goyal , "ci@dpdk.org" , Andrew Rybchenko , Ajit Khaparde , Qi Zhang , Jerin Jacob Kollanukkaran , Raslan Darawsheh , Maxime Coquelin , "Xia, Chenbo" , Luca Boccassi , Kevin Traynor , Christian Ehrhardt , "Xueming(Steven) Li" , "dev@dpdk.org" , "stable@dpdk.org" , Bruce Richardson , Michael Santana , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , Aaron Conole Content-Type: multipart/alternative; boundary="00000000000084749605ef40b34a" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000084749605ef40b34a Content-Type: text/plain; charset="UTF-8" Hello, Community Lab team members are wondering whether it is possible to bump v22.11 to include at least this patch. We have an existing codebase which relies on a vXX.XX scheme for producing ABI references. We parse that out at different places in our code, so fixing this to handle vXX.XX.X will require some changes on our end. We can do that, but it puts the timeline on turning on ABI testing at the community lab back some. A v22.11 tagged release with this patch would allow for us to turn on ABI testing immediately. There was also a suggestion that having the "base" tag (like the simple v22.11) point to the latest revision is a more standard version naming approach and may be more intuitive than what is being used currently. If that is not possible, we will update our code to be able to refer to a vXX.XX.X tag for producing the ABI reference. If we adopt this approach, we would like to request that with future releases, a "vXX.XX.0" tag could always be made available for us to produce ABI references from. That way, we can prepare for turning on ABI testing knowing beforehand the tag name we will be using. On Tue, Dec 6, 2022 at 7:25 AM Ferruh Yigit wrote: > On 12/6/2022 10:18 AM, David Marchand wrote: > > On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit > wrote: > >> On 12/5/2022 3:37 PM, Thomas Monjalon wrote: > >>> 05/12/2022 14:47, Akhil Goyal: > >>>> But adding a tag on same repo is more convenient from developer point > of view. > >>>> However, it is my personal view, others may differ. > >>> > >>> From developer point of view, you should use > devtools/test-meson-builds.sh > >>> which does the "git clone" for you. > >>> > >>> This is what I have in ~/.config/dpdk/devel.config > >>> export DPDK_ABI_REF_DIR=$root/dpdk-build/abiref > >>> export DPDK_ABI_REF_VERSION=v22.11.1 > >>> > >> > >> Does it help to update 'test-meson-builds.sh' to use an environment > >> variable to select which repo to clone? > >> If so, I can send a patch for it. > > > > I was wondering too... > > I would expect most maintainers have the stable repo in their config > > but it would not hurt to handle the case when they don't for others. > > > > +1 > > > > > > Sent following if it helps: > https://patches.dpdk.org/project/dpdk/list/?series=26015 > -- Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --00000000000084749605ef40b34a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

Community Lab team members are wondering whe= ther it is possible to bump v22.11 to include at least this patch. We have = an existing codebase which relies on a vXX.XX scheme for producing ABI refe= rences. We parse that out at different places in our code, so fixing this t= o handle vXX.XX.X will require some changes on our end. We can do that, but= it puts the timeline on turning on ABI testing at the community lab back s= ome. A v22.11 tagged release with this patch would allow for us to turn on = ABI testing immediately. There was also a suggestion that having the "= base" tag (like the simple v22.11) point to the latest revision is a m= ore standard version naming approach and may be more intuitive than what is= being used currently.

If that is not possible, we will update our c= ode to be able to refer to a vXX.XX.X tag for producing the ABI reference. = If we adopt this approach, we would like to request that with future releas= es, a "vXX.XX.0" tag could always be made available for us to pro= duce ABI references from. That way, we can prepare for turning on ABI testi= ng knowing beforehand the tag name we will be using.

On Tue, Dec 6, 2022= at 7:25 AM Ferruh Yigit <ferruh= .yigit@amd.com> wrote:
On 12/6/2022 10:18 AM, David Marchand wrote:
> On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: >> On 12/5/2022 3:37 PM, Thomas Monjalon wrote:
>>> 05/12/2022 14:47, Akhil Goyal:
>>>> But adding a tag on same repo is more convenient from deve= loper point of view.
>>>> However, it is my personal view, others may differ.
>>>
>>> From developer point of view, you should use devtools/test-mes= on-builds.sh
>>> which does the "git clone" for you.
>>>
>>> This is what I have in ~/.config/dpdk/devel.config
>>> export DPDK_ABI_REF_DIR=3D$root/dpdk-build/abiref
>>> export DPDK_ABI_REF_VERSION=3Dv22.11.1
>>>
>>
>> Does it help to update 'test-meson-builds.sh' to use an en= vironment
>> variable to select which repo to clone?
>> If so, I can send a patch for it.
>
> I was wondering too...
> I would expect most maintainers have the stable repo in their config > but it would not hurt to handle the case when they don't for other= s.
>
> +1
>
>

Sent following if it helps:
https://patches.dpdk.org/project/dpdk/lis= t/?series=3D26015


--

Patrick Rob= b

Technical Service Manager

UNH InterOpera= bility Laboratory

21 Madbury Rd, Suite 100, Durham, NH 0= 3824

www.iol.unh.edu


--00000000000084749605ef40b34a--