From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ED9C48A50; Fri, 31 Oct 2025 20:19:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3349402E4; Fri, 31 Oct 2025 20:19:08 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 96CD240150 for ; Fri, 31 Oct 2025 20:19:07 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-294fac2d438so21433935ad.1 for ; Fri, 31 Oct 2025 12:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1761938346; x=1762543146; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RHpTGTyBKBiKprnnDl+5MySS33YsNoKOyoDvaMJmmvM=; b=Xl4ZJb0Vb/nsShl/9oJBbnhsfq9WGw9mzfUeXeedaP5uToUMS0wDWZ0BnhVQJn0tbV RSG5bDHyh1Gh1uQ1szejBgNKzc4SkRnCD2Edqdcoj8EDqWqwzz6HGZxSq2yt7/DXj+re LApXN/SeLXy8QBcWjIosUlqU32kiQ31MfLCvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761938346; x=1762543146; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RHpTGTyBKBiKprnnDl+5MySS33YsNoKOyoDvaMJmmvM=; b=koJgdIf8Aqidpp9ZQ84t97rzhqaM1qf4LVhmxZ675rafnJbPnm+5x0tYaHLg+wkC5a dlvTQtTMYEldRIeBGEJ0PVLpreb7K2uUUNE/rYX79i9FHv6CKMD1G/dOs602B6s6xKqg by606jO6Hh+w8KPOTjl1tMqiXbrWYLaDTuAQ0vBjSAV748P8Uh6umMXV0m5njfNmtA0P Oru1amKYqkLEmkM4t/Zf9SY5TzYfu/Am+hp1F+8RwJUkBrqgqG/F48qQ0NaxgYVLtjPp 8BF4pe6yNIIUSLWeQtSsgN3y6xEWdsgUAF1lu3YQ1mvlS10FcoUKjZcql9PJFb4AsGkz xRFQ== X-Forwarded-Encrypted: i=1; AJvYcCV9+NiX4qFp+E0adKRVlbCz7p1/Jy0bfz0QEOyg8yInREXQCHp1wC+MObH9F7NFnO+rWR0=@dpdk.org X-Gm-Message-State: AOJu0YxonCA62d6ZeQMzZUb4Hx2IrfcxkLGXD/+uT1uAIrTx7gLl3olT 2Uh4h+DmfKiduP1PUpND63sCL+KYMKbRcN/tfnKdcxMRWkwbDbqAwYiThSFbAyuBoCMDFNed8Mm mdlUdZOgsXyE6HV5/xzLay3gxt4MOSXBqxKSwU1Qoyg== X-Gm-Gg: ASbGnctgkGLAM2X4/CCv5k0ERzkqNYye+f97AEQimE/KmaIVRTN5zJA3r2s7j0sgfyk cjYXlaFqIpDF/h3mXi+HWYj2esyNC+CEo4NDJHT4sTOUA42kYjxzoVhSNM35ldD8tCE41wyaGwN IkA744cswbEl607EZAauTjEf+hd8giQqIzm/eio036Gu5s4JiWj6pM0uQJPhsOe6AUD9IYbFW7F EtvXGJXtaaCEsUq4lZ4uC6BhXMe1320r3yys/qIXrUSz18wN8HUcpIedvjtr6IU4sdd+lafmRfK 9SeP+NzBdw== X-Google-Smtp-Source: AGHT+IE2SLfM62jIwR44UAMQpdVWSgG2PzryJQI8VHDT8qLiKYwlmfaDCpd9pPqt0vR0gWyt80BupnWXW2DVmpYcb8s= X-Received: by 2002:a17:902:b48e:b0:27e:ef27:1e52 with SMTP id d9443c01a7336-2951a45459emr43557955ad.35.1761938346527; Fri, 31 Oct 2025 12:19:06 -0700 (PDT) MIME-Version: 1.0 References: <20251024184724.1698235-1-svaze@qti.qualcomm.com> In-Reply-To: From: Patrick Robb Date: Fri, 31 Oct 2025 15:18:04 -0400 X-Gm-Features: AWmQ_bnogKF6nUOXIqB9I6cJ1TNHh_dCq0_38Gd4o9A-CHNzwi7ZuN-cPa7mHzc Message-ID: Subject: Re: [PATCH] compressdev: fix coverity issue To: Sameer Vaze Cc: Sunila Sahu , Fan Zhang , Ashish Gupta , "dev@dpdk.org" Content-Type: multipart/alternative; boundary="00000000000042dfd30642793d9a" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000042dfd30642793d9a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sameer, Thanks for the heads up. It looks like the Github Robot has a failure but I think it is a spurious false fail, so I just sent a recheck request for that. I expect that failure will be overwritten with a PASS soon. There are also 2 warnings on your patch, which I can address, but they will not preclude your patch from being merged (as they are only a WARN, not a FAIL). Thanks. On Fri, Oct 31, 2025 at 1:10=E2=80=AFPM Sameer Vaze wrote: > > Hey Patrick > > I followed https://core.dpdk.org/testing/#requesting-a-patch-retest to > request a rebase and recheck since the failures don't seem related to my > changes. It doesn't look like the retests were picked up. Did I miss > something? > > Thanks > Sameer Vaze > ------------------------------ > *From:* Sameer Vaze > *Sent:* Tuesday, October 28, 2025 11:19 AM > *To:* Sunila Sahu ; Fan Zhang = ; > Ashish Gupta > *Cc:* dev@dpdk.org > *Subject:* Re: [PATCH] compressdev: fix coverity issue > > > *WARNING:* This email originated from outside of Qualcomm. Please be wary > of any links or attachments, and do not enable macros. > Recheck-request: rebase=3Dmain, iol-sample-apps-testing, > iol-compile-amd64-testing > ------------------------------ > *From:* Sameer Vaze > *Sent:* Friday, October 24, 2025 12:47 PM > *To:* Sunila Sahu ; Fan Zhang = ; > Ashish Gupta > *Cc:* dev@dpdk.org ; Sameer Vaze > *Subject:* [PATCH] compressdev: fix coverity issue > > Adds missing free before end of function > > Signed-off-by: Sameer Vaze > --- > drivers/compress/zlib/zlib_pmd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/compress/zlib/zlib_pmd.c > b/drivers/compress/zlib/zlib_pmd.c > index 3a2485b54e..1d7651dd7d 100644 > --- a/drivers/compress/zlib/zlib_pmd.c > +++ b/drivers/compress/zlib/zlib_pmd.c > @@ -126,6 +126,7 @@ process_zlib_inflate_chksum(struct rte_comp_op *op, > free(dictionary); > return; > } > + free(dictionary); > } > > static void > -- > 2.31.1 > > --00000000000042dfd30642793d9a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Sameer,

Thanks for the heads up. It = looks like the Github Robot has a failure but I think it is a spurious fals= e fail, so I just sent a recheck request for that. I expect that failure wi= ll be overwritten with a PASS soon.

There are also= 2 warnings on your patch, which I can address, but they will not preclude = your patch from being merged (as they are only a WARN, not a FAIL).

Thanks.

On Fri, Oct 31, 2025 a= t 1:10=E2=80=AFPM Sameer Vaze <svaze@qti.qualcomm.com> wrote:

Hey Patrick

I followed https://core.dpdk.org/testing/#requesting-a-patch-retest=C2=A0to reques= t a rebase and recheck since the failures don't seem related to my chan= ges. It doesn't look like the retests were picked up. Did I miss someth= ing?

Thanks
Sameer Vaze
From: S= ameer Vaze <= svaze@qti.qualcomm.com>
Sent: Tuesday, October 28, 2025 11:19 AM
To: Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gup= ta <ashishg@mar= vell.com>
Cc: dev@dpdk.org <dev@dpdk.org&g= t;
Subject: Re: [PATCH] compressdev: fix coverity issue
=C2=A0

WARNING:= This email originated from outside of Qualcomm. Please be wary of= any links or attachments, and do not enable macros.

Recheck-request: rebase=3Dmain, iol-sample-apps-testing, iol-compile-amd64-= testing
From:= Sameer Vaze <svaze@qti.qualcomm.com>
Sent: Friday, October 24, 2025 12:47 PM
To: Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gup= ta <ashishg@mar= vell.com>
Cc: dev@dpdk.org <dev@dpdk.org&g= t;; Sameer Vaze <svaze@qti.qualcomm.com>
Subject: [PATCH] compressdev: fix coverity issue
=C2=A0
Adds missing free before end of function

Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com>
---
=C2=A0drivers/compress/zlib/zlib_pmd.c | 1 +
=C2=A01 file changed, 1 insertion(+)

diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_= pmd.c
index 3a2485b54e..1d7651dd7d 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -126,6 +126,7 @@ process_zlib_inflate_chksum(struct rte_comp_op *op,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 free(dictionary);
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 return;
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 free(dictionary);
=C2=A0}
=C2=A0
=C2=A0static void
--
2.31.1

--00000000000042dfd30642793d9a--