From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31D4545B50; Wed, 16 Oct 2024 15:10:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04FD64027C; Wed, 16 Oct 2024 15:10:26 +0200 (CEST) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 4B49F4027C for ; Wed, 16 Oct 2024 15:10:24 +0200 (CEST) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2e2a97c2681so4843953a91.2 for ; Wed, 16 Oct 2024 06:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1729084223; x=1729689023; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ebJ+sdhRwAchkEtt/1Soq036r4TkO2ZooOV6eeTnAnI=; b=cVnHJkFfl8t2+UIZilj+uLLT0QEVy1lgp0K3kuf/tgJSdkWTOs2sF5wDzlNmbsHfJF q6wGQxyFhz/faBOtBao61PeVl+QKNI2sPo7waRHFsQIlErdPWWXFg7tWIC+jvujfz6yR gGZ49vPM4wc9ADENZlrJ3GWdwXzf3IsTGsl9U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729084223; x=1729689023; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ebJ+sdhRwAchkEtt/1Soq036r4TkO2ZooOV6eeTnAnI=; b=VLB7/k8jllKaXa4w0aVMXCiRYIhyyIL2rBa+MYIBVQOFs8EVjY62nrkO+w7KDxo2I1 WjMzu8PU8SGnimzTQnyA4IN5ThH3QyBjFjXQefSeCcoVbabH49NeAYi3yreNNP2O5JPh q/vswEqoa+YsE9GNRmho4kMF4KOvxDODJC+QI5VOe/nafUo/umnbUmFZHMtOGeDyHHC2 QSHSELVb5g6dFTMrSIoF+ZoWK4QXDE2P0wAjaZ9u4O87JtpWV6mdAWGB5LObOHvgO55i EKN38IfqmGHzgYnsgIKg5LgRZ3poxsWlrnp0T19APfxYV1wHEvCSrSJHH23Epubm7Yzy 0YZQ== X-Forwarded-Encrypted: i=1; AJvYcCUwWNRbxYijaLvm/AB5lhVzoEFsA8OTI7dmKLjovBXBKNHs9D6aV0viq0ym8jKYLbzbF40=@dpdk.org X-Gm-Message-State: AOJu0YwfGC1OeQ0dS6QlKuGkggjyVNYy75V64XL9CgovxTClCOxSqZtm UOAxNMu9GHV7hRISS9IY8UVooQwa/3uE5Nbo8GleHj+rsVnHpFWl8CN9wNBCa8VNM3JslZAG9dZ 44Er0n9LfP0FP8Fh4+Xx2tmzACVTLvo/o+GNUjA== X-Google-Smtp-Source: AGHT+IEueOsyBXLuv+fCRVUJUaUbGYvTSj26FwA0zlwxBHXdVPFgFFVLNVBlcil5oEuv2jiBd5tWX4yPusktuxCFPq0= X-Received: by 2002:a17:90b:4a0b:b0:2e0:7560:9334 with SMTP id 98e67ed59e1d1-2e2f0d9a513mr22807798a91.36.1729084223316; Wed, 16 Oct 2024 06:10:23 -0700 (PDT) MIME-Version: 1.0 References: <20240920125737.1197969-1-bruce.richardson@intel.com> <9a6c43e9-b2a1-15fe-9b7c-4178419f1e35@loongson.cn> <12eae603-d75d-ee3f-3822-670e8e4bbbeb@loongson.cn> In-Reply-To: <12eae603-d75d-ee3f-3822-670e8e4bbbeb@loongson.cn> From: Patrick Robb Date: Wed, 16 Oct 2024 09:08:56 -0400 Message-ID: Subject: Re: [PATCH 0/5] Increase minimum meson version To: zhoumin Cc: David Marchand , dpdklab , dev@dpdk.org, mb@smartsharesystems.com, thomas@monjalon.net, ci@dpdk.org, Bruce Richardson Content-Type: multipart/alternative; boundary="000000000000eb0cb9062497caf7" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000eb0cb9062497caf7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable UNH will be updated to be running from the linux setup script by the end of the day today, and I'll send another response here. On Sun, Oct 13, 2024 at 9:26=E2=80=AFPM zhoumin wrote= : > Hi Patrick Robb, > > Thank you for your reminding. I have set the meson version to 0.57.0 in > Loongson lab. > On Wed, Oct 9, 2024 at 2:31PM, Patrick Robb wrote: > > Hi Min Zhou, > > I think it makes sense for you to set your meson version to the minimum > version supported for DPDK (so, .57 now I suppose) instead of .63. The > principle that David described above regarding LTS is also true for main. > So, for the main and next-* branch testing that Loongson lab does, we wan= t > our CI testing to verify that no change relying on post .57 meson feature= s > get merged into main. > > On Tue, Oct 8, 2024 at 9:07=E2=80=AFPM zhoumin wrot= e: > >> Hi David, >> >> On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote: >> > Hello CI guys, >> > >> > On Fri, Sep 20, 2024 at 2:57=E2=80=AFPM Bruce Richardson >> > wrote: >> >> This patchset proposed increasing the minimum meson version to 0.57 >> >> and makes changes to update our build files appropriately for that >> >> change: replacing deprecated functions, removing unnecessary version >> >> checks and taking advantage of some new capabilities. >> >> >> >> Why 0.57? No one particular reason; it's mainly a conservative versio= n >> >> bump that doesn't have many impacts, but still gives us the minimum >> >> updates we need to replace the deprecated get_cross_properties fn >> >> and have a few extra features guaranteed available. >> >> >> >> Bruce Richardson (5): >> >> build: increase minimum meson version to 0.57 >> >> build: remove version check on compiler links function >> >> build: remove unnecessary version checks >> >> build: use version file support from meson >> >> build: replace deprecated meson function >> >> >> >> .ci/linux-setup.sh | 2 +- >> >> config/arm/meson.build | 4 ++-- >> >> config/meson.build | 8 ++++---- >> >> config/riscv/meson.build | 4 ++-- >> >> doc/api/meson.build | 2 +- >> >> doc/guides/linux_gsg/sys_reqs.rst | 2 +- >> >> doc/guides/prog_guide/build-sdk-meson.rst | 2 +- >> >> drivers/common/qat/meson.build | 2 +- >> >> drivers/crypto/ipsec_mb/meson.build | 2 +- >> >> drivers/event/cnxk/meson.build | 2 +- >> >> drivers/meson.build | 7 ++----- >> >> drivers/net/cnxk/meson.build | 2 +- >> >> lib/meson.build | 6 ------ >> >> meson.build | 7 ++----- >> >> 14 files changed, 20 insertions(+), 32 deletions(-) >> > This series can't be merged until the (UNH and LoongArch) CI are ready >> > for such a change. >> > >> > TL;DR: the meson minimum version is being changed from 0.53.2 to 0.57 >> > in the current release. >> > >> > @UNH @Min Zhou >> > How long would it take for all CI to be ready for this change? >> It's OK for Loongson lab. The meson version for DPDK CI in Loongson lab >> is 0.63.0. >> > Important note: if relevant to your CI, testing against LTS branches >> > must still be done with the 0.53.2 version, so no change relying on >> > post 0.53.2 meson feature gets backported. >> > >> > >> >> --000000000000eb0cb9062497caf7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
UNH will be updated to be running from the linux setup scr= ipt by the end of the day today, and I'll send another response here.
On= Sun, Oct 13, 2024 at 9:26=E2=80=AFPM zhoumin <zhoumin@loongson.cn> wrote:
=20 =20 =20

Hi Patrick Robb,

Thank you for your reminding. I have set the meson version to 0.57.0 in Loongson lab.

On Wed, Oct 9, 2024 at 2:31PM, Patrick Robb wrote:
=20
Hi Min Zhou,

I think it makes sense for you to set your meson version to the minimum version supported for DPDK (so, .57 now I suppose) instead of .63. The principle that David described above regarding LTS is also true for main. So, for the main and next-* branch testing that Loongson lab does, we want our CI testing to verify that no change relying on post .57 meson features get merged into main.=C2=A0

On Tue, Oct 8, 2024 at 9:07= =E2=80=AFPM zhoumin <zhoumin@loongson.cn> wrote:
Hi David,

On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote:
> Hello CI guys,
>
> On Fri, Sep 20, 2024 at 2:57=E2=80=AFPM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
>> This patchset proposed increasing the minimum meson version to 0.57
>> and makes changes to update our build files appropriately for that
>> change: replacing deprecated functions, removing unnecessary version
>> checks and taking advantage of some new capabilities. >>
>> Why 0.57? No one particular reason; it's mainly a conservative version
>> bump that doesn't have many impacts, but still gives us the minimum
>> updates we need to replace the deprecated get_cross_properties fn
>> and have a few extra features guaranteed available.
>>
>> Bruce Richardson (5):
>>=C2=A0 =C2=A0 build: increase minimum meson version to 0.= 57
>>=C2=A0 =C2=A0 build: remove version check on compiler lin= ks function
>>=C2=A0 =C2=A0 build: remove unnecessary version checks >>=C2=A0 =C2=A0 build: use version file support from meson<= br> >>=C2=A0 =C2=A0 build: replace deprecated meson function >>
>>=C2=A0 =C2=A0.ci/linux-setup.sh=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0config/arm/meson.build=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 4 ++--
>>=C2=A0 =C2=A0config/meson.build=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 8 ++++----
>>=C2=A0 =C2=A0config/riscv/meson.build=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 4 ++--
>>=C2=A0 =C2=A0doc/api/meson.build=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 2 +-
>>=C2=A0 =C2=A0doc/guides/linux_gsg/sys_reqs.rst=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0| 2 +-
>>=C2=A0 =C2=A0doc/guides/prog_guide/build-sdk-meson.rst | = 2 +-
>>=C2=A0 =C2=A0drivers/common/qat/meson.build=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0drivers/crypto/ipsec_mb/meson.build=C2=A0 = =C2=A0 =C2=A0 =C2=A0| 2 +-
>>=C2=A0 =C2=A0drivers/event/cnxk/meson.build=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0drivers/meson.build=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 7 ++-----
>>=C2=A0 =C2=A0drivers/net/cnxk/meson.build=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
>>=C2=A0 =C2=A0lib/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 6 ------
>>=C2=A0 =C2=A0meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0| 7 ++-----
>>=C2=A0 =C2=A014 files changed, 20 insertions(+), 32 delet= ions(-)
> This series can't be merged until the (UNH and LoongArch= ) CI are ready
> for such a change.
>
> TL;DR: the meson minimum version is being changed from 0.53.2 to 0.57
> in the current release.
>
> @UNH @Min Zhou
> How long would it take for all CI to be ready for this change?
It's OK for Loongson lab. The meson version for DPDK CI in Loongson lab
is 0.63.0.
> Important note: if relevant to your CI, testing against LTS branches
> must still be done with the 0.53.2 version, so no change relying on
> post 0.53.2 meson feature gets backported.
>
>

--000000000000eb0cb9062497caf7--