From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D621B43C0C; Fri, 1 Mar 2024 17:13:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5D3D402EA; Fri, 1 Mar 2024 17:13:34 +0100 (CET) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by mails.dpdk.org (Postfix) with ESMTP id 8204A402E0 for ; Fri, 1 Mar 2024 17:13:33 +0100 (CET) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-59fd6684316so831055eaf.0 for ; Fri, 01 Mar 2024 08:13:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1709309613; x=1709914413; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ntSoFZe52OcmxtorPV/Rp2IHQ4h6+qNZaOusnNaTFSM=; b=HR3KFUorCeegLcY8r/HfVfviJLs2q+pqCJrkNBCvOOSbyIBqvGtilC7bouWNeGloLN e7iIACIH8vIZboMk7MlPWFc+FMsabX3f3aG0GzXTAm0hsK/fWIAc0CQsuquRcCfwKNVf bemnb8D770V5+V8rltfb5xuygrNWG7h07jqy4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709309613; x=1709914413; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ntSoFZe52OcmxtorPV/Rp2IHQ4h6+qNZaOusnNaTFSM=; b=cGEWh5AS/t+wexNXkMjeK3BiaAKaAANXMJg/NTUaI5dqM17oAQshb98ROgstl9Z2jJ K30Z/rmbG96aeWaEDX58Xf02vpRwlrKYCfBjmuImEj/1b1uzKXxHn9xZ0wZCKtSIqClD evI5PC1qfAkl87x1di1mdZsWSMXhdsIWFxJKAIUl17hqaPTD1ACSdqE5voMPLuVzGdpd JWW722iE6hJXr2xHk5pLSmbNYFJLkMNsMgHBmmRuookRw6Bqv+c1q4+NQjbKDZaHLyUp cgAEgvNO176X1/0gLc2XI7NExKFbqW9S5IcELnOt49T/9QScwwImiN4gfKekaar9+Ypw BfMQ== X-Forwarded-Encrypted: i=1; AJvYcCXbMMFTFBLDItAVBHHzBHjp/K+sc7uKluxVfzq8evSYovYrn87QY/XsgeozGdXp0AluHBu2NHo9mtZkPC4= X-Gm-Message-State: AOJu0YyU0mb9jWZOqrl79bjhGqWca5F/7ahXN789rehzjpbGHJXRKIXk Xxn9FgYdniuaqzPstObJM9vvi/bQGumIlr9/NOUCZV7QhjBuTGC6GQkXKEONT52b6LRziFY3TPv Mhy7HBCBRPM1SQk7FTNzcumfa1hXm4DOcc1BnSw== X-Google-Smtp-Source: AGHT+IExAA/KFd7vSDWp+KRN2Bohpw51nSgXQi3UmGorrll85443FDvKojnKN/BZ4MR/bZ1VQFP5WWTSuTWp/3fxzeo= X-Received: by 2002:a4a:7653:0:b0:5a0:f121:63a9 with SMTP id w19-20020a4a7653000000b005a0f12163a9mr1931329ooe.7.1709309612920; Fri, 01 Mar 2024 08:13:32 -0800 (PST) MIME-Version: 1.0 References: <20240105095956.2402477-1-mingjinx.ye@intel.com> <20240301094422.460012-1-mingjinx.ye@intel.com> In-Reply-To: From: Patrick Robb Date: Fri, 1 Mar 2024 11:13:22 -0500 Message-ID: Subject: Re: [PATCH v5] net/i40e: add diagnostic support in TX path To: Bruce Richardson Cc: Mingjin Ye , dev@dpdk.org, Yuying Zhang , Beilei Xing Content-Type: multipart/alternative; boundary="0000000000004a25bd06129ba889" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000004a25bd06129ba889 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The Community CI Testing Lab had an infra failure this morning and some patches including yours were affected with false failures. The issue is now resolved and we are rerunning the tests in question for all patches submitted today. On Fri, Mar 1, 2024 at 5:25=E2=80=AFAM Bruce Richardson wrote: > On Fri, Mar 01, 2024 at 09:44:21AM +0000, Mingjin Ye wrote: > > Implemented a Tx wrapper to perform a thorough check on mbufs, > > categorizing and counting invalid cases by types for diagnostic > > purposes. The count of invalid cases is accessible through xstats_get. > > > > Also, the devarg option "mbuf_check" was introduced to configure the > > diagnostic parameters to enable the appropriate diagnostic features. > > > > supported cases: mbuf, size, segment, offload. > > 1. mbuf: check for corrupted mbuf. > > 2. size: check min/max packet length according to hw spec. > > 3. segment: check number of mbuf segments not exceed hw limitation. > > 4. offload: check any unsupported offload flag. > > > > parameter format: "mbuf_check=3D" or "mbuf_check=3D[,]" > > eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=3D[mbuf,size] -- -i > > > > Signed-off-by: Mingjin Ye > > --- > > v2: remove strict. > > --- > > v3: optimised. > > --- > > v4: rebase. > > --- > > v5: fix ci error. > > --- > > doc/guides/nics/i40e.rst | 13 +++ > > drivers/net/i40e/i40e_ethdev.c | 138 ++++++++++++++++++++++++++++- > > drivers/net/i40e/i40e_ethdev.h | 28 ++++++ > > drivers/net/i40e/i40e_rxtx.c | 153 +++++++++++++++++++++++++++++++-- > > drivers/net/i40e/i40e_rxtx.h | 2 + > > 5 files changed, 326 insertions(+), 8 deletions(-) > > > > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst > > index 15689ac958..bf1d1e5d60 100644 > > --- a/doc/guides/nics/i40e.rst > > +++ b/doc/guides/nics/i40e.rst > > @@ -275,6 +275,19 @@ Runtime Configuration > > > > -a 84:00.0,vf_msg_cfg=3D80@120:180 > > > > +- ``Support TX diagnostics`` (default ``not enabled``) > > + > > + Set the ``devargs`` parameter ``mbuf_check`` to enable TX > diagnostics. For example, > > + ``-a 18:01.0,mbuf_check=3D`` or ``-a > 18:01.0,mbuf_check=3D[,...]``. Also, > > + ``xstats_get`` can be used to get the error counts, which are > collected in > > + ``tx_mbuf_error_packets`` xstats. For example, ``testpmd> show port > xstats all``. > > + Supported cases: > > + > > + * mbuf: Check for corrupted mbuf. > > + * size: Check min/max packet length according to hw spec. > > + * segment: Check number of mbuf segments not exceed hw limitation. > > + * offload: Check any unsupported offload flag. > > + > > Hi Mingjin, > > please see the changes made to the equivalent doc (and commit-log) update= s > for iavf when I applied that earlier patch to next-net-intel. This patch > should be updated to match that. Changes were pretty basic, but still > useful, for example, aligning line breaks to punctuation. > > Thanks, > /Bruce > > PS: This feedback applies to the net/ice patch too. > --0000000000004a25bd06129ba889 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The Community CI Testing Lab had an infra= failure this morning and some patches including yours were affected with f= alse failures. The issue is now resolved and we are rerunning the tests in = question for all patches submitted today.=C2=A0

On Fri, Mar 1, 2024 at 5= :25=E2=80=AFAM Bruce Richardson <bruce.richardson@intel.com> wrote:
On Fri, Mar 01, 2024 at 09:44:21AM +0000, = Mingjin Ye wrote:
> Implemented a Tx wrapper to perform a thorough check on mbufs,
> categorizing and counting invalid cases by types for diagnostic
> purposes. The count of invalid cases is accessible through xstats_get.=
>
> Also, the devarg option "mbuf_check" was introduced to confi= gure the
> diagnostic parameters to enable the appropriate diagnostic features. >
> supported cases: mbuf, size, segment, offload.
>=C2=A0 1. mbuf: check for corrupted mbuf.
>=C2=A0 2. size: check min/max packet length according to hw spec.
>=C2=A0 3. segment: check number of mbuf segments not exceed hw limitati= on.
>=C2=A0 4. offload: check any unsupported offload flag.
>
> parameter format: "mbuf_check=3D<case>" or "mbuf_= check=3D[<case1>,<case2>]"
> eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=3D[mbuf,size] -- -i
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
> v2: remove strict.
> ---
> v3: optimised.
> ---
> v4: rebase.
> ---
> v5: fix ci error.
> ---
>=C2=A0 doc/guides/nics/i40e.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 13 ++= +
>=C2=A0 drivers/net/i40e/i40e_ethdev.c | 138 +++++++++++++++++++++++++++= +-
>=C2=A0 drivers/net/i40e/i40e_ethdev.h |=C2=A0 28 ++++++
>=C2=A0 drivers/net/i40e/i40e_rxtx.c=C2=A0 =C2=A0| 153 +++++++++++++++++= ++++++++++++++--
>=C2=A0 drivers/net/i40e/i40e_rxtx.h=C2=A0 =C2=A0|=C2=A0 =C2=A02 +
>=C2=A0 5 files changed, 326 insertions(+), 8 deletions(-)
>
> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
> index 15689ac958..bf1d1e5d60 100644
> --- a/doc/guides/nics/i40e.rst
> +++ b/doc/guides/nics/i40e.rst
> @@ -275,6 +275,19 @@ Runtime Configuration
>=C2=A0
>=C2=A0 =C2=A0 -a 84:00.0,vf_msg_cfg=3D80@120:180
>=C2=A0
> +- ``Support TX diagnostics`` (default ``not enabled``)
> +
> +=C2=A0 Set the ``devargs`` parameter ``mbuf_check`` to enable TX diag= nostics. For example,
> +=C2=A0 ``-a 18:01.0,mbuf_check=3D<case>`` or ``-a 18:01.0,mbuf_= check=3D[<case1>,<case2>...]``. Also,
> +=C2=A0 ``xstats_get`` can be used to get the error counts, which are = collected in
> +=C2=A0 ``tx_mbuf_error_packets`` xstats. For example, ``testpmd> s= how port xstats all``.
> +=C2=A0 Supported cases:
> +
> +=C2=A0 *=C2=A0 =C2=A0mbuf: Check for corrupted mbuf.
> +=C2=A0 *=C2=A0 =C2=A0size: Check min/max packet length according to h= w spec.
> +=C2=A0 *=C2=A0 =C2=A0segment: Check number of mbuf segments not excee= d hw limitation.
> +=C2=A0 *=C2=A0 =C2=A0offload: Check any unsupported offload flag.
> +

Hi Mingjin,

please see the changes made to the equivalent doc (and commit-log) updates<= br> for iavf when I applied that earlier patch to next-net-intel. This patch should be updated to match that. Changes were pretty basic, but still
useful, for example, aligning line breaks to punctuation.

Thanks,
/Bruce

PS: This feedback applies to the net/ice patch too.


--0000000000004a25bd06129ba889--