From: Patrick Robb <probb@iol.unh.edu>
To: Andre Muezerie <andremue@linux.microsoft.com>,
ci@dpdk.org, Manit Mahajan <mmahajan@iol.unh.edu>,
Andrew Bailey <abailey@iol.unh.edu>
Cc: bingz@nvidia.com, dev@dpdk.org, dsosnowski@nvidia.com,
matan@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com,
viacheslavo@nvidia.com
Subject: Re: [PATCH v2] doc: update parameters to use for mlx5 on Windows
Date: Tue, 15 Jul 2025 14:47:43 -0400 [thread overview]
Message-ID: <CAJvnSUChvkJkMsGC3RVn_uEw2GPD8F6tcetDVPfSqEb3Sfrsnw@mail.gmail.com> (raw)
In-Reply-To: <1752588889-27133-1-git-send-email-andremue@linux.microsoft.com>
[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]
+ci@dpdk.org <ci@dpdk.org>
+Manit Mahajan <mmahajan@iol.unh.edu>
+Andrew Bailey <abailey@iol.unh.edu>
Thank you for this we will modify our Clang and MSVC build pipelines at UNH.
Acked-by: Patrick Robb <probb@iol.unh.edu>
On Tue, Jul 15, 2025 at 10:14 AM Andre Muezerie <
andremue@linux.microsoft.com> wrote:
> The linker parameters to use with MSVC and Clang differ.
> Showing explicitly what to use with each in the documentation.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
> doc/guides/platform/mlx5.rst | 27 +++++++++++++++++++++++----
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/platform/mlx5.rst b/doc/guides/platform/mlx5.rst
> index ab3107209a..94ed59b170 100644
> --- a/doc/guides/platform/mlx5.rst
> +++ b/doc/guides/platform/mlx5.rst
> @@ -268,14 +268,33 @@ configured by the ``ibverbs_link`` build option:
> Compilation on Windows
> ~~~~~~~~~~~~~~~~~~~~~~
>
> -The DevX SDK location must be set through CFLAGS/LDFLAGS,
> -either::
> +The DevX SDK location must be set through CFLAGS/LDFLAGS.
> +When compiling with MSVC, use either::
>
> - meson.exe setup "-Dc_args=-I\"%DEVX_INC_PATH%\""
> "-Dc_link_args=-L\"%DEVX_LIB_PATH%\"" ...
> + meson.exe setup ^
> + "-Dc_args=-I\"%DEVX_INC_PATH%\"" ^
> + "-Dc_link_args=-LIBPATH:\"%DEVX_LIB_PATH%\"" ^
> + -Denable_stdatomic=true ^
> + ...
>
> or::
>
> - set CFLAGS=-I"%DEVX_INC_PATH%" && set LDFLAGS=-L"%DEVX_LIB_PATH%" &&
> meson.exe setup ...
> + set CFLAGS=-I"%DEVX_INC_PATH%"
> + set LDFLAGS=-LIBPATH:"%DEVX_LIB_PATH%"
> + meson.exe setup -Denable_stdatomic=true ...
> +
> +When compiling with Clang, use either::
> +
> + meson.exe setup ^
> + "-Dc_args=-I\"%DEVX_INC_PATH%\"" ^
> + "-Dc_link_args=-Wl,-LIBPATH:\"%DEVX_LIB_PATH%\"" ^
> + ...
> +
> +or::
> +
> + set CFLAGS=-I"%DEVX_INC_PATH%"
> + set LDFLAGS=-Wl,-LIBPATH:"%DEVX_LIB_PATH%"
> + meson.exe setup ...
>
>
> .. _mlx5_common_env:
> --
> 2.50.1.vfs.0.0
>
>
[-- Attachment #2: Type: text/html, Size: 3174 bytes --]
prev parent reply other threads:[~2025-07-15 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 15:22 [PATCH] " Andre Muezerie
2025-07-15 12:03 ` Dariusz Sosnowski
2025-07-15 13:57 ` Andre Muezerie
2025-07-15 14:14 ` [PATCH v2] " Andre Muezerie
2025-07-15 18:47 ` Patrick Robb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUChvkJkMsGC3RVn_uEw2GPD8F6tcetDVPfSqEb3Sfrsnw@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=abailey@iol.unh.edu \
--cc=andremue@linux.microsoft.com \
--cc=bingz@nvidia.com \
--cc=ci@dpdk.org \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=mmahajan@iol.unh.edu \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).