From: Patrick Robb <probb@iol.unh.edu>
To: Dean Marx <dmarx@iol.unh.edu>
Cc: luca.vizzarro@arm.com, yoan.picchi@foss.arm.com,
Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com,
dev@dpdk.org
Subject: Re: [PATCH v3 1/2] dts: make one link the default topology
Date: Wed, 27 Aug 2025 22:11:39 -0400 [thread overview]
Message-ID: <CAJvnSUCuiDEiKASDNW79zOQMakDGO0eTMOJfpEDJD3ZcS4fYog@mail.gmail.com> (raw)
In-Reply-To: <20250820140651.39604-2-dmarx@iol.unh.edu>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
This looks good except that I found the commit message to be confusing. For
instance, it is not true that all one link test runs will skip before this
patch - they will in fact run. I do know what you mean of course but I
think we should just be more clear.
I just modified the commit message to the below (ran the check scripts of
course) and pushed. Thank you for the patch!
dts: make one link the default topology
Currently the default topology for test suites when not specified
is two link. However, the majority of the DPDK functions tested
in DTS can be tested with a single link. It is more intuitive for
a testsuite or testcase lacking a topology decorator to default
to the more basic requirement of 1 link, and force tests which
really do require two link to include decorators explicitly
saying so.
This is now applied to next-dts.
[-- Attachment #2: Type: text/html, Size: 1063 bytes --]
next prev parent reply other threads:[~2025-08-28 2:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 13:50 [PATCH v1] " Dean Marx
2025-07-28 12:15 ` Luca Vizzarro
2025-08-07 14:07 ` [PATCH v2 1/2] dts: rewrite two link topology requirements Dean Marx
2025-08-07 14:07 ` [PATCH v2 2/2] dts: make one link the default topology Dean Marx
2025-08-11 10:47 ` Luca Vizzarro
2025-08-11 10:47 ` [PATCH v2 1/2] dts: rewrite two link topology requirements Luca Vizzarro
2025-08-11 10:50 ` Luca Vizzarro
2025-08-20 14:06 ` [PATCH v3 0/2] dts: change default topology to one link Dean Marx
2025-08-20 14:06 ` [PATCH v3 1/2] dts: make one link the default topology Dean Marx
2025-08-28 2:11 ` Patrick Robb [this message]
2025-08-20 14:06 ` [PATCH v3 2/2] dts: rewrite two link topology requirements Dean Marx
2025-08-26 14:03 ` Luca Vizzarro
2025-08-28 2:14 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUCuiDEiKASDNW79zOQMakDGO0eTMOJfpEDJD3ZcS4fYog@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).