DPDK patches and discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: Andrew Bailey <abailey@iol.unh.edu>
Cc: luca.vizzarro@arm.com, dev@dpdk.org, dmarx@iol.unh.edu
Subject: Re: [PATCH v9 3/3] dts: add Rx Tx offload test suite
Date: Fri, 24 Oct 2025 15:21:47 -0400	[thread overview]
Message-ID: <CAJvnSUCz3743gtixSvFbt=utFHk=cGd+WhGV1VbFAHs5DJem0g@mail.gmail.com> (raw)
In-Reply-To: <20251023123223.56924-4-abailey@iol.unh.edu>

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On Thu, Oct 23, 2025 at 8:32 AM Andrew Bailey <abailey@iol.unh.edu> wrote:

>
>      def _set_all_queues_mbuf_fast_free(
> -        self, testpmd: TestPmd, port_id: int, on: bool, num_queues: int,
> /, verify: bool = True
> +        self,
> +        testpmd: TestPmd,
> +        port_id: int,
> +        on: bool,
> +        num_queues: int,
>      ) -> None:
>          for i in range(num_queues):
>              testpmd.set_queue_mbuf_fast_free(on, port_id, i, verify)
>

on and port_id are swapped from where they should be in the function call
above. I swapped these and reran the test and it's now working on Intel
E810. Normally I would just fixup and merge but since you have to submit a
new version anyways because of the issue noted in the 1/3 patch you can
send the new version with this correction.


> @@ -61,25 +64,24 @@ def test_mbuf_fast_free_configuration_per_port(self)
> -> None:
>              * Mbuf_fast_free can be configured on per port.
>          """
>          with TestPmd() as testpmd:
> -            to_verify = True
>              port_id = 0
>              testpmd.start_all_ports()
>
>

[-- Attachment #2: Type: text/html, Size: 1801 bytes --]

      reply	other threads:[~2025-10-24 19:22 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 11:43 [PATCH v1 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 1/3] dts: fix docstring typo in checksum suite Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 2/3] dts: add reception check to checksum offload suite Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 3/3] dts: all are one Andrew Bailey
2025-09-02 11:48 ` [PATCH v1 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-24 16:47 ` [PATCH v4 0/3] dts:add " Andrew Bailey
2025-09-24 16:47   ` [PATCH v4 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-24 20:51     ` Patrick Robb
2025-09-25 16:01     ` Luca Vizzarro
2025-09-24 16:47   ` [PATCH v4 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-09-24 20:51     ` Patrick Robb
2025-09-25 16:05     ` Luca Vizzarro
2025-09-24 16:47   ` [PATCH v4 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-09-24 20:53     ` Patrick Robb
2025-09-29 17:06 ` [PATCH v5 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-29 17:06   ` [PATCH v5 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-29 17:06   ` [PATCH v5 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-10-15 15:34     ` Patrick Robb
2025-09-29 17:27 ` [PATCH v6 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-29 17:27   ` [PATCH v6 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-30 12:51     ` Luca Vizzarro
2025-10-09 15:53     ` Dean Marx
2025-09-29 17:27   ` [PATCH v6 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-09-30 12:55     ` Luca Vizzarro
2025-10-09 15:55     ` Dean Marx
2025-09-29 17:27   ` [PATCH v6 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-09-30 12:57     ` Luca Vizzarro
2025-10-09 15:56     ` Dean Marx
2025-10-16 13:24 ` [PATCH v7 0/3] add tx_offload support in dts Andrew Bailey
2025-10-16 13:24   ` [PATCH v7 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-10-21 13:28     ` Luca Vizzarro
2025-10-16 13:24   ` [PATCH v7 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-10-21 13:50     ` Luca Vizzarro
2025-10-16 13:24   ` [PATCH v7 3/3] dts: update tx_offload test from legacy dts to next dts Andrew Bailey
2025-10-21 13:51     ` Luca Vizzarro
2025-10-21 14:45 ` [PATCH v8 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-10-21 14:45   ` [PATCH v8 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-10-21 15:15     ` Luca Vizzarro
2025-10-21 15:27     ` Luca Vizzarro
2025-10-21 14:45   ` [PATCH v8 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-10-21 15:19     ` Luca Vizzarro
2025-10-21 15:29     ` Luca Vizzarro
2025-10-21 14:45   ` [PATCH v8 3/3] dts: update tx_offload test from legacy dts to next dts Andrew Bailey
2025-10-21 15:31     ` Luca Vizzarro
     [not found] ` <20251023123223.56924-1-abailey@iol.unh.edu>
2025-10-23 12:32   ` [PATCH v9 1/3] dts: allow mbuf fast free to be set with testpmd shell Andrew Bailey
2025-10-24 19:20     ` Patrick Robb
2025-10-23 12:32   ` [PATCH v9 2/3] dts: add Tx offload capabilities to NIC capabilities Andrew Bailey
2025-10-23 12:32   ` [PATCH v9 3/3] dts: add Rx Tx offload test suite Andrew Bailey
2025-10-24 19:21     ` Patrick Robb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJvnSUCz3743gtixSvFbt=utFHk=cGd+WhGV1VbFAHs5DJem0g@mail.gmail.com' \
    --to=probb@iol.unh.edu \
    --cc=abailey@iol.unh.edu \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=luca.vizzarro@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).