From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40F1B45E7C; Wed, 11 Dec 2024 22:24:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9DC840263; Wed, 11 Dec 2024 22:24:48 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id C223140263 for ; Wed, 11 Dec 2024 22:24:47 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7fd5248d663so3043236a12.0 for ; Wed, 11 Dec 2024 13:24:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1733952287; x=1734557087; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KcBpe4vQ8PgxSSroR/w9L0Xxjge30ZvYQu0ELu5fElY=; b=XkzIW0A436boO5TyEmPHk8Xep5mTazbqI3gGXX2HiZOWz3JJbA9Q5fVVrg9uUtl6Gk 5sh3yMNoc3+yLp50Le8GhMKX52Bb3CIcOT0Em7lEo0XRMheD0s+hn8QCFIjkwGr4ODXN 0CCV5Z79SP/IY2yYodD4zO+pZI95AMEddF5LY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733952287; x=1734557087; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KcBpe4vQ8PgxSSroR/w9L0Xxjge30ZvYQu0ELu5fElY=; b=vAXOUXjomKaX5IMVyjZM9o7qWKetwxTkekDSBz0gtpvlav6Em2xGU5FZTCp32bNfd7 06hubtWPybAZXu4tJCr3dLWZ0TTf/ikZBxYHZlytQFMfsbf2n3LYhHgPNMSRCDCP8Rwr 1Xn0nYEOx1e6CLCpatfJaXiB0L3n02uqkNqo5EC4wON5f9Y6nOLRC/9h7QA7kVfPQjCu J5/P3nxxgxRotguMAnizhnuQ7VXXOHC4kGx8bbT9Maq861szrjO42FCI91oZgYcrdilo BzL6M1tgx4Eja5dzUg2eJUo4DZ2uklZ3goNu20NUaoOK9q8AwbApP8Reys+YJII7uRls c6ww== X-Forwarded-Encrypted: i=1; AJvYcCWk0UCUhk0rOXPvhIgqo1v+2sX7tfJYyTjTTNJGMbo7QWZS0b4X1gL2Pucsrv8EMdd5Xbw=@dpdk.org X-Gm-Message-State: AOJu0Yxt/A9NgR5SeofB0LXr2MMvU0LnDAvbJWfPvIZ8tyFyxVpPvCVv xsY9BOFo61rRxUVFFudtzuXHtSjYsXGC4iiHO+7/PujA8XzN4/xYyjYDag0GkK629YqFrHNMpi1 yata4MtVDskklPrSQGNfCwH9JBEb4p7qxECQuqw== X-Gm-Gg: ASbGncsb4nGZbeDEh/q8OqZSt/wM884R9Mz+XCLFndalfDesKgrQ0TMsqxHY2ajmv1X n54lVCLB0P3PaZ9nrj/e1h9eVrJBG8Sr/A1NWIU1niRpx9aRR0kblJaTN795lh71HyrBx X-Google-Smtp-Source: AGHT+IGTCYlWj+6PXd8Yhm6IOSgGGM/jFXx7GLT3OEJbEdGZ0HaEhDJ7WkDHAGpsTkY3MKM23NYCuW2tIL03OGYYamo= X-Received: by 2002:a17:90b:3c83:b0:2ea:3f34:f18f with SMTP id 98e67ed59e1d1-2f1392b75b0mr2049536a91.19.1733952286665; Wed, 11 Dec 2024 13:24:46 -0800 (PST) MIME-Version: 1.0 References: <20241210091039.3439504-1-david.marchand@redhat.com> <20241211065554.25c3757c@hermes.local> <8983544.lOV4Wx5bFT@thomas> In-Reply-To: <8983544.lOV4Wx5bFT@thomas> From: Patrick Robb Date: Wed, 11 Dec 2024 16:22:27 -0500 Message-ID: Subject: Re: [PATCH] devtools: enhance the license check To: Thomas Monjalon Cc: David Marchand , Stephen Hemminger , Paul Szczepanek , dev@dpdk.org, techboard@dpdk.org Content-Type: multipart/alternative; boundary="0000000000001accf60629053a61" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000001accf60629053a61 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://python-poetry.org/docs/basic-usage/#committing-your-poetrylock-file= -to-version-control I agree at first glance it appears like poetry.lock should go in the .gitignore. However, the official docs state that in the case of developing an application (like DTS), one should commit the generated poetry.lock file to version control, as it provides a universal lock on python dependencies, across all minor versions of python specified in the pyproject.toml, and it also speeds up the dependency resolution process. I gather from reading some posts online that some folks do opt to .gitignore their poetry.lock files for shippable applications, relying solely on the pyproject.toml as a source of truth for dependency versions. But, again this approach does not guarantee common dependencies across all the python minor versions supported by the project. I will bring this up at the CI call tomorrow morning for feedback though. On Wed, Dec 11, 2024 at 10:01=E2=80=AFAM Thomas Monjalon wrote: > 11/12/2024 15:55, Stephen Hemminger: > > On Wed, 11 Dec 2024 10:00:38 +0100 > > David Marchand wrote: > > > > > On Tue, Dec 10, 2024 at 6:00=E2=80=AFPM Stephen Hemminger > > > wrote: > > > > > > > > On Tue, 10 Dec 2024 10:10:39 +0100 > > > > David Marchand wrote: > > > > > > > > > +no_license_list=3D\ > > > > > +':^.git* :^.mailmap :^.ci/* :^README :^MAINTAINERS :^VERSION > :^ABI_VERSION :^*/Kbuild '\ > > > > > +':^*/README* :^license/ :^config/ :^buildtools/ :^*/poetry.lock = '\ > > > > > +':^kernel/linux/uapi/.gitignore :^kernel/linux/uapi/version > :^*.cocci :^*.abignore '\ > > > > > +':^*.map :^*.ini :^*.data :^*.json :^*.cfg :^*.txt :^*.svg > :^*.png' > > > > > + > > > > > > > > What is poetry.lock? > > > > > > I don't know. > > > It looks like some python packaging config for dts, and it is a > generated file. > > > # This file is automatically @generated by Poetry 1.8.3 and should no= t > > > be changed by hand. > > > > > > Cc: dts maintainers. > > > > > > > > > > Put it in .gitignore then please, and the script will ignore that. > > How is it related? > > I don't like adding versioned files to .gitignore. > (this poetry file is in the repository) > > > --0000000000001accf60629053a61 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
https://python-poetry.org/= docs/basic-usage/#committing-your-poetrylock-file-to-version-control
I agree at first glance it appears like poetry.lock should go in the .= gitignore. However, the official docs state that in the case of developing = an application (like DTS), one should commit the generated poetry.lock file= to version control, as it provides a universal lock on python dependencies= , across all minor versions of python specified in the pyproject.toml, and = it also speeds up the dependency resolution process.

I g= ather from reading some posts online that some folks do opt to .gitignore t= heir poetry.lock files for shippable applications, relying solely on the py= project.toml as a source of truth for dependency versions. But, again this = approach does not guarantee common dependencies across all the python minor= versions supported by the project.=C2=A0

I will b= ring this up at the CI call tomorrow morning for feedback though.

On Wed, Dec 11, 2024 at 10:01=E2=80=AFAM Thomas Monjalon = <thomas@monjalon.net> wrot= e:
11/12/2024 15= :55, Stephen Hemminger:
> On Wed, 11 Dec 2024 10:00:38 +0100
> David Marchand <david.marchand@redhat.com> wrote:
>
> > On Tue, Dec 10, 2024 at 6:00=E2=80=AFPM Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > >
> > > On Tue, 10 Dec 2024 10:10:39 +0100
> > > David Marchand <david.marchand@redhat.com> wrote:
> > >=C2=A0
> > > > +no_license_list=3D\
> > > > +':^.git* :^.mailmap :^.ci/* :^README :^MAINTAINERS= :^VERSION :^ABI_VERSION :^*/Kbuild '\
> > > > +':^*/README* :^license/ :^config/ :^buildtools/ :^= */poetry.lock '\
> > > > +':^kernel/linux/uapi/.gitignore :^kernel/linux/uap= i/version :^*.cocci :^*.abignore '\
> > > > +':^*.map :^*.ini :^*.data :^*.json :^*.cfg :^*.txt= :^*.svg :^*.png'
> > > > +=C2=A0
> > >
> > > What is poetry.lock?=C2=A0
> >
> > I don't know.
> > It looks like some python packaging config for dts, and it is a g= enerated file.
> > # This file is automatically @generated by Poetry 1.8.3 and shoul= d not
> > be changed by hand.
> >
> > Cc: dts maintainers.
> >
> >
>
> Put it in .gitignore then please, and the script will ignore that.

How is it related?

I don't like adding versioned files to .gitignore.
(this poetry file is in the repository)


--0000000000001accf60629053a61--