Re: [PATCH v5] dts: enable port binding on the TG

[Patrick Robb <probb@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]

On Wed, Sep 10, 2025 at 8:30 AM Andrew Bailey <abailey@iol.unh.edu> wrote:

> Currently, ports on the TG are not bound to the correct drivers prior to
> running DTS. This causes DTS to crash if they are not initially bound to
> the intended drivers. Binding the TG ports to the proper driver caused
> DTS to fail when the OS and DPDK drivers were the same, due to the port
> link not being up.


This probably does not read very clearly to people not working on DTS. I
would be more "to the point" by saying something like "Currently, DTS will
not attempt to bind the TG interfaces to the kernel driver automatically,
meaning the user must manually verify the TG binding before running DTS.
Also, when the TG and DPDK drivers are the same, DTS will not automatically
attempt to bring up the link on the TG port. So, this change adds both of
these automatic steps for the TG."


> Changing the bound_for_dpdk method for a port to
> return false when the OS driver and DPDK driver were shared on a TG
> node allowed the TG ports to enter the logic to be brought up in the
> configure_ports method within the topology class.
>

I believe this is a carry over from your V3. The V4 and V5 patches do not
include this change to the bound_for_dpdk property.

Otherwise, the commit looks good, thank you! I will tweak the commit
message itself per my preferences above when I merge to next-dts.

[-- Attachment #2: Type: text/html, Size: 1986 bytes --]