From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3CD743F56; Tue, 30 Apr 2024 22:57:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AD2F40262; Tue, 30 Apr 2024 22:57:53 +0200 (CEST) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by mails.dpdk.org (Postfix) with ESMTP id 189EF4025C for ; Tue, 30 Apr 2024 22:57:53 +0200 (CEST) Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5aa2bd6f651so4409447eaf.0 for ; Tue, 30 Apr 2024 13:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1714510672; x=1715115472; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=c30i6hIZOxWXwIjJnTC6BEYqwLdGdnUdV4RIJrBl7l4=; b=URgqrUgj/gl6SxW0uclQxmfoz1zq9pihIcFdw/GFGg7JuXT1woFD9OO1MaDcaYGvQx gno7kDx9Gw6dt1p5uR41ELCEY04Gy38JeHrLjG39yjs6u7Uk3uP722Bavk5U6/hIJC6v uy3Smo0yHlFmfWXBPVmJSxOtLsbsQF0YTmeAI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714510672; x=1715115472; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c30i6hIZOxWXwIjJnTC6BEYqwLdGdnUdV4RIJrBl7l4=; b=vFu4Yzoi3F98yZgFMiR47YWDk9bfNll/sfXr+mWbsaFWkW5eWTjuApA/LwT6w9MfbI bRzVoMwCZRjDPMAyWDnlzZIPXObWWt9YbfcDGtoHwBRTP8lm4hNFpsUC1NuFvjDnMubT mnBFC+1VK83wnZIf5paQKnpZkV/oD0X8CQNiRCa90ReLk67OljhlCQpcwj7FajuYjnX+ yLy+fkbuihBqxWI0Th9Y4WSLWrUrdzcb6eF47pZatnnLuQFgW9nKhmYX4SgSpjNNAk5V VEmcn4/oFxnyOXaZmyrwq1ILxTk+nSBgdZDcxCMRaP7sbWNuLhZn4ReqWWccuC8UwpSV 9f8Q== X-Gm-Message-State: AOJu0YwGRKV3aVXrz0sjgkHEJ2Ij6vpOKXHAoroq2E6/dmCKgKOYnqoq e0YZ10XRw6fGnzkMFDL03jzWjJ4yIOnLbMjoW7dxB2Tp0Ya5Zk5/BSWAiDLM99dVDRGD9fqmrIH P3AKise2NBuaQHD5xvNsTslUPkblqCoT7fDdeUA== X-Google-Smtp-Source: AGHT+IErAXHVvchbP+1Fo/B1W9BtMqnopF7IljhiXeGQiST+6EQn1mvYplHwK6NxKDR++B7LaMd0qL4M/ixbQ1S6H5M= X-Received: by 2002:a4a:98f2:0:b0:5aa:3c6a:c5f3 with SMTP id b47-20020a4a98f2000000b005aa3c6ac5f3mr557401ooj.9.1714510672433; Tue, 30 Apr 2024 13:57:52 -0700 (PDT) MIME-Version: 1.0 References: <4d5510d1-bdc6-43de-abbc-749eaa3c75a4@lysator.liu.se> <28dc7dc7-eb26-4405-9d80-9d8ec10f88b2@lysator.liu.se> In-Reply-To: <28dc7dc7-eb26-4405-9d80-9d8ec10f88b2@lysator.liu.se> From: Patrick Robb Date: Tue, 30 Apr 2024 16:57:41 -0400 Message-ID: Subject: Re: Run unit tests with C++ too To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: "dev@dpdk.org" , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , "Richardson, Bruce" Content-Type: multipart/alternative; boundary="0000000000009831db0617569fcf" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000009831db0617569fcf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 30, 2024 at 4:13=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > On 2024-04-30 15:52, Patrick Robb wrote: > > > > > > On Sun, Apr 28, 2024 at 3:46=E2=80=AFAM Mattias R=C3=B6nnblom > > wrote: > > > > It would be great if the unit test suite (app/test/*) was compiled > (and > > run) using a C++ (C++11) compiler as well. At least, if such is > > available. > > > > > > Sure, the UNH Lab can try this. > > > > > > With the current state of affairs, header file macros or functions > are > > not verified to be functional (or even valid) C++. > > > > "C is a subset of C++", which was never true, is becoming less and > > less so. > > > > If all unit tests aren't valid C++, maybe one could start with an > "opt > > in" model. > > > > > > Okay, so basically run the fast-test suite, record all that don't pass, > > submit a bugzilla ticket stating which unit tests are not valid on a > > certain c++ compiler, then bring CI Testing online using the valid > > subset of fast-tests. This should work. > > > > Sounds good. > > Just to be clear: the above includes extending the DPDK build system to > build the app/test/dpdk-test binary in two versions: one C and one C++, > so that anyone can run the C++ tests locally as well. Correct? > Okay, so now I am understanding this is not yet available. When I responded this morning I was figuring that c++ compiler support was available and I simply wasn't aware, and that we could quite easily set cc=3D{some c++ compiler}, meson would pick it up, and we would be able to build DPDK and then run unit tests in this manner in CI testing. I didn't mean to suggest we would submit patches extending the build system to this end. That's probably a little out of scope for what we try to accomplish at the Community Lab. But if the aforementioned build system support is added, of course we are willing to add that as a build environment for unit tests and report those respective results. --0000000000009831db0617569fcf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Apr 30, 2024 at 4:13=E2=80=AF= PM Mattias R=C3=B6nnblom <hofor= s@lysator.liu.se> wrote:
On 2024-04-30 15:52, Patrick Robb wrote:
>
>
> On Sun, Apr 28, 2024 at 3:46=E2=80=AFAM Mattias R=C3=B6nnblom <hofors@lysator.liu.s= e
> <mailto:= hofors@lysator.liu.se>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0It would be great if the unit test suite (app/test/= *) was compiled (and
>=C2=A0 =C2=A0 =C2=A0run) using a C++ (C++11) compiler as well. At least= , if such is
>=C2=A0 =C2=A0 =C2=A0available.
>
>
> Sure, the UNH Lab can try this.
>
>
>=C2=A0 =C2=A0 =C2=A0With the current state of affairs, header file macr= os or functions are
>=C2=A0 =C2=A0 =C2=A0not verified to be functional (or even valid) C++.<= br> >
>=C2=A0 =C2=A0 =C2=A0"C is a subset of C++", which was never t= rue, is becoming less and
>=C2=A0 =C2=A0 =C2=A0less so.
>
>=C2=A0 =C2=A0 =C2=A0If all unit tests aren't valid C++, maybe one c= ould start with an "opt
>=C2=A0 =C2=A0 =C2=A0in" model.
>
>
> Okay, so basically run the fast-test suite, record all that don't = pass,
> submit a bugzilla ticket stating which unit tests are not valid on a <= br> > certain c++ compiler, then bring CI Testing online using the valid > subset of fast-tests. This should=C2=A0work.
>

Sounds good.

Just to be clear: the above includes extending the DPDK build system to build the app/test/dpdk-test binary in two versions: one C and one C++, so that anyone can run the C++ tests locally as well. Correct?

Okay, so now I am understanding this is not yet ava= ilable. When I responded this morning I was figuring that c++ compiler supp= ort was available and I simply wasn't aware, and that we could quite ea= sily set cc=3D{some c++ compiler}, meson would pick it up, and we would be = able to build DPDK and then run unit tests in this manner in CI testing.=C2= =A0

I didn't mean to suggest we would submit p= atches extending the build system to this end. That's probably a little= out of scope for what we try to accomplish at the Community Lab.=C2=A0

But if the aforementioned build system support is add= ed, of course we are willing to add that as a build environment for unit te= sts and report those respective results.
=C2=A0
--0000000000009831db0617569fcf--