From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF7AD42C5E; Thu, 8 Jun 2023 14:47:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9675C406B5; Thu, 8 Jun 2023 14:47:33 +0200 (CEST) Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by mails.dpdk.org (Postfix) with ESMTP id 7619F40042 for ; Thu, 8 Jun 2023 14:47:31 +0200 (CEST) Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-55af44f442dso377317eaf.1 for ; Thu, 08 Jun 2023 05:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1686228450; x=1688820450; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qKGv+b5Ked2qkPacUbCQTKaKNa3ThnAJt/L0jqHIUMw=; b=HPrMWCD5cdjDN6s1iDp5UMA/oO08tIpKW+OBvaDFLCpitU7U4VX943jI5X4A+1b0gr EkYtVrAwFhUoqgJZMvGW4waYDzmSxdEcYZQ9M3VYmh3AkqkgVCf/+kcvQAjtCoexLpGO CEpz8FWwG5ygFE5eW+CSbr2tCqXu3/IGrRDJc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686228450; x=1688820450; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qKGv+b5Ked2qkPacUbCQTKaKNa3ThnAJt/L0jqHIUMw=; b=VwHcvEeYKyTxnZE32uhtFFsdZ0Z1J+u0Efwwdc0RtwGxSPQGRjPm5ZY/8RVRjn5RmA YKs4xIQeTjmJAamwU20n5G0aKNhELkbc/fmMo7Y+p7CiWX8UJoOyurxIuu9OgabzL9yH IP2UE30DSeA/9asQ7YA83nhg4hyN2xfJbksN3v9T7omJy7QUUtqx2kqgfJdoRGjqBaCt 9IgxBFLoxnpGLhV+48Ct+J4DNVKWBjOrLi7f4NAikBPaUOUCozHIc2c/WBeEcbRUxjXb 7J+apwpA/LZQ8cvW6eNgf0qSWPdMhZYjCEulRozofAfmOr9tEAUES5ipB/3TULSgoUSv VhEg== X-Gm-Message-State: AC+VfDyTdHXfKx/kXaFhC8G++q40PDP7qL27SnBio2+6khqRvbur+m83 ecuPDNvVBjsmrPz98nyr8/O3SO1NFrLBJwbGL7CSPA== X-Google-Smtp-Source: ACHHUZ53+M7hE19csJYANY14gUQJs59IbjNQpW9PyFYV+4ZsyACMQXZMc+T1KmvKN5aI4i1xRA2ELUqBEIkbNCb/aT8= X-Received: by 2002:a05:6820:1b95:b0:555:5fa3:1519 with SMTP id cb21-20020a0568201b9500b005555fa31519mr1367526oob.4.1686228450662; Thu, 08 Jun 2023 05:47:30 -0700 (PDT) MIME-Version: 1.0 References: <20230525163116.682000-1-miao.li@intel.com> <20230531053743.129442-1-miao.li@intel.com> In-Reply-To: From: Patrick Robb Date: Thu, 8 Jun 2023 08:47:19 -0400 Message-ID: Subject: Re: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus To: David Marchand Cc: "Xia, Chenbo" , Ali Alnubani , "Li, Miao" , "dev@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "skori@marvell.com" , "ferruh.yigit@amd.com" , "Cao, Yahui" Content-Type: multipart/alternative; boundary="000000000000d000cb05fd9da7e7" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000d000cb05fd9da7e7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 8, 2023 at 3:03=E2=80=AFAM David Marchand wrote: > Hello Chenbo, Patrick, > > > On Thu, Jun 8, 2023 at 8:50=E2=80=AFAM Xia, Chenbo = wrote: > > > > This series introduces a VFIO standard capability, called sparse > > > > mmap to PCI bus. In linux kernel, it's defined as > > > > VFIO_REGION_INFO_CAP_SPARSE_MMAP. Sparse mmap means instead of > > > > mmap whole BAR region into DPDK process, only mmap part of the > > > > BAR region after getting sparse mmap information from kernel. > > > > For the rest of BAR region that is not mmap-ed, DPDK process > > > > can use pread/pwrite system calls to access. Sparse mmap is > > > > useful when kernel does not want userspace to mmap whole BAR > > > > region, or kernel wants to control over access to specific BAR > > > > region. Vendors can choose to enable this feature or not for > > > > their devices in their specific kernel modules. > > > > > > > > > > Hello, > > > > > > I see the build failure Patrick reported as well and can confirm it's > > > caused by 095cf6e68b28 ("bus/pci: introduce MMIO read/write"). > > > Bugzilla ticket: https://bugs.dpdk.org/show_bug.cgi?id=3D1245 > > > > Thanks Ali. I just read the bz and understand what's missing. I will se= nd > > a patch today. > > > > But since last time CI is not reporting the error, this time how could = I > make > > sure the fix will perfectly work? > > Chenbo, > > In theory, this error should have been reported so go ahead and post your > fix. > > Patrick, > > This missing report could be a mail delivery issue (I can see the test > ran at UNH). > I see no trace in test-report ml. > Can you look at the reason? > > Thanks. > > > -- > David Marchand > > I see where the issue is in our reporting process for the windows results and I will resolve it after the CI meeting this morning. Sorry everyone for the oversight. --=20 Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --000000000000d000cb05fd9da7e7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Jun 8, 2023 at 3:03=E2=80=AFA= M David Marchand <david.mar= chand@redhat.com> wrote:
Hello Chenbo, Patrick,


On Thu, Jun 8, 2023 at 8:50=E2=80=AFAM Xia, Chenbo <chenbo.xia@intel.com> wrote: > > > This series introduces a VFIO standard capability, called sp= arse
> > > mmap to PCI bus. In linux kernel, it's defined as
> > > VFIO_REGION_INFO_CAP_SPARSE_MMAP. Sparse mmap means instead = of
> > > mmap whole BAR region into DPDK process, only mmap part of t= he
> > > BAR region after getting sparse mmap information from kernel= .
> > > For the rest of BAR region that is not mmap-ed, DPDK process=
> > > can use pread/pwrite system calls to access. Sparse mmap is<= br> > > > useful when kernel does not want userspace to mmap whole BAR=
> > > region, or kernel wants to control over access to specific B= AR
> > > region. Vendors can choose to enable this feature or not for=
> > > their devices in their specific kernel modules.
> > >
> >
> > Hello,
> >
> > I see the build failure Patrick reported as well and can confirm = it's
> > caused by 095cf6e68b28 ("bus/pci: introduce MMIO read/write&= quot;).
> > Bugzilla ticket: https://bugs.dpdk.org/show_bu= g.cgi?id=3D1245
>
> Thanks Ali. I just read the bz and understand what's missing. I wi= ll send
> a patch today.
>
> But since last time CI is not reporting the error, this time how could= I make
> sure the fix will perfectly work?

Chenbo,

In theory, this error should have been reported so go ahead and post your f= ix.

Patrick,

This missing report could be a mail delivery issue (I can see the test
ran at UNH).
I see no trace in test-report ml.
Can you look at the reason?

Thanks.


--
David Marchand


I see where the issue is in our r= eporting process for the windows results and I will resolve it after the CI= meeting this morning. Sorry everyone for the oversight.=C2=A0
--

Patrick Robb

Technical Service Manager

UNH InterOperability Labora= tory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu

<= br>

--000000000000d000cb05fd9da7e7--