From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CC9A43DD8; Sat, 6 Apr 2024 02:38:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E6404028C; Sat, 6 Apr 2024 02:38:44 +0200 (CEST) Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by mails.dpdk.org (Postfix) with ESMTP id F0B0540262 for ; Sat, 6 Apr 2024 02:38:42 +0200 (CEST) Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-5a550ce1a41so1556429eaf.0 for ; Fri, 05 Apr 2024 17:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1712363922; x=1712968722; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0FaX3zsqBHZi5FdaatiBUDErF3vnlVVV4ZKp78mYGUk=; b=gdvIBm0Geed3uTpUAe2EzpUrW9i+zqKd/nFDfLdiLwnDJBpnoGKS/5+iRDN/fifKtv riC3kxk292j8zvrjeOUOHTSuiYYJJOFFFU2G4ipoJoS/N6IWQBrp9dMF0Wa6wZkphYPp b1cK2PXrBw2XBt/HfQrePuoTC/+YSN6cclSo8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712363922; x=1712968722; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0FaX3zsqBHZi5FdaatiBUDErF3vnlVVV4ZKp78mYGUk=; b=Cpxx1Ug61maclUwNTzGFm1vpYFCSJ57wKzEZC23B5GZ7DvVP8tflN2aCNrQqbP7EcS l4QTbhB2ho1t+3NrSFT3uUhIo0prLFXTX03qDdvRn+jnVcoqfA/+2uoYpImkXCNiuW8I CwbdoMiBUxelkZyKxIhxZ8tkgs3Vg+5FBheuwXthmDCHweMJ91Ol3v0J7jfv8l6cPxqY afHjKp/g7MbhChPFTCMa76fMhz9/31Q7S7aTsAdU7VdUnM1f24jPbfYodmPJZDvchsk3 YlgpEzaVqWcKQLN22rd3IfOMYY5otFCbqA++zD0p08U7N4dquaNgHwtb2CAFhhv5O8km mCHg== X-Gm-Message-State: AOJu0YyOMNTqoznD7A0lW7zG3ZHs1RyEv2HSugqS72+q4PiTM+w+fl7V EVugiAPyYlF9IlHzsWuORGZThlIuU25rFhYaCKf5jqVsIK/zyH+Xs7KdPHEbu4NlIwoYfCnyiFr KFB2c9zk7ttgyEG7RZoMKF6ubmF6BpI+DOIL9MQ== X-Google-Smtp-Source: AGHT+IHvr6e6CMPTpqR876BtgLhxIArlsRFgvqaov5aSnitegZ5yeWVlKh+EuyPBniwDWZtshT5xPpYJ+iowzgbHFko= X-Received: by 2002:a05:6820:2184:b0:5a1:cefd:73d6 with SMTP id ce4-20020a056820218400b005a1cefd73d6mr3555712oob.7.1712363922269; Fri, 05 Apr 2024 17:38:42 -0700 (PDT) MIME-Version: 1.0 References: <1712076948-25853-1-git-send-email-roretzla@linux.microsoft.com> <1712168600-17289-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1712168600-17289-1-git-send-email-roretzla@linux.microsoft.com> From: Patrick Robb Date: Fri, 5 Apr 2024 20:38:31 -0400 Message-ID: Subject: Re: [PATCH v2] build: exclude rather than include libs in MSVC build To: Tyler Retzlaff Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Honnappa Nagarahalli , Kevin Laatz , Srikanth Yalavarthi , Vladimir Medvedkin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Recheck-request: iol-intel-Functional Replied to the wrong version before On Wed, Apr 3, 2024 at 2:23=E2=80=AFPM Tyler Retzlaff wrote: > > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > With this change we now get immediate CI build coverage for the libs > meter, timer, pci, cfgfile > > v2: > * add a few more explicit exclusions for now as they are known to requir= e > more than trivial work and avoid needing to disable them later as the > dependent libraries are enabled. > > Tyler Retzlaff (1): > build: exclude rather than include libs in MSVC build > > lib/argparse/meson.build | 6 ++++++ > lib/dmadev/meson.build | 6 ++++++ > lib/fib/meson.build | 6 ++++++ > lib/lpm/meson.build | 6 ++++++ > lib/mbuf/meson.build | 6 ++++++ > lib/mempool/meson.build | 6 ++++++ > lib/meson.build | 10 ---------- > lib/mldev/meson.build | 6 ++++++ > lib/rcu/meson.build | 6 ++++++ > lib/stack/meson.build | 6 ++++++ > 10 files changed, 54 insertions(+), 10 deletions(-) > > -- > 1.8.3.1 >