From: Patrick Robb <probb@iol.unh.edu>
To: Nicholas Pratte <npratte@iol.unh.edu>
Cc: yoan.picchi@foss.arm.com, ian.stokes@intel.com,
stephen@networkplumber.org, Honnappa.Nagarahalli@arm.com,
luca.vizzarro@arm.com, thomas@monjalon.net,
thomas.wilks@arm.com, dmarx@iol.unh.edu,
paul.szczepanek@arm.com, dev@dpdk.org
Subject: Re: [PATCH v1 1/2] dts: add fwd restart decorator to rx capabilities
Date: Sun, 19 Jan 2025 20:11:38 -0500 [thread overview]
Message-ID: <CAJvnSUDM9W0+3ufuL+Pae4mZKr7yV6UK6qJ+1pBMbZawdbz+QA@mail.gmail.com> (raw)
In-Reply-To: <20250117145838.40206-2-npratte@iol.unh.edu>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Fri, Jan 17, 2025 at 9:58 AM Nicholas Pratte <npratte@iol.unh.edu> wrote:
> - @requires_started_ports
+ @requires_forwarding_restart
> @requires_stopped_ports
> def set_port_mtu(self, port_id: int, mtu: int, verify: bool = True)
> -> None:
> """Change the MTU of a port using testpmd.
>
Is the requires_stopped_ports decorated still required, or is the
requires_forwarding_restart decorator alone sufficient?
Looks good otherwise thanks!
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
[-- Attachment #2: Type: text/html, Size: 1153 bytes --]
next prev parent reply other threads:[~2025-01-20 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 14:58 [PATCH v1 0/2] dts: mtu update and jumbo frames test suite Nicholas Pratte
2025-01-17 14:58 ` [PATCH v1 1/2] dts: add fwd restart decorator to rx capabilities Nicholas Pratte
2025-01-20 1:11 ` Patrick Robb [this message]
2025-01-17 14:58 ` [PATCH v1 2/2] dts: add mtu update and jumbo frames test suite Nicholas Pratte
2025-01-20 1:47 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUDM9W0+3ufuL+Pae4mZKr7yV6UK6qJ+1pBMbZawdbz+QA@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=ian.stokes@intel.com \
--cc=luca.vizzarro@arm.com \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas.wilks@arm.com \
--cc=thomas@monjalon.net \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).