From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8632846074; Mon, 20 Jan 2025 02:14:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A7E1402A4; Mon, 20 Jan 2025 02:14:35 +0100 (CET) Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by mails.dpdk.org (Postfix) with ESMTP id 66E944029B for ; Mon, 20 Jan 2025 02:14:33 +0100 (CET) Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-5174f9c0d2aso1264483e0c.1 for ; Sun, 19 Jan 2025 17:14:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1737335672; x=1737940472; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dWQSyqscDq2pMDhvMbrmt9zfnG+RN0vf8zdxJbJJsl0=; b=WWnDs1Ny32LGmyCt7tGXkumHHb/Onc7uhJmd0CaPyb+S/OlvtLlBgJ0ON85Xtgghjn i68l4mG3fDTr1teNigyaiO+T5K6vj2Ik1apn60vy6UL9BHmLntCdn6vsyLTJRDGyREYR wAR0P+r3wt22q5cEWF1+5WzRGngnQVXVG3Nfg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737335672; x=1737940472; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dWQSyqscDq2pMDhvMbrmt9zfnG+RN0vf8zdxJbJJsl0=; b=aGQXRu5qZ2kHb4GMZbPN+rSeLNZ0bWA6sJS0iBLQlkVmpTZ3qKS/J5wd/EUGzYSzlu /pf1q7c1hG5ipHlwXrL4wFGsu7wgixPTwjf8N3PrAhB0aHvQUdYhP+qLmSDoYVdXrPy7 nBc+rznuupl1ug6DUgeHR/v8ebK17EPhHQV/FWqx33ajOEVJj+6Rl1ttFglnlu7hriOB ZOXoNloec1MImWZ2nqJzcYptT3766h+Oe7Ufi6D5bHVMBEFtOWuSHpoIzhJKsY/+SkUO Pj3ZGp4/I1MB5VwnfOgVpMeFbIjadogPJBUA7b0+9H69QaJbVPxRyt3aE1j87yJBZG1n /aEg== X-Forwarded-Encrypted: i=1; AJvYcCUwQ9SVDTus5afX/gSxjkhkxa8py6FFeqfGQRH8ia3BBHm4nnZAluae7ghKHZnRhSif4DE=@dpdk.org X-Gm-Message-State: AOJu0Yzu/sLCZ89bZxDYvDhGk2OgGKYDO83Dq/o3qt61k/v2Ce/B4wri Y+btP85/WTbdVnkzSbTrsecbKePvJvytaUCxNpRkAIDcpwWQB+sfe9v7Ga0R7mGNCTZqHJm3QMi it1esOd4q56uV0ekIBQjbk8qAV2Dt037yFQwPAkf3nSkBmIu7 X-Gm-Gg: ASbGnctDZ/s8/O0C2RYFnUlbYjH4hcXPm9r0gZdigcdndukTenLwUv7xd0uXMDveUKq aY4oDAABC+nWZO/H/ePsziEv4UW0dsk8mYgROZZrvHzeUtdb4960f/pLyaGRZp8DbO+M= X-Google-Smtp-Source: AGHT+IF7jGSpIA9d0c+7v2YSZAZeDxYbmr5bdUHoy3846K/JDWR5ZEJmdcE0ZRw/kdrxFLJRxHoUOenEbiiCrR8aRYQ= X-Received: by 2002:a05:6122:88b:b0:518:a0ee:e8e7 with SMTP id 71dfb90a1353d-51d51a6328amr8754362e0c.0.1737335672633; Sun, 19 Jan 2025 17:14:32 -0800 (PST) MIME-Version: 1.0 References: <20250117145838.40206-1-npratte@iol.unh.edu> <20250117145838.40206-2-npratte@iol.unh.edu> In-Reply-To: <20250117145838.40206-2-npratte@iol.unh.edu> From: Patrick Robb Date: Sun, 19 Jan 2025 20:11:38 -0500 X-Gm-Features: AbW1kvauo3JQMA_BVwHEeqBYwBGBnNsIShFX7UOUQPaQqeIdZUjWm0W3JU-XblI Message-ID: Subject: Re: [PATCH v1 1/2] dts: add fwd restart decorator to rx capabilities To: Nicholas Pratte Cc: yoan.picchi@foss.arm.com, ian.stokes@intel.com, stephen@networkplumber.org, Honnappa.Nagarahalli@arm.com, luca.vizzarro@arm.com, thomas@monjalon.net, thomas.wilks@arm.com, dmarx@iol.unh.edu, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="0000000000009fab33062c18fbdc" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000009fab33062c18fbdc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 17, 2025 at 9:58=E2=80=AFAM Nicholas Pratte wrote: > - @requires_started_ports + @requires_forwarding_restart > @requires_stopped_ports > def set_port_mtu(self, port_id: int, mtu: int, verify: bool =3D True= ) > -> None: > """Change the MTU of a port using testpmd. > Is the requires_stopped_ports decorated still required, or is the requires_forwarding_restart decorator alone sufficient? Looks good otherwise thanks! Reviewed-by: Patrick Robb --0000000000009fab33062c18fbdc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Jan 17,= 2025 at 9:58=E2=80=AFAM Nicholas Pratte <npratte@iol.unh.edu> wrote:
-=C2=A0 =C2=A0 @requires_started_ports
+=C2=A0 =C2=A0 @requires_forwarding_restart
=C2=A0 =C2=A0 =C2=A0@requires_stopped_ports
=C2=A0 =C2=A0 =C2=A0def set_port_mtu(self, port_id: int, mtu: int, verify: = bool =3D True) -> None:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""Change the MTU of a por= t using testpmd.

Is the requires_stoppe= d_ports decorated still required, or is the requires_forwarding_restart dec= orator=C2=A0alone sufficient?=C2=A0
=C2=A0

Looks good otherwise thanks!

Reviewed-by: Patri= ck Robb <probb@iol.unh.edu><= /div>
--0000000000009fab33062c18fbdc--