From: Patrick Robb <probb@iol.unh.edu>
To: Paul Szczepanek <paul.szczepanek@arm.com>
Cc: dev@dpdk.org, Luca Vizzarro <luca.vizzarro@arm.com>
Subject: Re: [PATCH v1 2/2] dts: adjust all tests to use the new API calls
Date: Thu, 16 Oct 2025 07:44:00 -0400 [thread overview]
Message-ID: <CAJvnSUDfnBBM153LTcoDfddde8dLOLQrqNUh3_6wsbYdFwMh=A@mail.gmail.com> (raw)
In-Reply-To: <20250923103758.3192015-3-paul.szczepanek@arm.com>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Looks good. My only concern is whether this will limit packet/test function
visibility by pushing people to explicitly import individual functions from
the API. I don't think this will happen because it will be very clear
developers should review the API files before writing a testsuite. And, if
they don't want to do an individual function import they can always do a
"import api.test as test" or similar and have autocomplete for all the
packet functions. So, I think there is not an issue and we are good to
proceed, but I figured I'd just mention my thoughts.
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
[-- Attachment #2: Type: text/html, Size: 728 bytes --]
next prev parent reply other threads:[~2025-10-16 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 10:37 [PATCH v1 0/2] Move TestSuite methods to API modules Paul Szczepanek
2025-09-23 10:37 ` [PATCH v1 1/2] dts: add packet handling and test utilities to API Paul Szczepanek
2025-10-16 11:36 ` Patrick Robb
2025-09-23 10:37 ` [PATCH v1 2/2] dts: adjust all tests to use the new API calls Paul Szczepanek
2025-10-16 11:44 ` Patrick Robb [this message]
2025-10-21 13:52 ` [PATCH v1 0/2] Move TestSuite methods to API modules Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJvnSUDfnBBM153LTcoDfddde8dLOLQrqNUh3_6wsbYdFwMh=A@mail.gmail.com' \
--to=probb@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).