* [PATCH] app/testpmd: fix incorrect function names in logs
@ 2025-12-01 10:08 Anurag Mandal
2025-12-01 15:58 ` Patrick Robb
0 siblings, 1 reply; 2+ messages in thread
From: Anurag Mandal @ 2025-12-01 10:08 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, aman.deep.singh, stephen, Anurag Mandal, stable
VLAN extend and tpid setting functions have wrong function names
mentioned in the error logs causing confusion as functions are
not found in code using those names.
Replaced static names with dynamic "__func__" predefined identifier.
Fixes: 61a3b0e5e79f ("app/testpmd: send failure logs to stderr")
Cc: stable@dpdk.org
Signed-off-by: Anurag Mandal <anurag.mandal@intel.com>
---
app/test-pmd/config.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 6ea506254b..afaf9194ba 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -6502,8 +6502,8 @@ vlan_extend_set(portid_t port_id, int on)
diag = rte_eth_dev_set_vlan_offload(port_id, vlan_offload);
if (diag < 0) {
fprintf(stderr,
- "rx_vlan_extend_set(port_pi=%d, on=%d) failed diag=%d\n",
- port_id, on, diag);
+ "%s(port_pi=%d, on=%d) failed diag=%d\n",
+ __func__, port_id, on, diag);
return;
}
ports[port_id].dev_conf.rxmode.offloads = port_rx_offloads;
@@ -6729,8 +6729,8 @@ vlan_tpid_set(portid_t port_id, enum rte_vlan_type vlan_type, uint16_t tp_id)
return;
fprintf(stderr,
- "tx_vlan_tpid_set(port_pi=%d, vlan_type=%d, tpid=%d) failed diag=%d\n",
- port_id, vlan_type, tp_id, diag);
+ "%s(port_pi=%d, vlan_type=%d, tpid=%d) failed diag=%d\n",
+ __func__, port_id, vlan_type, tp_id, diag);
}
void
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] app/testpmd: fix incorrect function names in logs
2025-12-01 10:08 [PATCH] app/testpmd: fix incorrect function names in logs Anurag Mandal
@ 2025-12-01 15:58 ` Patrick Robb
0 siblings, 0 replies; 2+ messages in thread
From: Patrick Robb @ 2025-12-01 15:58 UTC (permalink / raw)
To: Anurag Mandal; +Cc: dev, bruce.richardson, aman.deep.singh, stephen, stable
[-- Attachment #1: Type: text/plain, Size: 89 bytes --]
Recheck-request: iol-intel-Performance
Putting in a retest due to an infra fail at UNH.
[-- Attachment #2: Type: text/html, Size: 136 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-01 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-01 10:08 [PATCH] app/testpmd: fix incorrect function names in logs Anurag Mandal
2025-12-01 15:58 ` Patrick Robb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).