From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 044FF46F8D; Fri, 26 Sep 2025 22:51:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4EE24064A; Fri, 26 Sep 2025 22:51:34 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 414114064A for ; Fri, 26 Sep 2025 22:51:33 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-27eed7bdfeeso18183485ad.0 for ; Fri, 26 Sep 2025 13:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1758919892; x=1759524692; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qHFuHuYv16b3sHHSciA9XnoVjwWrP+IsBR0u7OCB5eU=; b=f/U4MaHg7ztF208Xe42ILvyMmSaLkTSr2nzWAwt7LKzV7hQZnZF1HARV/58XFzwzCW oyxwfC2BihnWAFzZRwlfB0mmvlCevlBrvsWZpmfPPR3phFeFcdAgnLtlPC+UkY/3koIT 8KNSo8kBEpVFt9nOfc1mrju6LydvY+na9xlsc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758919892; x=1759524692; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qHFuHuYv16b3sHHSciA9XnoVjwWrP+IsBR0u7OCB5eU=; b=G/YP4qgycG9G1qWOVIG9gw53hNzcyMo16IW57385SSVn95YqrUyyMpt8mmrvFgyV/5 Aw1nI/EK3LmOPk9wEKC8YhfwIPKBw39JiczOKmXwVCvQskJ/5Pb7M56r4vOAlUp8Xnmt E/4iCTPe8wW/YHKWefjemtuanIpkEPYAhUceOTGIoaSR7IGi6Ej6/IvT60vJ7vfCOdPb LkdEhHB96iAeIE2oUptdWg/aIsbukQjyGn698YCT4W+dbEVkyuIOUQGxyjUqJOMUaJ2O z75jvb2JvlUPVVtngv0W7SQawoG52pBIfJtOeddTGVNcsjpfGtouszr0OD9/j6MxHTha 6rYg== X-Forwarded-Encrypted: i=1; AJvYcCVwFylr62i+Q4bMHkOTuSZaFsLXkKVWZtuIJORSz53fE3qepl6PcM/hnEDfTRPDBx9/F7w=@dpdk.org X-Gm-Message-State: AOJu0YxpLsTxdPBNHPyg6f1D9X86txXACba3ohOYJ6QpS7zI6RMGshaW 1iPydydMGH+zNirJnb9heGXXNNxToSWQQRZR7vo6EvEbgZ2D164Cu5R4j5xybYNw80V6HdHAKzw 7yt7ZB6K2QUMNPasqTFen8m4pzgpIkHSJZo2UhJbesA== X-Gm-Gg: ASbGncvTtZwxbYyDJyuBMW6velqEtj4G5W3LJjFBcTJMo8mmvwl2FDoXdSneQ6PLp2x TO3O9hGq8NyBTCnnYxFkdviyUYqLSPGjcc+um2rSIoHpOOWxe2F3nSF2nCA2StCOqlyhZevzBaW Oqhm0cYqIMIFOYpkus60t/n2Fjl0wxqhQFzBgwMbNktBMi4L6m2lJ4yGFCcipdyJT1VliGRrFbw kRlFkt4tYTMqEkt83E122JSHQ1XheojRSWG4FFp X-Google-Smtp-Source: AGHT+IFtQ+Dzjc6hbqES/9GXIUwq4we2hvrkrWI6ZEbOjqY04/Aw5M8ivIwrrBhHXriizAZ2FqmZNl5qNqv9UZzolfQ= X-Received: by 2002:a17:902:f60b:b0:25d:d848:1cd1 with SMTP id d9443c01a7336-27ed6dff83bmr76834955ad.15.1758919892298; Fri, 26 Sep 2025 13:51:32 -0700 (PDT) MIME-Version: 1.0 References: <20250924161918.2211290-1-svaze@qti.qualcomm.com> In-Reply-To: From: Patrick Robb Date: Fri, 26 Sep 2025 16:51:08 -0400 X-Gm-Features: AS18NWCm9EgfcVkmnvn5ncOwl8ZwNIaVWp3QOgZ1K4Gb2Lp4kO8yK3OQ8QoLbso Message-ID: Subject: Re: [PATCH 1/3] compressdev: support for dictionaries and PDCP checksum To: Sameer Vaze Cc: Fan Zhang , Ashish Gupta , "dev@dpdk.org" Content-Type: multipart/alternative; boundary="0000000000005e829a063fba734a" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000005e829a063fba734a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Oh, and I never answered your initial question - yes the traffic generator issue is now sorted out. Thanks. On Fri, Sep 26, 2025 at 4:50=E2=80=AFPM Patrick Robb wr= ote: > Hi Sameer, > > Thanks for your patience and I apologize for not reaching out yesterday. > > Normally, if you want a retest you send an email on your patch requesting > one per the instructions here and it automatically gets picked up by the > Community Lab CI testing system: > https://core.dpdk.org/testing/#requesting-a-patch-retest > > In this case I will just trigger the retest directly since I'm the > Community Lab manager. The failure in question should be gone in approx 3= 0 > minutes. > > Have a good weekend. > > On Fri, Sep 26, 2025 at 12:15=E2=80=AFPM Sameer Vaze > wrote: > >> Hey Patrick, >> >> Were you able to fix the issue with the traffic generator? Is there >> documentation on what steps need to be done to request a rerun? >> >> Thanks >> Sameer Vaze >> ------------------------------ >> *From:* Patrick Robb >> *Sent:* Wednesday, September 24, 2025 2:24 PM >> *To:* Sameer Vaze >> *Cc:* Fan Zhang ; Ashish Gupta < >> ashishg@marvell.com>; dev@dpdk.org >> *Subject:* Re: [PATCH 1/3] compressdev: support for dictionaries and >> PDCP checksum >> >> >> *WARNING:* This email originated from outside of Qualcomm. Please be >> wary of any links or attachments, and do not enable macros. >> The CI testing failure for this series is due to an issue with >> the traffic generator that is unrelated to the patch. I will resolve it >> tomorrow and do a test rerun. >> >> On Wed, Sep 24, 2025 at 12:19=E2=80=AFPM Sameer Vaze >> wrote: >> >> Adds definitions for PDCP checksums and apis to pass in >> dictionaries >> >> Signed-off-by: Sameer Vaze >> --- >> lib/compressdev/rte_comp.h | 31 +++++++++++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h >> index 96d9b276dd..169d3d960e 100644 >> --- a/lib/compressdev/rte_comp.h >> +++ b/lib/compressdev/rte_comp.h >> @@ -101,6 +101,10 @@ enum rte_comp_op_status { >> * is not an error case. Output data up to op.produced can be >> used and >> * next op in the stream should continue on from op.consumed+1. >> */ >> + RTE_COMP_OP_STATUS_CHECK_SUM_VALIDATION_FAILED, >> + /**< Checksum validation failed. Either calculated does checksum >> not match >> + * the one provided or there was an error calculating the checks= um >> + */ >> }; >> >> /** Compression Algorithms */ >> @@ -166,6 +170,10 @@ enum rte_comp_checksum_type { >> /**< Generates a xxHash-32 checksum, as used by LZ4. >> * https://github.com/Cyan4973/xxHash/blob/dev/doc/xxhash_spec.m= d >> */ >> + RTE_COMP_CHECKSUM_3GPP_PDCP_UDC, >> + /**< Generates checksum as defined under Uplink Data Compression >> + * checksum as defined in the 3GPP PDCP specification >> + */ >> }; >> >> /** Compression Huffman Type - used by DEFLATE algorithm */ >> @@ -201,6 +209,11 @@ enum rte_comp_flush_flag { >> */ >> }; >> >> +#define DEFLATE_MAX_WINDOW_SIZE (1ULL << 15) >> + >> +#define DEFLATE_MIN_WINDOW_SIZE (1ULL << 8) >> + >> + >> /** Compression transform types */ >> enum rte_comp_xform_type { >> RTE_COMP_COMPRESS, >> @@ -305,6 +318,15 @@ struct rte_comp_compress_xform { >> /**< Hash algorithm to be used with compress operation. Hash is >> always >> * done on plaintext. >> */ >> + uint8_t *dictionary; >> + /**< >> + * Pointer to memory containing dictionary to be used for inflat= e >> + * and deflate operations >> + */ >> + uint16_t dictionary_len; >> + /**< >> + * Length of dictionary to be used >> + */ >> }; >> >> /** >> @@ -328,6 +350,15 @@ struct rte_comp_decompress_xform { >> /**< Hash algorithm to be used with decompress operation. Hash i= s >> always >> * done on plaintext. >> */ >> + uint8_t *dictionary; >> + /**< >> + * Pointer to memory containing dictionary to be used for inflat= e >> + * and deflate operations >> + */ >> + uint16_t dictionary_len; >> + /**< >> + * Length of dictionary to be used >> + */ >> }; >> >> /** >> -- >> 2.31.1 >> >> --0000000000005e829a063fba734a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Oh, and I never answered your initial question - yes the t= raffic generator issue is now sorted out. Thanks.

On F= ri, Sep 26, 2025 at 4:50=E2=80=AFPM Patrick Robb <probb@iol.unh.edu> wrote:
Hi Sameer,=C2=A0

=
Thanks for your patience and I apologize for not reaching out ye= sterday.=C2=A0

Normally, if you want a retest you = send an email on your patch requesting one per the instructions here and it= automatically gets picked up by the Community Lab CI testing system:=C2=A0= https://core.dpdk.org/testing/#requesting-a-patch-retest

In this case I will just trigger the retest directly= since I'm the Community Lab manager. The failure in question should be= gone in approx 30 minutes.=C2=A0

Have a good week= end.

On Fri, Sep 26, 2025 at 12:15=E2=80=AFPM Sameer Vaze <svaze@qti.qualcomm.com= > wrote:
=
Hey Patrick,

Were you able to fix the issue with the traffic generator? Is there documen= tation on what steps need to be done to request a rerun?

Thanks
Sameer Vaze
From: Patrick Robb <probb@iol.unh.edu>
Sent: Wednesday, September 24, 2025 2:24 PM
To: Sameer Vaze <svaze@qti.qualcomm.com>
Cc: Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashishg@marvell.com>; dev@dpdk.org <dev@dpdk.org>
Subject: Re: [PATCH 1/3] compressdev: support for dictionaries and P= DCP checksum
=C2=A0

WARNING:= This email originated from outside of Qualcomm. Please be wary of= any links or attachments, and do not enable macros.

The CI testing failure for this series is due to an issue = with the=C2=A0traffic generator that is unrelated to the patch. I will reso= lve it tomorrow and do a test rerun.

On Wed, Sep 24, 2025 at 12:19=E2=80=AFPM Sameer Vaze <<= a href=3D"mailto:svaze@qti.qualcomm.com" target=3D"_blank">svaze@qti.qualco= mm.com> wrote:
Adds definitions for PDCP checksums and apis to pass in
dictionaries

Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com>
---
=C2=A0lib/compressdev/rte_comp.h | 31 +++++++++++++++++++++++++++++++
=C2=A01 file changed, 31 insertions(+)

diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h
index 96d9b276dd..169d3d960e 100644
--- a/lib/compressdev/rte_comp.h
+++ b/lib/compressdev/rte_comp.h
@@ -101,6 +101,10 @@ enum rte_comp_op_status {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* is not an error case. Output data up to= op.produced can be used and
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* next op in the stream should continue o= n from op.consumed+1.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
+=C2=A0 =C2=A0 =C2=A0 =C2=A0RTE_COMP_OP_STATUS_CHECK_SUM_VALIDATION_FAILED,=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0/**< Checksum validation failed. Either calc= ulated does checksum not match
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * the one provided or there was an error calcu= lating the checksum
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 */
=C2=A0};

=C2=A0/** Compression Algorithms */
@@ -166,6 +170,10 @@ enum rte_comp_checksum_type {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /**< Generates a xxHash-32 checksum, as used= by LZ4.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* https://github.com/Cyan4973/xxHash/blob/dev/doc/xxhash_spec.md
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
+=C2=A0 =C2=A0 =C2=A0 =C2=A0RTE_COMP_CHECKSUM_3GPP_PDCP_UDC,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0/**< Generates checksum as defined under Upl= ink Data Compression
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * checksum as defined in the 3GPP PDCP specifi= cation
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 */
=C2=A0};

=C2=A0/** Compression Huffman Type - used by DEFLATE algorithm */
@@ -201,6 +209,11 @@ enum rte_comp_flush_flag {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
=C2=A0};

+#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 DEFLATE_MAX_WINDOW_SIZE (1ULL << = 15)
+
+#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 DEFLATE_MIN_WINDOW_SIZE=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(1ULL << 8)
+
+
=C2=A0/** Compression transform types */
=C2=A0enum rte_comp_xform_type {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 RTE_COMP_COMPRESS,
@@ -305,6 +318,15 @@ struct rte_comp_compress_xform {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /**< Hash algorithm to be used with compress= operation. Hash is always
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* done on plaintext.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
+=C2=A0 =C2=A0 =C2=A0 =C2=A0uint8_t *dictionary;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0/**<
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Pointer to memory containing dictionary to b= e used for inflate
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * and deflate operations
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 */
+=C2=A0 =C2=A0 =C2=A0 =C2=A0uint16_t dictionary_len;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0/**<
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Length of dictionary to be used
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 */
=C2=A0};

=C2=A0/**
@@ -328,6 +350,15 @@ struct rte_comp_decompress_xform {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /**< Hash algorithm to be used with decompre= ss operation. Hash is always
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* done on plaintext.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
+=C2=A0 =C2=A0 =C2=A0 =C2=A0uint8_t *dictionary;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0/**<
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Pointer to memory containing dictionary to b= e used for inflate
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * and deflate operations
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 */
+=C2=A0 =C2=A0 =C2=A0 =C2=A0uint16_t dictionary_len;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0/**<
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Length of dictionary to be used
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 */
=C2=A0};

=C2=A0/**
--
2.31.1

--0000000000005e829a063fba734a--