Re: [PATCH] dts: remove leftover Node methods

[Patrick Robb <probb@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 2458 bytes --]

This looks good, and I can confirm dts-check-format.sh is passing with this
patch.

Reviewed-by: Patrick Robb
Tested-by: Patrick Robb

On Tue, Nov 26, 2024 at 10:09 AM Luca Vizzarro <luca.vizzarro@arm.com>
wrote:

> The "remove redundant test suite" removed an unused test suite and some
> dead code with it. Some dead code which references now-removed symbols,
> remained though. This removes this code, therefore fixing the related
> mypy errors.
>
> Fixes: e3ab9dd5cd5d ("dts: remove redundant test suite")
>
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
> Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
> ---
>  dts/framework/testbed_model/node.py | 26 --------------------------
>  1 file changed, 26 deletions(-)
>
> diff --git a/dts/framework/testbed_model/node.py
> b/dts/framework/testbed_model/node.py
> index 85144f6f4e..c1844ecd5d 100644
> --- a/dts/framework/testbed_model/node.py
> +++ b/dts/framework/testbed_model/node.py
> @@ -14,8 +14,6 @@
>  """
>
>  from abc import ABC
> -from ipaddress import IPv4Interface, IPv6Interface
> -from typing import Union
>
>  from framework.config import (
>      OS,
> @@ -192,30 +190,6 @@ def _setup_hugepages(self) -> None:
>                  self.config.hugepages.force_first_numa,
>              )
>
> -    def configure_port_state(self, port: Port, enable: bool = True) ->
> None:
> -        """Enable/disable `port`.
> -
> -        Args:
> -            port: The port to enable/disable.
> -            enable: :data:`True` to enable, :data:`False` to disable.
> -        """
> -        self.main_session.configure_port_state(port, enable)
> -
> -    def configure_port_ip_address(
> -        self,
> -        address: Union[IPv4Interface, IPv6Interface],
> -        port: Port,
> -        delete: bool = False,
> -    ) -> None:
> -        """Add an IP address to `port` on this node.
> -
> -        Args:
> -            address: The IP address with mask in CIDR format. Can be
> either IPv4 or IPv6.
> -            port: The port to which to add the address.
> -            delete: If :data:`True`, will delete the address from the
> port instead of adding it.
> -        """
> -        self.main_session.configure_port_ip_address(address, port, delete)
> -
>      def close(self) -> None:
>          """Close all connections and free other resources."""
>          if self.main_session:
> --
> 2.43.0
>
>

[-- Attachment #2: Type: text/html, Size: 3267 bytes --]