From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C841D45DAF; Tue, 26 Nov 2024 23:18:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 635A1402A7; Tue, 26 Nov 2024 23:18:07 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 20EFD4026C for ; Tue, 26 Nov 2024 23:18:06 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2ed91d2a245so3267635a91.3 for ; Tue, 26 Nov 2024 14:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1732659485; x=1733264285; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Rn4UiqoVhO0KGCYkiVlJZdmE7eZ1tHJsicAuQBhvK0g=; b=ID8emz3kOCZxy8qvYUJvB3IycpcO8JF8AUmoRPWxXLxM5g5RZ4tiUkD+VR8lpHr+WY Qp7VULVmQMn1W9wYcrTjcYqGNQyWYcjHRZnIBl3Nh3lFVk7OmqWUlu6EwHYrcwB8EA5U wcdEoTep0pGfkq1IjavhJ/+YepBNlSTcBs0I0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732659485; x=1733264285; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rn4UiqoVhO0KGCYkiVlJZdmE7eZ1tHJsicAuQBhvK0g=; b=GXbu7v47lImTGjnuUVN1fmPjhDqxLsQdKKCaXpzWXv37GGT1KcpfcwqXZI6rj5OY/s tc1iFLG25S7yxduO+pQPJ8Ldqa2kA95rjkqWrelqMkOUKrZOYFv8ez7kaQMawySwSWLP uV6ic96eW6odEckswq0s8xkqhL7/4ddaccURt0DYZ6smgG1XRVYx8RytFCbaLoNng+aQ T77ek+l4Fbh4sZew7hP1qHarmW4q1noLw6D79yVeSJiurkVIo99eW+WLqrkX+eOidZ/t n0ZmjouuQDphNVeLaKYhVzDqy17Y5ZzKxX91uY8bWzjyudiEh03Dt9fNOCEwAuI9J0so HvvQ== X-Gm-Message-State: AOJu0Yw4tkWeml7Ee8C9+pCMwQgCDoDZIUnw6iG6V+HVJ72OjyaCWuPd D9uK6PJZM7rKOw1HZfdcPoo0nvFRJ5nrfHAq9bUrXasDZNs8ijOEEY7p3IhwVvaFyXzgnufFhKU 89G4lSROGlbjyV9kVESHxUx5hIISe712xBR8HtA5/CuMsWkWr X-Gm-Gg: ASbGncs6rsrXu1/C5foHV7FXhwBK1VaQemPj321uEJKKbRoiq6WS5PF2UZ3wlly87Xu i9IIkiMz/VRXVqCne7ci0HU/1KcAFs6j/MuO0N/aR9/VoygS3nahfusvzkbHd1axM X-Google-Smtp-Source: AGHT+IHw19ZPa3QEPtYGR1/a8v6vJivf3lU4reme0fwqA9YtMKYFJS9+HLM0iiEJxSkcHBrzJnvRC+Pv5Hfoo0MKi+E= X-Received: by 2002:a17:90b:1a92:b0:2ea:a13f:f814 with SMTP id 98e67ed59e1d1-2ee08e5cab8mr1129329a91.6.1732659485074; Tue, 26 Nov 2024 14:18:05 -0800 (PST) MIME-Version: 1.0 References: <20241126150929.2843601-1-luca.vizzarro@arm.com> In-Reply-To: <20241126150929.2843601-1-luca.vizzarro@arm.com> From: Patrick Robb Date: Tue, 26 Nov 2024 17:15:58 -0500 Message-ID: Subject: Re: [PATCH] dts: remove leftover Node methods To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek Content-Type: multipart/alternative; boundary="0000000000002006c70627d83946" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000002006c70627d83946 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This looks good, and I can confirm dts-check-format.sh is passing with this patch. Reviewed-by: Patrick Robb Tested-by: Patrick Robb On Tue, Nov 26, 2024 at 10:09=E2=80=AFAM Luca Vizzarro wrote: > The "remove redundant test suite" removed an unused test suite and some > dead code with it. Some dead code which references now-removed symbols, > remained though. This removes this code, therefore fixing the related > mypy errors. > > Fixes: e3ab9dd5cd5d ("dts: remove redundant test suite") > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > --- > dts/framework/testbed_model/node.py | 26 -------------------------- > 1 file changed, 26 deletions(-) > > diff --git a/dts/framework/testbed_model/node.py > b/dts/framework/testbed_model/node.py > index 85144f6f4e..c1844ecd5d 100644 > --- a/dts/framework/testbed_model/node.py > +++ b/dts/framework/testbed_model/node.py > @@ -14,8 +14,6 @@ > """ > > from abc import ABC > -from ipaddress import IPv4Interface, IPv6Interface > -from typing import Union > > from framework.config import ( > OS, > @@ -192,30 +190,6 @@ def _setup_hugepages(self) -> None: > self.config.hugepages.force_first_numa, > ) > > - def configure_port_state(self, port: Port, enable: bool =3D True) -> > None: > - """Enable/disable `port`. > - > - Args: > - port: The port to enable/disable. > - enable: :data:`True` to enable, :data:`False` to disable. > - """ > - self.main_session.configure_port_state(port, enable) > - > - def configure_port_ip_address( > - self, > - address: Union[IPv4Interface, IPv6Interface], > - port: Port, > - delete: bool =3D False, > - ) -> None: > - """Add an IP address to `port` on this node. > - > - Args: > - address: The IP address with mask in CIDR format. Can be > either IPv4 or IPv6. > - port: The port to which to add the address. > - delete: If :data:`True`, will delete the address from the > port instead of adding it. > - """ > - self.main_session.configure_port_ip_address(address, port, delet= e) > - > def close(self) -> None: > """Close all connections and free other resources.""" > if self.main_session: > -- > 2.43.0 > > --0000000000002006c70627d83946 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This looks good, and I can confirm dts-check-format.sh is = passing with this patch.

Reviewed-by: Patrick Robb
=
Tested-by: Patrick Robb

On Tue, Nov 26, 2024 at 10:09=E2=80=AFAM = Luca Vizzarro <luca.vizzarro@ar= m.com> wrote:
The "remove redundant test suite" removed an unused test sui= te and some
dead code with it. Some dead code which references now-removed symbols,
remained though. This removes this code, therefore fixing the related
mypy errors.

Fixes: e3ab9dd5cd5d ("dts: remove redundant test suite")

Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
---
=C2=A0dts/framework/testbed_model/node.py | 26 -------------------------- =C2=A01 file changed, 26 deletions(-)

diff --git a/dts/framework/testbed_model/node.py b/dts/framework/testbed_mo= del/node.py
index 85144f6f4e..c1844ecd5d 100644
--- a/dts/framework/testbed_model/node.py
+++ b/dts/framework/testbed_model/node.py
@@ -14,8 +14,6 @@
=C2=A0"""

=C2=A0from abc import ABC
-from ipaddress import IPv4Interface, IPv6Interface
-from typing import Union

=C2=A0from framework.config import (
=C2=A0 =C2=A0 =C2=A0OS,
@@ -192,30 +190,6 @@ def _setup_hugepages(self) -> None:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.config.h= ugepages.force_first_numa,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)

-=C2=A0 =C2=A0 def configure_port_state(self, port: Port, enable: bool =3D = True) -> None:
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 """Enable/disable `port`.
-
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 Args:
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 port: The port to enable/disable= .
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 enable: :data:`True` to enable, = :data:`False` to disable.
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.main_session.configure_port_state(port, e= nable)
-
-=C2=A0 =C2=A0 def configure_port_ip_address(
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 address: Union[IPv4Interface, IPv6Interface],<= br> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 port: Port,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 delete: bool =3D False,
-=C2=A0 =C2=A0 ) -> None:
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 """Add an IP address to `port` = on this node.
-
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 Args:
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 address: The IP address with mas= k in CIDR format. Can be either IPv4 or IPv6.
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 port: The port to which to add t= he address.
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 delete: If :data:`True`, will de= lete the address from the port instead of adding it.
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.main_session.configure_port_ip_address(ad= dress, port, delete)
-
=C2=A0 =C2=A0 =C2=A0def close(self) -> None:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""Close all connections a= nd free other resources."""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if self.main_session:
--
2.43.0

--0000000000002006c70627d83946--