On Tue, Oct 29, 2024 at 8:35 AM Luca Vizzarro wrote: > On 29/10/2024 01:23, Patrick Robb wrote: > > On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro > > wrote: > > > > > > + > > + DPDK Build Options: > > + Arguments in this group (and subgroup) will be applied to a > > DPDKLocation when the DPDK tree, tarball or revision will be > > provided, other arguments > > + like remote source and build dir are optional. A DPDKLocation > > from settings are used instead of from config if construct > successful. > > > > > > Maybe call this "DPDK Source Options?" To me, "DPDK Build Options" > > invokes meson options supported in DPDK. Up to you though. > > Reviewed-by: Patrick Robb > > > Perfectly understandable concern to be honest. But it's also somewhat > complicated, given this refers to the build whether it's uncompiled or > precompiled and the location of the sources. It may require some thought. > "DPDK Build Source" instead of "DPDK Build Options"? I don't know why but for some reason "Build Options" strongly translates to meson options in my mind. But if it's a headache I think we can drop it - everything is documented in any case so it shouldn't be a big deal.