From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 739EE45C0E; Tue, 29 Oct 2024 21:06:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C13D42EE8; Tue, 29 Oct 2024 21:06:27 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id A21C74060F for ; Tue, 29 Oct 2024 21:06:25 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2e2e88cb0bbso4523533a91.3 for ; Tue, 29 Oct 2024 13:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730232385; x=1730837185; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=20X7ThMuneUZ71Fg0DtHXTkOqQwY0S2ij/Qi04WEpbE=; b=adONZf9pagx7stroAP9DqVfvRorRlV/ExPxaisdNG82b4q3AGslPsaZHR4QNDz+3oU Wkq7LZDZIcU7s+BQoppaqWcrZ+KNDqd5V7VjMXdAapeF0OHydrsp+W9a7sPcIJn/UbZu ClK2zdOuve6nuKSI95P0gy2+IabcpIok7FtPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730232385; x=1730837185; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=20X7ThMuneUZ71Fg0DtHXTkOqQwY0S2ij/Qi04WEpbE=; b=ulRrOQvEvi2bc/yFecH3Gei9NMJsPEy8neE64KDJCee2hFmczD+lJEvpRbPPX5XAii UFZ4tBFFwsToN7nEuECxd4F7Z5B/VlUWRLAtkNH6PME78IJL8bqGqzCaifGs8MrJOtn5 DRP24ypE89XUejtCrn2ndYJQ+5SLvg6ZJSgcMUKLRsDCm+g9+fkRmI1tb+G3YqybGWbB l7gbsXuaCFhf3g7AKINJ26XLFWwWz2PRLhsDLqsbXWGItQD5sddIHyEzQ8j8kSXH/eH8 4eE9Kjhvfle/VPiqUv3PNtKg345fX05+/+56SW3LAHvF8KUY8fGzrZAFNIODGrE4Vii5 qOvw== X-Gm-Message-State: AOJu0YyEjoqVhqIdCuZaGS+fmq1wLZKnrncaUeir4xu1FKPH53d2B3/d 5ps8bHA+eCz+8keLvXOaCX8lWfcTaSGoAdZyz87Z7LAytRB0Ro0P4EDc73jxKfrY1oU3mRbA8XK Qh1/VLS+ljAfKDEBP3wqTmQyZ66akOqW+RP9axw== X-Google-Smtp-Source: AGHT+IHAIwjCoP7h6dAxJ/lKW9C8CPNi03hm4t8WbD0yvIn2fwbk3KGJy12g+LXcmX0tMvPbyxSGQxRe9lsD+rPE1/M= X-Received: by 2002:a17:90a:6d26:b0:2e2:bf7f:3363 with SMTP id 98e67ed59e1d1-2e8f104c90amr12856690a91.6.1730232384800; Tue, 29 Oct 2024 13:06:24 -0700 (PDT) MIME-Version: 1.0 References: <20240930160204.19582-1-tomas.durovec@pantheon.tech> <20241021134935.1210500-1-luca.vizzarro@arm.com> <20241021134935.1210500-7-luca.vizzarro@arm.com> In-Reply-To: From: Patrick Robb Date: Tue, 29 Oct 2024 16:04:44 -0400 Message-ID: Subject: Re: [PATCH v2 6/7] doc: update argument options for external DPDK build To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek , =?UTF-8?B?VG9tw6HFoSDEjnVyb3ZlYw==?= Content-Type: multipart/alternative; boundary="000000000000acea270625a31e2f" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000acea270625a31e2f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 29, 2024 at 8:35=E2=80=AFAM Luca Vizzarro wrote: > On 29/10/2024 01:23, Patrick Robb wrote: > > On Mon, Oct 21, 2024 at 9:50=E2=80=AFAM Luca Vizzarro > > wrote: > > > > > > + > > + DPDK Build Options: > > + Arguments in this group (and subgroup) will be applied to a > > DPDKLocation when the DPDK tree, tarball or revision will be > > provided, other arguments > > + like remote source and build dir are optional. A DPDKLocation > > from settings are used instead of from config if construct > successful. > > > > > > Maybe call this "DPDK Source Options?" To me, "DPDK Build Options" > > invokes meson options supported in DPDK. Up to you though. > > Reviewed-by: Patrick Robb = > > > Perfectly understandable concern to be honest. But it's also somewhat > complicated, given this refers to the build whether it's uncompiled or > precompiled and the location of the sources. It may require some thought. > "DPDK Build Source" instead of "DPDK Build Options"? I don't know why but for some reason "Build Options" strongly translates to meson options in my mind. But if it's a headache I think we can drop it - everything is documented in any case so it shouldn't be a big deal. --000000000000acea270625a31e2f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Oct 29, 2024 at 8:35=E2=80=AF= AM Luca Vizzarro <Luca.Vizzarro= @arm.com> wrote:
On 29/10/2024 01:23, Patrick Robb wrote:
> On Mon, Oct 21, 2024 at 9:50=E2=80=AFAM Luca Vizzarro <luca.vizzarro@arm.com > <mailto:= luca.vizzarro@arm.com>> wrote:
>
>
>=C2=A0 =C2=A0 =C2=A0+
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0DPDK Build Options:
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0Arguments in this group (and subgroup= ) will be applied to a
>=C2=A0 =C2=A0 =C2=A0DPDKLocation when the DPDK tree, tarball or revisio= n will be
>=C2=A0 =C2=A0 =C2=A0provided, other arguments
>=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0like remote source and build dir are = optional. A DPDKLocation
>=C2=A0 =C2=A0 =C2=A0from settings are used instead of from config if co= nstruct successful.
>
>
> Maybe call this "DPDK Source Options?" To me, "DPDK Bui= ld Options"
> invokes meson options supported in DPDK. Up to you though.
> Reviewed-by: Patrick Robb <probb@iol.unh.edu <mailto:probb@iol.unh.edu>>

Perfectly understandable concern to be honest. But it's also somewhat <= br> complicated, given this refers to the build whether it's uncompiled or =
precompiled and the location of the sources. It may require some thought.

"DPDK Build Source" instead of= "DPDK Build Options"?=C2=A0

I don't= know why but for some reason "Build Options" strongly translates= to meson options in my mind.=C2=A0

But if it'= s a headache I think we can drop it - everything is documented in any case = so it shouldn't be a big deal.
--000000000000acea270625a31e2f--