[PATCH v1 0/1] dts: add EAL sanity check suite

[PATCH v1 0/1] dts: add EAL sanity check suite

[Dean Marx]

Adds a test suite to DTS which the user can have as
a sanity check for their EAL configuration. This can
be used as a replacement for the hello_world suite.

Dean Marx (1):
  dts: add EAL sanity check suite

 dts/tests/TestSuite_eal.py | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 dts/tests/TestSuite_eal.py

-- 
2.44.0

[PATCH v1 1/1] dts: add EAL sanity check suite

[Dean Marx]

Add a test suite to replace hello_world which simply
starts and stops a testpmd session. The user can use
this as a sanity check to verify their configuration.

Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
---
 dts/tests/TestSuite_eal.py | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 dts/tests/TestSuite_eal.py

diff --git a/dts/tests/TestSuite_eal.py b/dts/tests/TestSuite_eal.py
new file mode 100644
index 0000000000..35660178f0
--- /dev/null
+++ b/dts/tests/TestSuite_eal.py
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 University of New Hampshire
+
+"""DPDK EAL sanity check suite.
+
+Starts and stops a testpmd session to verify EAL parameters
+are properly configured.
+"""
+
+from framework.remote_session.testpmd_shell import TestPmdShell
+from framework.test_suite import TestSuite, func_test
+
+
+class TestEal(TestSuite):
+    """EAL test suite. One test case, which starts and stops a testpmd session."""
+
+    @func_test
+    def test_verify_eal(self) -> None:
+        """EAL sanity test.
+
+        Steps:
+            Start testpmd session and check status.
+        Verify:
+            The testpmd session is alive after starting.
+        """
+        with TestPmdShell(node=self.sut_node) as testpmd:
+            testpmd.start()
+            self.verify(True, "True")
-- 
2.44.0

Re: [PATCH v1 1/1] dts: add EAL sanity check suite

[Paul Szczepanek]

On 09/12/2024 21:54, Dean Marx wrote:
> Add a test suite to replace hello_world which simply
> starts and stops a testpmd session. The user can use
> this as a sanity check to verify their configuration.
> 
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> ---
>  dts/tests/TestSuite_eal.py | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 dts/tests/TestSuite_eal.py
> 
> diff --git a/dts/tests/TestSuite_eal.py b/dts/tests/TestSuite_eal.py
> new file mode 100644
> index 0000000000..35660178f0
> --- /dev/null
> +++ b/dts/tests/TestSuite_eal.py
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2024 University of New Hampshire
> +
> +"""DPDK EAL sanity check suite.
> +
> +Starts and stops a testpmd session to verify EAL parameters
> +are properly configured.
> +"""
> +
> +from framework.remote_session.testpmd_shell import TestPmdShell
> +from framework.test_suite import TestSuite, func_test
> +
> +
> +class TestEal(TestSuite):
> +    """EAL test suite. One test case, which starts and stops a testpmd session."""
> +
> +    @func_test
> +    def test_verify_eal(self) -> None:
> +        """EAL sanity test.
> +
> +        Steps:
> +            Start testpmd session and check status.
> +        Verify:
> +            The testpmd session is alive after starting.
> +        """
> +        with TestPmdShell(node=self.sut_node) as testpmd:
> +            testpmd.start()
> +            self.verify(True, "True")

Not sure the self.verify(True, "True") is needed.

Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>

Re: [PATCH v1 1/1] dts: add EAL sanity check suite

[Stephen Hemminger]

On Fri, 20 Dec 2024 15:49:10 +0000
Paul Szczepanek <paul.szczepanek@arm.com> wrote:

> On 09/12/2024 21:54, Dean Marx wrote:
> > Add a test suite to replace hello_world which simply
> > starts and stops a testpmd session. The user can use
> > this as a sanity check to verify their configuration.
> > 
> > Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> > ---
> >  dts/tests/TestSuite_eal.py | 28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >  create mode 100644 dts/tests/TestSuite_eal.py
> > 
> > diff --git a/dts/tests/TestSuite_eal.py b/dts/tests/TestSuite_eal.py
> > new file mode 100644
> > index 0000000000..35660178f0
> > --- /dev/null
> > +++ b/dts/tests/TestSuite_eal.py
> > @@ -0,0 +1,28 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2024 University of New Hampshire
> > +
> > +"""DPDK EAL sanity check suite.

Do not use the term "sanity check".

https://inclusivenaming.org/word-lists/tier-2/sanity-check/

Re: [PATCH v2 1/1] dts: add EAL confidence check suite

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

Hey Dean,

I would retain the hello world name if I were you, in place of "eal" as you
use here. I don't want to give off the impression that we are testing EAL
in some intentional way, as opposed to providing a reference testsuite.

On Mon, Dec 23, 2024 at 12:56 PM Dean Marx <dmarx@iol.unh.edu> wrote:

> Add a test suite to replace hello_world which simply
> starts and stops a testpmd session. The user can use
> this as a confidence check to verify their configuration.
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
> ---
>  dts/tests/TestSuite_eal.py | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 dts/tests/TestSuite_eal.py
>
> diff --git a/dts/tests/TestSuite_eal.py b/dts/tests/TestSuite_eal.py
> new file mode 100644
> index 0000000000..7cf96e61cd
> --- /dev/null
> +++ b/dts/tests/TestSuite_eal.py
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2024 University of New Hampshire
> +
> +"""DPDK EAL confidence check suite.
> +
> +Starts and stops a testpmd session to verify EAL parameters
> +are properly configured.
> +"""
> +
> +from framework.remote_session.testpmd_shell import TestPmdShell
> +from framework.test_suite import TestSuite, func_test
> +
> +
> +class TestEal(TestSuite):
> +    """EAL test suite. One test case, which starts and stops a testpmd
> session."""
> +
> +    @func_test
> +    def test_verify_eal(self) -> None:
> +        """EAL confidence test.
> +
> +        Steps:
> +            Start testpmd session and check status.
> +        Verify:
> +            The testpmd session is alive after starting.
> +        """
> +        with TestPmdShell(node=self.sut_node) as testpmd:
> +            testpmd.start()
> --
> 2.44.0
>
>

[-- Attachment #2: Type: text/html, Size: 2554 bytes --]

[PATCH v2 1/1] dts: add EAL confidence check suite

[Dean Marx]

Add a test suite to replace hello_world which simply
starts and stops a testpmd session. The user can use
this as a confidence check to verify their configuration.

Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
---
 dts/tests/TestSuite_eal.py | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 dts/tests/TestSuite_eal.py

diff --git a/dts/tests/TestSuite_eal.py b/dts/tests/TestSuite_eal.py
new file mode 100644
index 0000000000..7cf96e61cd
--- /dev/null
+++ b/dts/tests/TestSuite_eal.py
@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 University of New Hampshire
+
+"""DPDK EAL confidence check suite.
+
+Starts and stops a testpmd session to verify EAL parameters
+are properly configured.
+"""
+
+from framework.remote_session.testpmd_shell import TestPmdShell
+from framework.test_suite import TestSuite, func_test
+
+
+class TestEal(TestSuite):
+    """EAL test suite. One test case, which starts and stops a testpmd session."""
+
+    @func_test
+    def test_verify_eal(self) -> None:
+        """EAL confidence test.
+
+        Steps:
+            Start testpmd session and check status.
+        Verify:
+            The testpmd session is alive after starting.
+        """
+        with TestPmdShell(node=self.sut_node) as testpmd:
+            testpmd.start()
-- 
2.44.0