From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51C2943094; Thu, 17 Aug 2023 20:30:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09C91410EE; Thu, 17 Aug 2023 20:30:25 +0200 (CEST) Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by mails.dpdk.org (Postfix) with ESMTP id 95DBB406A2 for ; Thu, 17 Aug 2023 20:30:23 +0200 (CEST) Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-56ca9a337caso108907eaf.1 for ; Thu, 17 Aug 2023 11:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1692297023; x=1692901823; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PDF5p0ncb/bvu49xrmSaQlFESk0tHsQMzC21g3VbTL0=; b=RgR8ha143FdM+YNuPeIZD9NeEeZdUDBdzWYi2SRaWcEGZd59/JmdRpSiC3nnXdEg67 7gDwDFXIGUz9Id7Xh0WGgexaMXgkm7HjtKwHeCvUVjrwR6O+YWBEhAYoGpMoTYQTTcTy UfDCaCWHvI4NXW6ADt+D/lIRe6sP5opZIz2qA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692297023; x=1692901823; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PDF5p0ncb/bvu49xrmSaQlFESk0tHsQMzC21g3VbTL0=; b=I2Blz5wI8GiudOU/INk1UxQowCEEpVPz6fHTF+hcOgp/P49Y0v9NbBl0ZZ+IhQaTQ0 HA1EjhTEA/VO0b4ggfIj72W/QRxmUIw5RvStI1hv/SgPT20u2wvRzgechiwMgJLTxB2Q Wjy3FDPtgVzpu/HNj81t+Wt/m4f11mAJQl9D3vwi2NItlqpoeBSRILL+uWNpLXTiLnY4 96GDNkosZ6CZdUPPIN3bkjzu+LOx1oSqDjFR1dEo/qC41Ii7A5ovr5hWX0j6y9v9WiYR B6rwriBpQnmoxC7p9vBUeSH6Kt3cmtptTJP8jODEpXmr12PScGRLjevbUOMECkO0JC97 ou9g== X-Gm-Message-State: AOJu0Yxfe2cVIFtpJ3T2rzEkOw/xA6S0wgR1Y1Xh7MRI1ht41qX53qxh r+NPFRt1qiC2QzHkI2nzdyGqX3NV/N9cxkyOFuLqQw== X-Google-Smtp-Source: AGHT+IHTLvjbaKYZDur7JFQ4MsRJeEVrLDAklgmrFGIjv08xU9EtKYdcJHrWdJ/JiJuN9F4BCOzTW348X2Pdr6Y/IuM= X-Received: by 2002:a4a:d1ce:0:b0:56c:7120:8363 with SMTP id a14-20020a4ad1ce000000b0056c71208363mr609990oos.5.1692297022946; Thu, 17 Aug 2023 11:30:22 -0700 (PDT) MIME-Version: 1.0 References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-5-bruce.richardson@intel.com> In-Reply-To: From: Patrick Robb Date: Thu, 17 Aug 2023 14:30:12 -0400 Message-ID: Subject: Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix To: David Marchand Cc: Bruce Richardson , dev@dpdk.org, ci@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Thomas Monjalon , Aaron Conole Content-Type: multipart/alternative; boundary="000000000000e856580603229a1e" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000e856580603229a1e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 17, 2023 at 3:28=E2=80=AFAM David Marchand wrote: > It is possible to list tests from meson. > Why not simply list the existing tests and filter the non working one? > > $ meson test -C --suite fast-tests --list > $ meson test -C --test-args ... > > That requires no change in DPDK. > > > Thanks. I am seeing now that this is possible. So, we could easily solve this problem using this approach. Thank you David. At the same time, I do like Bruce's new RFC patch for excluding tests with env variables. It is a bit cleaner on the testing experience side (I don't have to list 100 tests in the command) and it makes clear in the logs what is being skipped which typically would be run. Making that info visible could be valuable in some cases. Ultimately, we can proceed on the Community Lab side either way. I guess the maintainers must decide whether adding in the extra complexity to the test app is justified in this case. Also, Bruce, I do see that the symlink you used is working for the case where we have to (for now) directly use the dpdk-test app. I'm sorry I didn't have that info on hand this morning during the ci meeting. --000000000000e856580603229a1e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Thu, Aug 17, 2023 at 3:28=E2=80=AFAM D= avid Marchand <david.marcha= nd@redhat.com> wrote:
It is possible to list tests from meson.
Why not simply list the existing tests and filter the non working one?

$ meson test -C <build_dir> --suite fast-tests --list
$ meson test -C <build_dir> <explicit list> --test-args ...

That requires no change in DPDK.


Thanks. I am seeing now that this is possible. So, = we could easily solve this problem using this approach. Thank you David.=C2= =A0

At the same time, I do like Bruce's new RF= C patch for excluding tests with env variables. It is a bit cleaner on the = testing experience side (I don't have to list 100 tests in the command)= and it makes clear in the logs what is being skipped which typically would= be run. Making that info visible could be valuable in some cases.

Ultimately, we can proceed on the Community Lab side eithe= r way. I guess the maintainers must decide whether adding in the extra comp= lexity to the test app is justified in this case.=C2=A0=C2=A0
Also, Bruce, I do see that the symlink you used is working for = the case where we have to (for now) directly use the dpdk-test app. I'm= sorry I didn't have that info on hand this morning during the ci meeti= ng.=C2=A0

--000000000000e856580603229a1e--