From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vincent.mc.li@gmail.com>
Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com
 [209.85.217.179]) by dpdk.org (Postfix) with ESMTP id 19B052BD3
 for <dev@dpdk.org>; Fri, 11 Mar 2016 22:14:11 +0100 (CET)
Received: by mail-lb0-f179.google.com with SMTP id bc4so171848015lbc.2
 for <dev@dpdk.org>; Fri, 11 Mar 2016 13:14:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:date:message-id:subject:from:to;
 bh=1PNz5EfAfPHbthZt3NMfz6XnBxzi2o5j9fzAc3i0nck=;
 b=OFuEdsgAHdk8De9wCKyTffGAgKZLJMywDzNwHj9JhB5ftQDX6H3cJlAl8PdpUtKZI/
 HBiMfPJ0Ye1QQne4zmlT+xRrFtp9gyEP6ztwVC7x+ub1FdyKV1suTMu8x5SSwIucQssF
 00Jd+3FF+i88thZPJ4rhrHzAN7aNWPSCxbBdkqI46TAcD7+vrRBhRN/cEFhR86TKpH/s
 bxppG9O2GuKgKx5Oi5ejafL1YIWkgKUsgVvyvUzWp6u6IEpJWQvr7YhTr4tpuOFE/H3K
 YmgecGn6ExtQWDMk9XNlL9qWa0M/XBSYWXG0jS9BUMz9lpcCwNcJ0Ge5cRaXIiUu3TYA
 JzgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:date:message-id:subject:from:to;
 bh=1PNz5EfAfPHbthZt3NMfz6XnBxzi2o5j9fzAc3i0nck=;
 b=TZk65kBdVO78FlMfDNLZYDCEExj301OSP0xOOI2OpT/bhsBxIpsu78zgK34baI3hjr
 HdLRBwKzS61asKhkTzQ8a/dEyJ/J9nFWAbVcFq7DH0g2HgRaPIiH0Fzf4Szw6Y+MaYKm
 UNOMF6xQfBnqodjPj0K5FwsoPegPNqTSc/jsjAIQJ9nUwRXTT8QUWFEmeWaIw9HoZ7nX
 4KuOudL7lBh6pZrl4F25vnDbTSXB2zcE+0dYt2TVS4O3he7dPtcFKH2QwjsFZUY9PrzP
 MYqBuBKgAWFGLDx8jX+PLxSt5f1gcAgT2fcGtvrudDKBZ6swI01l96mIApy+3n0ISiXe
 C3Hw==
X-Gm-Message-State: AD7BkJJ7WnrKAgQu3iZ3KrAzPURZjl8fgIF/MctpyBZvXKmeWm4JIaT8QWJozZmmGpfHaFPTtZQhS8qtIUMmeQ==
MIME-Version: 1.0
X-Received: by 10.25.33.140 with SMTP id h134mr4098189lfh.159.1457730850701;
 Fri, 11 Mar 2016 13:14:10 -0800 (PST)
Received: by 10.25.150.78 with HTTP; Fri, 11 Mar 2016 13:14:10 -0800 (PST)
Date: Fri, 11 Mar 2016 13:14:10 -0800
Message-ID: <CAK3+h2wT1BvF78fkwAV8wc6ee0S682a5bJYJboYTpFbyn0dpdg@mail.gmail.com>
From: Vincent Li <vincent.mc.li@gmail.com>
To: dev@dpdk.org
Content-Type: text/plain; charset=UTF-8
Subject: [dpdk-dev] vmxnet3: add mac_addr_add function ?
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2016 21:14:11 -0000

Hi,

I have a DPDK app running in ESXi guest with vmxnet3 adapter, but
packet seems to be dropped, the debug output has following line which
I am not sure if it is the cause of the packet drop:

rte_eth_dev_config_restore: port 0: MAC address array not supported


               /* add address to the hardware */
                if  (*dev->dev_ops->mac_addr_add &&
                        (dev->data->mac_pool_sel[i] & (1ULL << pool)))
                        (*dev->dev_ops->mac_addr_add)(dev, &addr, i, pool);
                else {
                        RTE_PMD_DEBUG_TRACE("port %d: MAC address
array not supported\n",
                                        port_id);
                        /* exit the loop but not return an error */
                        break;
                }

vmxnet3 has not implemented mac_addr_add, any idea how to implement it
in drivers/net/vmxnet3/vmxnet3_ethdev.c ?

I looked at the igb mac_addr_add implementation, not sure how to adapt
the about the function parameter "index" and "pool" for vmxnet3.

also looked at the recent implementation of vmxnet3 mac_addr_set,
still not clear about the detail on how to handle "index" and "pool"
in mac_addr_add proto type.

Thanks!

Vincent