From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 8C6A2E72 for ; Mon, 6 Jul 2015 17:57:43 +0200 (CEST) Received: by wgqq4 with SMTP id q4so144516822wgq.1 for ; Mon, 06 Jul 2015 08:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3YxClb2tWrbYW6iqLa/OiBCujk1xGUdX4P+Ciy3VLKE=; b=ql52bRSIJy8Y0lckUPHi8cWyavTESN/KCQH80lhau/YXHOnbDpzBCq3hJ4tuJm2bBx 0rHdNtsao67Sfc2lbSNGLHcofX31td6yXAvUL3lFOIrxFG476JZI9jT19ZIsDPE2++hT oVUAIdbDb/euSEuEaD5/lNvfZvkfvhIoqm2orKKvXXIi8SjWf8DVgwIxCUvBaTccLb5B 2XVCrJGOn3UdZG73UXr1iEdJcl+BJcRJKYYmYRk99FdsSz2Sbos6OfhhVbFZLOYbHqNE iLFeG2QvffcC8N6Yejm/LqHpMfxZzk3hEfV7whJ5mJW5jrrcLBM3l3m26SvX6ZKRs20I uNQA== MIME-Version: 1.0 X-Received: by 10.194.79.98 with SMTP id i2mr33398909wjx.111.1436198263415; Mon, 06 Jul 2015 08:57:43 -0700 (PDT) Received: by 10.194.36.99 with HTTP; Mon, 6 Jul 2015 08:57:43 -0700 (PDT) In-Reply-To: <3865893.mD3C20oiXL@xps13> References: <1436189297-7780-1-git-send-email-dlrmsghd@gmail.com> <3865893.mD3C20oiXL@xps13> Date: Tue, 7 Jul 2015 00:57:43 +0900 Message-ID: From: Keunhong Lee To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/2] Native uio-based PMD for Mellanox ConnectX-3 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2015 15:57:43 -0000 Answer 1. UIO based driver is faster then ib based driver. It can saturate 40G link with MTU sized packets using a single thread while ib wrapper cannot. Answer 2. Sorry, I missed that. I'll make a new patch email with my real name. Question 1. Is it OK if I separate GPL-based and BSD-based codes into separated patches? mlx4 kernel driver itself is dual licenses, so I think they are considered as BSD in my source code. The only source code under GPL is bitmap, integer logarithm, and red-black tree contained in mlnx_uio/kernel directory. Keunhong. 2015-07-06 23:17 GMT+09:00 Thomas Monjalon : > 2015-07-06 22:28, leeopop: > > This is a native UIO-based PMD for Mellanox ConnectX-3 devices. > > It uses a persistent memory library in order to provide a persistent > > scartch area for the mlx4 HCA driver. > > What is the benefit of this UIO approach compared to the OFED based driver? > > > We release the driver itself under BSD license, but to use it for > > commercial products, you may have to re-implement the separated GPL > sources. > > The GPL sources are not really separated. > The DPDK libraries must be BSD-licensed. > > > The GPL affected source codes reside in the mlnx_uio/kernel directory. > > It seems that a large part of the GPL driver was also copied in > mlnx_uio/mlnx/. > > Given that you are dropping a huge GPL codebase (whose you don't own the > copyright) > in a BSD library, and that you didn't give your real name in the > signed-off line, > it is NACK. >