From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by dpdk.org (Postfix) with ESMTP id 5E0091BBE for ; Tue, 7 Mar 2017 15:29:54 +0100 (CET) Received: by mail-oi0-f43.google.com with SMTP id m124so2408394oig.1 for ; Tue, 07 Mar 2017 06:29:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1kpa02Q1c0uEpS7DLIAYGqXgT8pGV6rA40d2HTPMCrY=; b=r0MABPRFOPMo9YKeNFdgiDGb50WW7l/G1p7iOB3hG5S3ylDdtRcPKMs4SmqaLUC8UB s6tLnOACb2kv45U8Ba7IIGyoWvv3T8vNMUAzpJBeRTQiO6eo5UMTTFePFHFs1qtrS2gK FsZlTC9X8Pq85DzDxO18fKzlHJ/4FImqj5+Q/G+zdxTlGpVpCJaj5f6gh8TGmgwtqfi1 iMjRPOUEfsyEFJQ2fuFMMkO38HWfgnIXa7Q3RctzbbODSfWN3nZggPOJCd4VQIWnnwLW QV5wOZ0cfnUpUPRn/plAaGsdVrO7pkiiaOr/NdKnEQZH8DDB/KhsU98cPTXPMHHTigbp gBUw== X-Gm-Message-State: AMke39mVpUhieeezMa1Zw2pmrr07v7OpnyWfzpEYzkzH5rMw1J9oZ05bj0hSf6wggYc7VSWKLvtpR9ekCzVqBZAB X-Received: by 10.202.68.132 with SMTP id r126mr312425oia.32.1488896993501; Tue, 07 Mar 2017 06:29:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.198.1 with HTTP; Tue, 7 Mar 2017 06:29:53 -0800 (PST) In-Reply-To: <2417966.3G0haXHz4n@xps13> References: <20170123211340.22570-1-bmcfall@redhat.com> <20170127183800.27466-1-bmcfall@redhat.com> <20170127183800.27466-2-bmcfall@redhat.com> <2417966.3G0haXHz4n@xps13> From: Billy McFall Date: Tue, 7 Mar 2017 09:29:53 -0500 Message-ID: To: Thomas Monjalon Cc: wenzhuo.lu@intel.com, olivier.matz@6wind.com, dev@dpdk.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 14:29:54 -0000 Thomas, Thanks for your comments. See inline. On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon wrote: > 2017-01-27 13:37, Billy McFall: > > --- a/doc/guides/nics/features/default.ini > > +++ b/doc/guides/nics/features/default.ini > > @@ -55,6 +55,7 @@ FW version = > > EEPROM dump = > > Registers dump = > > Multiprocess aware = > > +Free TX ring buffers = > > I'm afraid this wording will be confusing, because every drivers > free their buffers :) > What about "Free Tx mbuf on demand" ? > > I definitely like your wording of the feature better than mine. All the existing features were under 20 characters and I was trying to stay under that. > And please, move this line upper, just after "Rx interrupt". > > Done > We also need to carefully review the doc you provided (thanks). > First quick comment, please wrap lines shorter in the doc. > > Done > About the function prototype, I've seen a double space :) > Done > I think you could use rte_errno (while keeping negative return codes). > I can do that if you want, but if I understand your comment, it will make the implementation of the function not as clean. I cannot use the existing RTE_ETH_VALID_PORTID_OR_ERR_RET(..) and RTE_FUNC_PTR_OR_ERR_RET(..) MACROs because they are handling the return on error. Or am I missing something?