From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f170.google.com (mail-io0-f170.google.com [209.85.223.170]) by dpdk.org (Postfix) with ESMTP id ED4072BF5 for ; Mon, 21 Mar 2016 10:24:36 +0100 (CET) Received: by mail-io0-f170.google.com with SMTP id 124so50785546iov.3 for ; Mon, 21 Mar 2016 02:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=wpDTAkKHN55i89+Fpca4CSlth1ComVYSVGbpavbbJk8=; b=dJXpfki3hFFZKHJwbz0xO8SvtOUXTiSEiAP6OI9MT5BFqlJK7AUsa89++I7Ex6yS3r GIvaEHJVq6hWIuf0d8UbvuUwlzTYnqHcMRjKv4dUqF+oGwvIMKVnnJc3BcQi4cqfYSA9 Q1RbcxJR1CA9ajfbGqdPWE0uGGPc7b225rZz0XqUVb/y63HsdVfrL5VZvpvQ1+JAzYbZ Afw3OhSNHp26KU88sW1oo3yOscfyBD5rm7FtqgP56C74RZCCg6QW2KRveuOLROIM8/rs FyIY3SK3UkwzaoBJE5ND0xO3JCu+eZLa/8C/jYQeCDkESNyqFFy6Y7oMzXEut2t9fNnK BIyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=wpDTAkKHN55i89+Fpca4CSlth1ComVYSVGbpavbbJk8=; b=myi8QxTGDgBQnNTqlcX6elyT+nJKkMYOpRuUaTX43aLzljRGjfj9lYNsulmi6mPSo8 kL1mk06pAMndG5+2xYZRnIJ9j5qNCPIza5Mzz0SLVFiZ2hjGRmpJgI3CVdcaYkcGBMbv 67y5GjUVGLL6tb4gjcUk9CWCPyyIcQtKMCNZc6pjvDaxBCR5FpADLJy95B4uxD/FkCkP JXofRbClWy+nlzNBai/78l9y4Q3LebmlGfcm+MEPTFRDSKbaaj3CU0DJPnOEVYgRJPQB qy/mM1kW5OIGQk7kqB23WW5ukAJK53//8qCYT1SslxP4roMv/5X3dbarrI4yWoBmD5O4 6LOw== X-Gm-Message-State: AD7BkJKpog0tBZTgvfbyJJ5zzne8NVoF7iix/P9IYV2fXHXdCxJyENpfi9iYcoMwx/Edb9wmbcCZ7CXKBusDVQ== MIME-Version: 1.0 X-Received: by 10.107.169.105 with SMTP id s102mr1068383ioe.19.1458552276453; Mon, 21 Mar 2016 02:24:36 -0700 (PDT) Received: by 10.64.227.107 with HTTP; Mon, 21 Mar 2016 02:24:36 -0700 (PDT) In-Reply-To: <1523315.o3rXJh0SOG@xps13> References: <1458539108-15686-1-git-send-email-mukawa@igel.co.jp> <1458539108-15686-2-git-send-email-mukawa@igel.co.jp> <1523315.o3rXJh0SOG@xps13> Date: Mon, 21 Mar 2016 18:24:36 +0900 Message-ID: From: Tetsuya Mukawa To: Thomas Monjalon , "Richardson, Bruce" Cc: "dev@dpdk.org" , Zhuangyanying Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v13 1/2] ethdev: Add a new event type to notify a queue state changed event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 09:24:37 -0000 2016-03-21 17:37 GMT+09:00 Thomas Monjalon : > 2016-03-21 14:45, Tetsuya Mukawa: >> This event will be occured when some queues are enabled or disabled. >> So far, only vhost PMD supports the event, and it indicates some queues >> are enabled or disabled by virtio-net device. Such an event is needed >> because virtio-net device may not enable all queues vhost PMD prepare. >> >> Because only vhost PMD uses the event so far, it isn't an actual hardware >> interrupt but a simple software event. > [...] >> >> + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, >> + /**< queue state changed interrupt */ > > Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough? > > What about this comment? > /**< queue state event (enabled/disabled) */ Hi Thomas, Yes, it's enough, and above comment is nice. Thanks for suggestion. Hi Bruce, If today is the deadline, could you kindly please replace above changes while merging? I need half a day to re-submit the patch. Sorry for asking it. I will ask my company to let me have vpn access. ;) Regards, Tetsuya