From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mukawa@igel.co.jp>
Received: from mail-ie0-f171.google.com (mail-ie0-f171.google.com
 [209.85.223.171]) by dpdk.org (Postfix) with ESMTP id D5F75376E
 for <dev@dpdk.org>; Thu, 26 Feb 2015 12:50:15 +0100 (CET)
Received: by iecat20 with SMTP id at20so13719252iec.12
 for <dev@dpdk.org>; Thu, 26 Feb 2015 03:50:15 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=lZlTj/Dr5W8epFu3dQcc5PRE2OzyqPH2r8Jgbr4xP+s=;
 b=VipoCrouCLDk3iR2pOonk++33GMpnGcdooeMUFw0d5QrZfjYHsiERfe4kHvgJOoBIf
 B7G4BjoRTQZU+qXnCulwzentDPat63OLAJEAL2Sck2UMgS9M+R9UBIKCqH7iWh2kMeDb
 YOgW1C/nqPSH+YW3VQEWSlFXufZAyc+xNCB/l/SaCIKCn+SGAFobW52sotf4+Li+ipbR
 oJtxoZ1JN98ucn0HPj4I69Ye01Suak/qR97JEFSdXB55ygX0JVznERYToC/48eCLeH7b
 duG5tYz+14yirf2Nj5oYCQcuSR1UjdxEy7yoOnfuWW9ODoaFWDCTNilatuOLBhXFRt+S
 XeKA==
X-Gm-Message-State: ALoCoQlat0IghUka6H3Gb7VnE4hv++CEbTUtZRStzcfa11P+I6hbfwIkNtrHXky/1oDmG+2fl+qB
MIME-Version: 1.0
X-Received: by 10.107.130.25 with SMTP id e25mr10964993iod.49.1424951415170;
 Thu, 26 Feb 2015 03:50:15 -0800 (PST)
Received: by 10.64.15.5 with HTTP; Thu, 26 Feb 2015 03:50:15 -0800 (PST)
In-Reply-To: <2176123.7naUroNpz4@xps13>
References: <1424414516-18609-1-git-send-email-mukawa@igel.co.jp>
 <3153139.jQ5sXg5pox@xps13>
 <CAKU8wkcwLqHnHSx3qREXVcQJZQJpZ0rWtDu7We=kGM9iG4zjSA@mail.gmail.com>
 <2176123.7naUroNpz4@xps13>
Date: Thu, 26 Feb 2015 20:50:15 +0900
Message-ID: <CAKU8wkeN8Sf+Oj+2+2kCAG1un9m=CUCGZKfZSWOZS+At5F6Sbw@mail.gmail.com>
From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port
	hotplug function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Feb 2015 11:50:16 -0000

2015-02-26 19:57 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> 2015-02-26 18:06, Tetsuya Mukawa:
>> 2015-02-26 16:03 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
>> > 2015-02-25 16:49, Stephen Hemminger:
>> >> Build fails if HOTPLUG is disabled
>>
>> Hi Stephen,
>>
>> I appreciate for you reporting.
>>
>> >
>> > OK thanks for reporting.
>> > Actually there is no good reason to disable hotplug on Linux.
>> > Though it means that it's impossible to build on FreeBSD.
>> >
>> > Tetsuya, the right fix is to remove this option.
>>
>> Hi Thomas,
>>
>> Yes, I agree with it. I will add some codes to remove the option.
>> Please let me have a few days, I need to prepare BSD machine for compile test.
>>
>> > You should manage to graceful degrades hotplug in not supported
>> > cases supported: devices cannot be detachable in case of VFIO or nic_uio.
>> > What about uio_pci_generic?
>>
>> We cannot detach a vfio device so far. But we can detach a igb_uio and
>> uio_pci_generic device.
>> About a vfio ddevice, I haven't checked related code yet, but I guess
>> I will submit code to detach a vfio device in post-rc1.
>
> OK thanks.
> I made a quick fix (moving #ifdef) waiting the option removal:
>         http://dpdk.org/browse/dpdk/commit/?id=7609e6609350
>

Thank you so much for that.

Tetsuya,