From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f182.google.com (mail-ig0-f182.google.com [209.85.213.182]) by dpdk.org (Postfix) with ESMTP id 9514A590B for ; Fri, 18 Mar 2016 14:41:36 +0100 (CET) Received: by mail-ig0-f182.google.com with SMTP id av4so39023669igc.1 for ; Fri, 18 Mar 2016 06:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=uSdkt+D4tgnon4CM1Wpi+O5WLiZ9TsEENqEkdANDfwk=; b=oNIr3aL4McU8D2Yw7QlhllUFfNxgR68MpSiUKIu6/lYlt7aUsCdcUw8KDOPAVvdpCu 4/eGQPsWR0faafWF2VY8A2Pnb7YCcXi0kN0Mln03G6VlBUbjatxNm0ti/pLs/9TW7TBd Gj4qRrmd0PvfKfJUofmTnJzV3zEDgZhOYloLrjfC3FiD8+qflLl1GKh3rdRjy2K3yqdo GqO9Tj8y0EbdBiYMrKzt9FNQoKQjvsSdv6ABk3mPxWwbv0iBnT9UDa2VMXgdMEIHuhMr mIVZaZzg/oPoAIgD7CBXppMsLswq3GJdhBNWNjADUgu9UN4Ka04SbQ/h/x0wy2pCzxFM Ahpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=uSdkt+D4tgnon4CM1Wpi+O5WLiZ9TsEENqEkdANDfwk=; b=MfdrFFmEv9lkSEwZNtlFNaOMUiLrwjQIzyS+KE5CUAp+KkuoGrx5Kkj8BtlB5vZ8Ec w7rilRsU04IEBSvvzXU6rzYceq09eJ88xSaziqTW/9r1lNwnyL2T3p6UM6fRj6Y34crI 66APV421B8iDcx5lmVJx0S/HV1a7GtfpCXTMPxqfuzPd+Vu/ZTmWztbZo3+VXHG+xVRq 9CxhdOMXY8iHq2xVJXPfAzueM+w1a9Nud7tPxpYYs3Q/xvFHA7fAxOL61QBlZWPMp8n7 7q3TjL1dpxBthpZPhXdbbIvhO2bpOG3PvoK5YieIj8xJdAfD7uQp2lAe+NQyqZGhLAMu rlJw== X-Gm-Message-State: AD7BkJI2Q5GudH8BRIiL4Sh1uTMkuM2hD+l61mhMO2XjAEiPxWjo5Nr0SgdBJHdel8Xaa+UdLk0bbVgUGLpkYA== MIME-Version: 1.0 X-Received: by 10.50.30.134 with SMTP id s6mr40956134igh.36.1458308496004; Fri, 18 Mar 2016 06:41:36 -0700 (PDT) Received: by 10.64.227.107 with HTTP; Fri, 18 Mar 2016 06:41:35 -0700 (PDT) Received: by 10.64.227.107 with HTTP; Fri, 18 Mar 2016 06:41:35 -0700 (PDT) In-Reply-To: <20160318122702.GA12932@bricha3-MOBL3> References: <1457316434-19128-3-git-send-email-mukawa@igel.co.jp> <1458030701-11487-3-git-send-email-mukawa@igel.co.jp> <20160318122702.GA12932@bricha3-MOBL3> Date: Fri, 18 Mar 2016 22:41:35 +0900 Message-ID: From: Tetsuya Mukawa To: Bruce Richardson Cc: dev@dpdk.org, Zhuangyanying Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v12 2/2] vhost: Add VHOST PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 13:41:36 -0000 2016/03/18 =E5=8D=88=E5=BE=8C9:27 "Bruce Richardson" : > > On Tue, Mar 15, 2016 at 05:31:41PM +0900, Tetsuya Mukawa wrote: > > The patch introduces a new PMD. This PMD is implemented as thin wrapper > > of librte_vhost. It means librte_vhost is also needed to compile the PMD. > > The vhost messages will be handled only when a port is started. So star= t > > a port first, then invoke QEMU. > > > > The PMD has 2 parameters. > > - iface: The parameter is used to specify a path to connect to a > > virtio-net device. > > - queues: The parameter is used to specify the number of the queues > > virtio-net device has. > > (Default: 1) > > > > Here is an example. > > $ ./testpmd -c f -n 4 --vdev 'eth_vhost0,iface=3D/tmp/sock0,queues=3D1'= -- -i > > > > To connect above testpmd, here is qemu command example. > > > > $ qemu-system-x86_64 \ > > > > -chardev socket,id=3Dchr0,path=3D/tmp/sock0 \ > > -netdev vhost-user,id=3Dnet0,chardev=3Dchr0,vhostforce,queues= =3D1 \ > > -device virtio-net-pci,netdev=3Dnet0,mq=3Don > > > > Signed-off-by: Tetsuya Mukawa > > Acked-by: Ferruh Yigit > > Acked-by: Yuanhan Liu > > Acked-by: Rich Lane > > Tested-by: Rich Lane > > Hi Tetsuya, > > I hope to get this set merged for RC2 very soon. Can you provide an update for > the nic overview.rst doc listing out the features of this new PMD. If you want, > you can provide it as a separate patch, that I will merge into this one for you > on apply to next-net. > > If you do decide to respin this patchset with the extra doc, please take into > account the following patchwork issues also - otherwise I'll also fix them on > apply: > > WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const > #364: FILE: drivers/net/vhost/rte_eth_vhost.c:56: > +static const char *valid_arguments[] =3D { > > WARNING:LINE_SPACING: Missing a blank line after declarations > #399: FILE: drivers/net/vhost/rte_eth_vhost.c:91: > + char *iface_name; > + volatile uint16_t once; > > WARNING:TYPO_SPELLING: 'Unknow' may be misspelled - perhaps 'Unknown'? > #684: FILE: drivers/net/vhost/rte_eth_vhost.c:376: > + RTE_LOG(ERR, PMD, "Unknow numa node\n"); > > Regards, > /Bruce > Hi Bruce, I've sent the v12 patch with vhost.rst. Could you please check below? http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=3D64 Is this the documentation I need to add? Anyway, it contains above nits. So could you please fix it before merging, if it's the documentation? Regards, Tetsuya