From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by dpdk.org (Postfix) with ESMTP id 0BDB92C0B for ; Mon, 21 Mar 2016 14:51:54 +0100 (CET) Received: by mail-ig0-f171.google.com with SMTP id av4so84282624igc.1 for ; Mon, 21 Mar 2016 06:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=Q91IveUCMqznnTd2ixnLP9uwEnnqJ1oe6ZRg1Foq6eQ=; b=IQnvL4xj54tsDILIA445M5amhW5F3mUNVTHy3P4Htew7DizWyDQIeO5Yj2Jjx27mku 4Mu6Wkz8HmtO/gx3LLL9T5oQJtA91XmuZwjAEyDt0xy5GqXAKsJ9lrG2FA0hi2mb1xQR GAAphjcm8VKzKdhYTjZvBp5+Lm4eA6NGGrYZP3WFNjiiX0tBDniFmi+CHM3MPhVygAfi hUCMhGuBWep6wCOHNwh2hLVzTahkjn/V9lqOlTXj2jybhl5tfXaA3VHWHLb/FCt8aw9J fi62uPU6fmWNb94ubD70jn9MWyOHX1cfvdaZZ48XagelnTW61QUY03gW633JCnhcI4bS b9DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Q91IveUCMqznnTd2ixnLP9uwEnnqJ1oe6ZRg1Foq6eQ=; b=Pg201hFFoxcxuUYp+K8bQKnDnGeiJjCq0n+9pHw8WeuuhMV1I+lyHFMh/6bWWs1Z3l bJBPVX3XJoymuz6w3MCOYHK/MwSZfRp2xfeaGXw32Z9zvwDYo/mc2Yfo2auu00maRVMx tBhiMKA4rCSl7iNz21FoHiCzscP/yinOtRvIcRNF+4wM2+wt/icDjNhVAGNvbgAHqr8O /uD1pK+EqVC3eGnKYoVHU5FKbNemKC4yVelJBMglimnnEYAwp4Xj5UxFXoPnX44cs49u G8jxM7dqW/vJ/X3WlBfQSgg8hNXiTcm2rX2Ktab1d9E6ICatR0tc3aD/sDrvAye3XIEa sjHg== X-Gm-Message-State: AD7BkJJvipyMpUsqzdAJr0D+VJg0uflAqI7riYv75DJJ0Kd4KYlki2s2csNEKywjX+UyX6pWfMPpgkKGRfLYbA== MIME-Version: 1.0 X-Received: by 10.50.80.74 with SMTP id p10mr13096046igx.46.1458568313444; Mon, 21 Mar 2016 06:51:53 -0700 (PDT) Received: by 10.64.227.107 with HTTP; Mon, 21 Mar 2016 06:51:53 -0700 (PDT) In-Reply-To: <20160321110514.GA11312@bricha3-MOBL3> References: <1458539108-15686-1-git-send-email-mukawa@igel.co.jp> <1458539108-15686-2-git-send-email-mukawa@igel.co.jp> <1523315.o3rXJh0SOG@xps13> <20160321110514.GA11312@bricha3-MOBL3> Date: Mon, 21 Mar 2016 22:51:53 +0900 Message-ID: From: Tetsuya Mukawa To: Bruce Richardson Cc: Thomas Monjalon , "dev@dpdk.org" , Zhuangyanying Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v13 1/2] ethdev: Add a new event type to notify a queue state changed event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 13:51:54 -0000 2016-03-21 20:05 GMT+09:00 Bruce Richardson : > On Mon, Mar 21, 2016 at 06:24:36PM +0900, Tetsuya Mukawa wrote: >> 2016-03-21 17:37 GMT+09:00 Thomas Monjalon : >> > 2016-03-21 14:45, Tetsuya Mukawa: >> >> This event will be occured when some queues are enabled or disabled. >> >> So far, only vhost PMD supports the event, and it indicates some queues >> >> are enabled or disabled by virtio-net device. Such an event is needed >> >> because virtio-net device may not enable all queues vhost PMD prepare. >> >> >> >> Because only vhost PMD uses the event so far, it isn't an actual hardware >> >> interrupt but a simple software event. >> > [...] >> >> >> >> + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, >> >> + /**< queue state changed interrupt */ >> > >> > Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough? >> > >> > What about this comment? >> > /**< queue state event (enabled/disabled) */ >> >> Hi Thomas, >> >> Yes, it's enough, and above comment is nice. >> Thanks for suggestion. >> >> >> Hi Bruce, >> >> If today is the deadline, could you kindly please replace above >> changes while merging? >> I need half a day to re-submit the patch. Sorry for asking it. >> I will ask my company to let me have vpn access. ;) >> >> Regards, >> Tetsuya > > Yes, I can fix on apply to dpdk-next-net. > > /Bruce I appreciate your helping. Regards, Tetsuya