From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0074E460E8; Wed, 22 Jan 2025 18:45:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 990C54060B; Wed, 22 Jan 2025 18:45:45 +0100 (CET) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by mails.dpdk.org (Postfix) with ESMTP id 8669D4060A for ; Wed, 22 Jan 2025 18:45:44 +0100 (CET) Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-303548a9332so4141171fa.1 for ; Wed, 22 Jan 2025 09:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1737567944; x=1738172744; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gG2XcpAM869BOF2k9/XUZEPJXsesAEAfIeG+9K085jo=; b=H4eF2P7hV2E7iDeZaWA2SAwcLJDhyFohcjCQ4EzKFGL3aiSY2eHaCHbu9CnDYMzUtv qyw1jaZCLKxH0gRntJG2kuhdHVSdQqAlDwyEhYEbpoMNqOLfosDThhuP09/p15fcmLGV bXn1tAvYwh3Mn1MJVUub4KdU35VQtSIUT0804= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737567944; x=1738172744; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gG2XcpAM869BOF2k9/XUZEPJXsesAEAfIeG+9K085jo=; b=cKXrvDpV22b6Rp8/krz3N62L+wtsOMVq1OHbtV+8XP39t8s4c05Bg6yn1TgRLOsHs7 q4UNvOQQl9eKjz+oy/51MqpDDhSrzkdJzEzXpnlEsL9bU4y9LQBvahinT7AZ90xWfAFY f12derY+wRqmNqOgnY5mMPEP0RsIgSVtX0O1Y4nWbqXOLCLtKF90pqtmd8Nh7zKXH8Et YgYawYqaj9v+URWo6ynwK5qxO11exJf28Bw1Y52WtxWwS2TK1233Cze5e2sDjk/0EXBK IfNJCiVcx244jyQvHVnhAilGc2gJBWgWHynYYF6pWAYE12DEu7KmHJNH8h/WTSbadJ2h atHQ== X-Gm-Message-State: AOJu0YxinETtHglo5i6tY7HgnVAIV7B+Rpj1DJekrzDcdcB9dDg/YMny 4zSY2eUfZz6gfvtYJB0SVpJX/WUbZVrA97qJ5dl9vn6CftDRajono+cPDnKSwX7o+Rq8ggU46ku q2OOU4DH9TryKxgBCdPlJw7rtz2XoU3j2vLOguQ== X-Gm-Gg: ASbGnctLj6Sq7aYOm765C9IFSEel7OZ9C/Pye2GlTbW+m9dK0CUaKBRasTIi8eTP1wC /u7Dn3b3IDfD6FyVYRrSG+PdJya0F/w7fCTRE67wbmiBHTNFGypJsg5IwSAGvG034eEgfjVqQ7x gD9Z9c66uFrg== X-Google-Smtp-Source: AGHT+IFgjc06Hc4ClCFumCyP3ayCMD3UPYkmThhHZOJ/UWEvlfv8RHG1J0YGddH2s2OWHfDyO4779afzFrp76FI/q7c= X-Received: by 2002:a2e:a985:0:b0:302:251a:bd20 with SMTP id 38308e7fff4ca-3072ca5b536mr27375741fa.1.1737567943734; Wed, 22 Jan 2025 09:45:43 -0800 (PST) MIME-Version: 1.0 References: <20240705171341.23894-2-npratte@iol.unh.edu> <20250115141809.3898708-1-luca.vizzarro@arm.com> <20250115141809.3898708-3-luca.vizzarro@arm.com> In-Reply-To: <20250115141809.3898708-3-luca.vizzarro@arm.com> From: Nicholas Pratte Date: Wed, 22 Jan 2025 12:45:32 -0500 X-Gm-Features: AbW1kvZL4sRxogiABHRgnIcosIwfUP5bijXvDCwDYsgqc8bRMg553HZuiBTtaIY Message-ID: Subject: Re: [PATCH v3 2/7] dts: simplify build options config To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek , Patrick Robb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Reviewed-by: Nicholas Pratte On Wed, Jan 15, 2025 at 9:19=E2=80=AFAM Luca Vizzarro wrote: > > From: Nicholas Pratte > > The build options configuration contained redundant fields that were not > in use, and there is no future scope for their use. > > Bugzilla ID: 1360 > > Signed-off-by: Nicholas Pratte > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > --- > dts/conf.yaml | 3 -- > dts/framework/config/__init__.py | 43 -------------------- > dts/framework/test_result.py | 2 +- > dts/framework/testbed_model/cpu.py | 20 ++++++++- > dts/framework/testbed_model/node.py | 2 +- > dts/framework/testbed_model/os_session.py | 4 +- > dts/framework/testbed_model/posix_session.py | 2 +- > dts/framework/testbed_model/sut_node.py | 6 ++- > 8 files changed, 28 insertions(+), 54 deletions(-) > > diff --git a/dts/conf.yaml b/dts/conf.yaml > index 80aba0d63a..4b6965b3d7 100644 > --- a/dts/conf.yaml > +++ b/dts/conf.yaml > @@ -14,9 +14,6 @@ test_runs: > > # precompiled_build_dir: Commented out because `build_options` is = defined. > build_options: > - arch: x86_64 > - os: linux > - cpu: native > # the combination of the following two makes CC=3D"ccache gcc" > compiler: gcc > compiler_wrapper: ccache # Optional. > diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__in= it__.py > index 1127c6474a..3fa8f4fa8f 100644 > --- a/dts/framework/config/__init__.py > +++ b/dts/framework/config/__init__.py > @@ -63,22 +63,6 @@ class FrozenModel(BaseModel): > model_config =3D ConfigDict(frozen=3DTrue, extra=3D"forbid") > > > -@unique > -class Architecture(StrEnum): > - r"""The supported architectures of :class:`~framework.testbed_model.= node.Node`\s.""" > - > - #: > - i686 =3D auto() > - #: > - x86_64 =3D auto() > - #: > - x86_32 =3D auto() > - #: > - arm64 =3D auto() > - #: > - ppc64le =3D auto() > - > - > @unique > class OS(StrEnum): > r"""The supported operating systems of :class:`~framework.testbed_mo= del.node.Node`\s.""" > @@ -91,22 +75,6 @@ class OS(StrEnum): > windows =3D auto() > > > -@unique > -class CPUType(StrEnum): > - r"""The supported CPUs of :class:`~framework.testbed_model.node.Node= `\s.""" > - > - #: > - native =3D auto() > - #: > - armv8a =3D auto() > - #: > - dpaa2 =3D auto() > - #: > - thunderx =3D auto() > - #: > - xgene1 =3D auto() > - > - > @unique > class Compiler(StrEnum): > r"""The supported compilers of :class:`~framework.testbed_model.node= .Node`\s.""" > @@ -351,23 +319,12 @@ class DPDKBuildOptionsConfiguration(FrozenModel): > The build options used for building DPDK. > """ > > - #: The target architecture to build for. > - arch: Architecture > - #: The target OS to build for. > - os: OS > - #: The target CPU to build for. > - cpu: CPUType > #: The compiler executable to use. > compiler: Compiler > #: This string will be put in front of the compiler when executing t= he build. Useful for adding > #: wrapper commands, such as ``ccache``. > compiler_wrapper: str =3D "" > > - @cached_property > - def name(self) -> str: > - """The name of the compiler.""" > - return f"{self.arch}-{self.os}-{self.cpu}-{self.compiler}" > - > > class DPDKUncompiledBuildConfiguration(BaseDPDKBuildConfiguration): > """DPDK uncompiled build configuration.""" > diff --git a/dts/framework/test_result.py b/dts/framework/test_result.py > index ba7c1c9804..381f72b974 100644 > --- a/dts/framework/test_result.py > +++ b/dts/framework/test_result.py > @@ -337,7 +337,7 @@ class DTSResult(BaseResult): > """Stores environment information and test results from a DTS run. > > * Test run level information, such as testbed, the test suite li= st and > - DPDK build configuration (compiler, target OS and cpu), > + DPDK build compiler configuration, > * Test suite and test case results, > * All errors that are caught and recorded during DTS execution. > > diff --git a/dts/framework/testbed_model/cpu.py b/dts/framework/testbed_m= odel/cpu.py > index 46bf13960d..d19fa5d597 100644 > --- a/dts/framework/testbed_model/cpu.py > +++ b/dts/framework/testbed_model/cpu.py > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2023 PANTHEON.tech s.r.o. > +# Copyright(c) 2025 Arm Limited > > """CPU core representation and filtering. > > @@ -21,8 +22,25 @@ > from abc import ABC, abstractmethod > from collections.abc import Iterable, ValuesView > from dataclasses import dataclass > +from enum import auto, unique > > -from framework.utils import expand_range > +from framework.utils import StrEnum, expand_range > + > + > +@unique > +class Architecture(StrEnum): > + r"""The supported architectures of :class:`~framework.testbed_model.= node.Node`\s.""" > + > + #: > + i686 =3D auto() > + #: > + x86_64 =3D auto() > + #: > + x86_32 =3D auto() > + #: > + aarch64 =3D auto() > + #: > + ppc64le =3D auto() > > > @dataclass(slots=3DTrue, frozen=3DTrue) > diff --git a/dts/framework/testbed_model/node.py b/dts/framework/testbed_= model/node.py > index c56872aa99..08328ee482 100644 > --- a/dts/framework/testbed_model/node.py > +++ b/dts/framework/testbed_model/node.py > @@ -17,7 +17,6 @@ > > from framework.config import ( > OS, > - Architecture, > DPDKBuildConfiguration, > NodeConfiguration, > TestRunConfiguration, > @@ -26,6 +25,7 @@ > from framework.logger import DTSLogger, get_dts_logger > > from .cpu import ( > + Architecture, > LogicalCore, > LogicalCoreCount, > LogicalCoreList, > diff --git a/dts/framework/testbed_model/os_session.py b/dts/framework/te= stbed_model/os_session.py > index 30d781c355..fcda9b3de1 100644 > --- a/dts/framework/testbed_model/os_session.py > +++ b/dts/framework/testbed_model/os_session.py > @@ -28,7 +28,7 @@ > from dataclasses import dataclass > from pathlib import Path, PurePath, PurePosixPath > > -from framework.config import Architecture, NodeConfiguration > +from framework.config import NodeConfiguration > from framework.logger import DTSLogger > from framework.remote_session import ( > InteractiveRemoteSession, > @@ -40,7 +40,7 @@ > from framework.settings import SETTINGS > from framework.utils import MesonArgs, TarCompressionFormat > > -from .cpu import LogicalCore > +from .cpu import Architecture, LogicalCore > from .port import Port > > > diff --git a/dts/framework/testbed_model/posix_session.py b/dts/framework= /testbed_model/posix_session.py > index 220618cacc..981600e24c 100644 > --- a/dts/framework/testbed_model/posix_session.py > +++ b/dts/framework/testbed_model/posix_session.py > @@ -15,7 +15,6 @@ > from collections.abc import Iterable > from pathlib import Path, PurePath, PurePosixPath > > -from framework.config import Architecture > from framework.exception import DPDKBuildError, RemoteCommandExecutionEr= ror > from framework.settings import SETTINGS > from framework.utils import ( > @@ -26,6 +25,7 @@ > extract_tarball, > ) > > +from .cpu import Architecture > from .os_session import OSSession, OSSessionInfo > > > diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/test= bed_model/sut_node.py > index a9dc0a474a..11d4b22089 100644 > --- a/dts/framework/testbed_model/sut_node.py > +++ b/dts/framework/testbed_model/sut_node.py > @@ -400,7 +400,7 @@ def _configure_dpdk_build(self, dpdk_build_config: DP= DKBuildOptionsConfiguration > dpdk_build_config: A DPDK build configuration to test. > """ > self._env_vars =3D {} > - self._env_vars.update(self.main_session.get_dpdk_build_env_vars(= dpdk_build_config.arch)) > + self._env_vars.update(self.main_session.get_dpdk_build_env_vars(= self.arch)) > if compiler_wrapper :=3D dpdk_build_config.compiler_wrapper: > self._env_vars["CC"] =3D f"'{compiler_wrapper} {dpdk_build_c= onfig.compiler.name}'" > else: > @@ -410,8 +410,10 @@ def _configure_dpdk_build(self, dpdk_build_config: D= PDKBuildOptionsConfiguration > dpdk_build_config.compiler.name > ) > > + build_dir_name =3D f"{self.arch}-{self.config.os}-{dpdk_build_co= nfig.compiler}" > + > self._remote_dpdk_build_dir =3D self.main_session.join_remote_pa= th( > - self._remote_dpdk_tree_path, dpdk_build_config.name > + self._remote_dpdk_tree_path, build_dir_name > ) > > def _build_dpdk(self) -> None: > -- > 2.43.0 >