From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D75E345972; Thu, 12 Sep 2024 22:31:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6691F4028F; Thu, 12 Sep 2024 22:31:51 +0200 (CEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id 0675640269 for ; Thu, 12 Sep 2024 22:31:49 +0200 (CEST) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-53568285c1aso179891e87.3 for ; Thu, 12 Sep 2024 13:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1726173109; x=1726777909; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EAHVNLV4t99+mVEv8A0Sbhp6kx/vjUPkClAcvBQf5MU=; b=c8fuwVH5NND/HlGfUgHlsAufDh6gS4qo7wz7i4pEHiOU9QpPCdMXIsLhyFzUKA7xtZ 7L+9IFjjECKDVQLLdDrdPsmQv7+koK1ycGuBXwhPplksegfL/nTblw+Ftwf9AoQTIRGl FoK8yncQF/KFr2TwNJdn2cctEDpFlTr1c5qp8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726173109; x=1726777909; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EAHVNLV4t99+mVEv8A0Sbhp6kx/vjUPkClAcvBQf5MU=; b=J4A/gDwvNk8K9rQcghMs0YGqSDyGscMzGHFBk+HgUf8I7SfQXdtq2WpxjAXSl3eef5 zpe0sTE0LVsm6QWuc7D2Lkbdhc9E+JGGsizYk6q9LPs3guBqIkp6c6gBsQWOJJdraZaX /KTqMXTY3vL4Hq+TjXH8JkO//E/J6quvpkfnZwsbVR76E2ojhpKDb9Lz6aeENPNQDV4b RI97zNyWcDdvsrSH745b5x4i5aH3KgzsFcgPKWH3e3vWPwi+djW+ExSp+m6YunAy1cn4 meYHi+sf/y5RxtalEyVrogkAqdCa0TMMUqogGv8rl+5GcHhmFehDoDIodEA7PzIeljyH kxbg== X-Forwarded-Encrypted: i=1; AJvYcCVGR6897t/P0Q+8pWJ8JDjOFZqiCGPHpqC5N4cPDQpa1E1Z/x0k/CAUU/AIVYsaa2r3aj4=@dpdk.org X-Gm-Message-State: AOJu0Yw0RvR6BdUFKY4ZsqMwMCNlYF690GxLJA7suupvDKF6LHbzErNn 9MKrnTS2A9ptFWzNqUjPZo5uneZG1rUS/WXdSaX9N5gUZ2CYL6Wf/UeVoZTP26vYEcu6fajYQxQ FGb4H9Vzojx1WcKg3+DISsF9JNg/CeZZtq7n17A== X-Google-Smtp-Source: AGHT+IEuJEI0UkqP7nx+Kyi6uxSy36VXOqm6RGQsNaVtBs73nAc19V5dkJkQl9chkX8ZahUL9WFNd/heOO0yio1x9to= X-Received: by 2002:a05:651c:b0e:b0:2ee:e196:1486 with SMTP id 38308e7fff4ca-2f787dcdeb1mr6484941fa.4.1726173109056; Thu, 12 Sep 2024 13:31:49 -0700 (PDT) MIME-Version: 1.0 References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240705171341.23894-4-npratte@iol.unh.edu> In-Reply-To: From: Nicholas Pratte Date: Thu, 12 Sep 2024 16:31:37 -0400 Message-ID: Subject: Re: [PATCH v2 1/6] dts: Remove build target config and list of devices To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: probb@iol.unh.edu, dmarx@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 10, 2024 at 7:30=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > The subject line should be all lowercase (except for abbreviations and > maybe some other exceptions). Ack. > > On 5. 7. 2024 19:13, Nicholas Pratte wrote: > > Remove the list of devices from the schema, as these are unuesed. > > Typo: unused Thanks for pointing this out! > > > Likewise, removed build-target information since these is not currently > > used, and it is unlikely to be used in the future. Adjustments to the > > dts.rst are made to reflect these changes. > > > diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__= init__.py > > > @@ -341,28 +325,20 @@ class BuildTargetConfiguration: > > The configuration used for building DPDK. > > > > Attributes: > > - arch: The target architecture to build for. > > - os: The target os to build for. > > - cpu: The target CPU to build for. > > compiler: The compiler executable to use. > > compiler_wrapper: This string will be put in front of the com= piler when > > executing the build. Useful for adding wrapper commands, = such as ``ccache``. > > name: The name of the compiler. > > """ > > > > - arch: Architecture > > - os: OS > > - cpu: CPUType > > compiler: Compiler > > compiler_wrapper: str > > - name: str > > > > @classmethod > > def from_dict(cls, d: BuildTargetConfigDict) -> Self: > > r"""A convenience method that processes the inputs before cre= ating an instance. > > > > - `arch`, `os`, `cpu` and `compiler` are converted to :class:`En= um`\s and > > - `name` is constructed from `arch`, `os`, `cpu` and `compiler`. > > + `compiler` is converted to :class:`Enum`\s > > > > Args: > > d: The configuration dictionary. > > @@ -371,12 +347,8 @@ def from_dict(cls, d: BuildTargetConfigDict) -> Se= lf: > > The build target configuration instance. > > """ > > return cls( > > - arch=3DArchitecture(d["arch"]), > > - os=3DOS(d["os"]), > > - cpu=3DCPUType(d["cpu"]), > > compiler=3DCompiler(d["compiler"]), > > compiler_wrapper=3Dd.get("compiler_wrapper", ""), > > - name=3Df"{d['arch']}-{d['os']}-{d['cpu']}-{d['compiler']}"= , > > I think we can still keep this, we can just remove arch, os and cpu > (there could be multiple build target, each with different compiler > (gcc, clang, etc.)). If there's a reason to remove this, it should be > mentioned in the commit message. I can do that. If I had a justification for removing this way back when I wrote this, it wasn't strong enough for me to remember. I don't mind leaving this in. > > > ) > > > > > > diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework= /config/conf_yaml_schema.json > > index f02a310bb5..3f7bc2acae 100644 > > --- a/dts/framework/config/conf_yaml_schema.json > > +++ b/dts/framework/config/conf_yaml_schema.json > > @@ -6,76 +6,6 @@ > > > "ARCH": { > > "type": "string", > > "enum": [ > > @@ -124,12 +54,6 @@ > > "other" > > ] > > }, > > - "os": { > > - "$ref": "#/definitions/OS" > > - }, > > - "cpu": { > > - "$ref": "#/definitions/cpu" > > - }, > > Should we also remove arch that's above these two? Must have missed that! There's no reason for that to be there now that it's being removed. > > > > diff --git a/dts/framework/runner.py b/dts/framework/runner.py > > index 6b6f6a05f5..2a1019899a 100644 > > --- a/dts/framework/runner.py > > +++ b/dts/framework/runner.py > > @@ -480,7 +480,7 @@ def _run_build_target( > > test_suites_with_cases: The test suites with test cases t= o run. > > """ > > self._logger.set_stage(DtsStage.build_target_setup) > > - self._logger.info(f"Running build target '{build_target_config= .name}'.") > > + self._logger.info("Running build target.") > > If we keep build_target_config.name this should be reverted. Ack. > > > > > try: > > sut_node.set_up_build_target(build_target_config) > > > diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/te= stbed_model/sut_node.py > > index 2855fe0276..a4511157b7 100644 > > --- a/dts/framework/testbed_model/sut_node.py > > +++ b/dts/framework/testbed_model/sut_node.py > > @@ -115,12 +115,7 @@ def remote_dpdk_build_dir(self) -> PurePath: > > This is the directory where DPDK was built. > > We assume it was built in a subdirectory of the extracted tar= ball. > > """ > > - if self._build_target_config: > > - return self.main_session.join_remote_path( > > - self._remote_dpdk_dir, self._build_target_config.name > > - ) > > - else: > > - return self.main_session.join_remote_path(self._remote_dpd= k_dir, "build") > > + return self.main_session.join_remote_path(self._remote_dpdk_di= r, "build") > > > > Same here, revert if we keep build_target_config.name. Ack.