DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nicholas Pratte <npratte@iol.unh.edu>
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, Paul Szczepanek <paul.szczepanek@arm.com>,
	Patrick Robb <probb@iol.unh.edu>
Subject: Re: [PATCH v2 2/2] dts: add blocklist test suite
Date: Thu, 7 Nov 2024 15:33:54 -0500	[thread overview]
Message-ID: <CAKXZ7egjk2z0CEKTrWOoDGJ+fAwvLLT7eS13UcvVjZ55eAzNfA@mail.gmail.com> (raw)
In-Reply-To: <20241107135654.4121761-3-luca.vizzarro@arm.com>

Hi Luca, nice work!

See my small comment below/ I ran some local tests and everything
seems to be working fine, so other than that minor fix I pointed out,
the rest should be all set!

<snip>
> +"""The DPDK device blocklisting test suite.
> +
> +This testing suite ensures tests the port blocklisting functionality of testpmd.

I would remove the 'tests' and just write 'testing suite ensures the port...'

> +"""
> +
<snip>

  reply	other threads:[~2024-11-07 20:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 12:36 [PATCH 0/2] " Luca Vizzarro
2024-06-25 12:36 ` [PATCH 1/2] dts: add blocked ports to EalParams Luca Vizzarro
2024-09-09 19:17   ` Dean Marx
2024-09-11  0:13   ` Patrick Robb
2024-06-25 12:36 ` [PATCH 2/2] dts: add blocklist test suite Luca Vizzarro
2024-09-09 19:16   ` Dean Marx
2024-09-11  0:12   ` Patrick Robb
2024-11-07 13:56 ` [PATCH v2 0/2] " Luca Vizzarro
2024-11-07 13:56   ` [PATCH v2 1/2] dts: add blocked ports to EalParams Luca Vizzarro
2024-11-07 19:04     ` Nicholas Pratte
2024-11-08 14:36       ` Luca Vizzarro
2024-11-07 13:56   ` [PATCH v2 2/2] dts: add blocklist test suite Luca Vizzarro
2024-11-07 20:33     ` Nicholas Pratte [this message]
2024-11-08 14:38       ` Luca Vizzarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKXZ7egjk2z0CEKTrWOoDGJ+fAwvLLT7eS13UcvVjZ55eAzNfA@mail.gmail.com \
    --to=npratte@iol.unh.edu \
    --cc=dev@dpdk.org \
    --cc=luca.vizzarro@arm.com \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).