From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2014A45CA4; Thu, 7 Nov 2024 21:34:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC3AF42EBF; Thu, 7 Nov 2024 21:34:09 +0100 (CET) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mails.dpdk.org (Postfix) with ESMTP id E6801402F2 for ; Thu, 7 Nov 2024 21:34:07 +0100 (CET) Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-53b13eae3b3so174516e87.3 for ; Thu, 07 Nov 2024 12:34:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1731011647; x=1731616447; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Y7OdMh7Ux/kVWSkI53zXL/dgKCiz+zlQmFYfQrOb5tA=; b=iZ71b75hVWHPVfDobe54no7W0ebWJys3NSgLSS19fUn9XRXE8izeL6udn4jp2gsf6B QgK+bCfZbNDcTICHx2PGnXfRJingRvwRUnfgHAWI7Lbtvig2k1/qOphFmr/rjPg7REis A65J0t5JZ0CFYPplBCQC5PRqLTYvWqd8Q/2Cs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731011647; x=1731616447; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y7OdMh7Ux/kVWSkI53zXL/dgKCiz+zlQmFYfQrOb5tA=; b=aSwQBBhllkKJDQdWo1kelSJcX0LuYfcnAWM9y1JOcnzEpJXe3nLyIkWZ6hM2ea9y5V LRaCqJLA3V5fR29eEUSWXvjULlbyP/79dr0Ns2GCNRj94YoI8CedFl2fW9oZLksxa08g as7oX9ySMhNAw13QAR8fEU0Uw3EwfOr0IVHZ9v0aehOOmUHggoaJjNaPWQ2d9OxJ8ZJs z0Zt1EXCIy4Zwh0qvtnMEBozhb/pJkyAFtKrIiU5RwSQ0WScfd8rF5W4OwkXVnGu+M/Q ykQI0f+RtkcpW6g6CcFUcEQjynrfufAlaoDKWn/7m46Y0vJSj3AOpCYGrb8UThGj5flR bbFA== X-Gm-Message-State: AOJu0Yw+32rNHsJxx5xX9QUupDFBxcXRgUl46yDoiRsD21BYplyN37AF dvrc6PoVuYd+GjSTHliP/m2knFUeNz2mfy83FL+v7y1Apt/neQDYyAsSBcDyucKcXFJdicWeQh7 UCnsNIBfD3igwv2igNWCjdUK8s8l41cbv+lAfSA== X-Google-Smtp-Source: AGHT+IEoN1dCA+j+TYGe0BbYB2mxYrm+7Ivfy7FgpDFUOqKY5EIzznGWF8yIe3MzuJNnes/uyOKuxDFj593SBe/tWKg= X-Received: by 2002:a05:651c:b20:b0:2fb:51e0:911 with SMTP id 38308e7fff4ca-2ff20163c89mr446931fa.2.1731011647226; Thu, 07 Nov 2024 12:34:07 -0800 (PST) MIME-Version: 1.0 References: <20240625123611.1474204-1-luca.vizzarro@arm.com> <20241107135654.4121761-1-luca.vizzarro@arm.com> <20241107135654.4121761-3-luca.vizzarro@arm.com> In-Reply-To: <20241107135654.4121761-3-luca.vizzarro@arm.com> From: Nicholas Pratte Date: Thu, 7 Nov 2024 15:33:54 -0500 Message-ID: Subject: Re: [PATCH v2 2/2] dts: add blocklist test suite To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek , Patrick Robb Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Luca, nice work! See my small comment below/ I ran some local tests and everything seems to be working fine, so other than that minor fix I pointed out, the rest should be all set! > +"""The DPDK device blocklisting test suite. > + > +This testing suite ensures tests the port blocklisting functionality of testpmd. I would remove the 'tests' and just write 'testing suite ensures the port...' > +""" > +