From: Nicholas Pratte <npratte@iol.unh.edu>
To: Dean Marx <dmarx@iol.unh.edu>
Cc: probb@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com,
yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
paul.szczepanek@arm.com, juraj.linkes@pantheon.tech,
dev@dpdk.org
Subject: Re: [PATCH v1] dts: correct typos in conf.yaml
Date: Tue, 13 Aug 2024 14:20:45 -0400 [thread overview]
Message-ID: <CAKXZ7egnoFHp6VkmXJpMZ-9eCp=VsV4BBQcTrxghhr4uh9SrqA@mail.gmail.com> (raw)
In-Reply-To: <20240813171745.24049-1-dmarx@iol.unh.edu>
Good catch!
Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
On Tue, Aug 13, 2024 at 1:17 PM Dean Marx <dmarx@iol.unh.edu> wrote:
>
> correct docstring error in conf.yaml showing incorrect
> example pci address for TG nodes
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> ---
> dts/conf.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/dts/conf.yaml b/dts/conf.yaml
> index 7d95016e68..ca5e87636e 100644
> --- a/dts/conf.yaml
> +++ b/dts/conf.yaml
> @@ -39,13 +39,13 @@ nodes:
> number_of: 256
> force_first_numa: false
> ports:
> - # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
> + # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
> - pci: "0000:00:08.0"
> os_driver_for_dpdk: vfio-pci # OS driver that DPDK will use
> os_driver: i40e # OS driver to bind when the tests are not running
> peer_node: "TG 1"
> peer_pci: "0000:00:08.0"
> - # sets up the physical link between "SUT 1"@000:00:08.1 and "TG 1"@0000:00:08.1
> + # sets up the physical link between "SUT 1"@0000:00:08.1 and "TG 1"@0000:00:08.1
> - pci: "0000:00:08.1"
> os_driver_for_dpdk: vfio-pci
> os_driver: i40e
> @@ -59,13 +59,13 @@ nodes:
> arch: x86_64
> os: linux
> ports:
> - # sets up the physical link between "TG 1"@000:00:08.0 and "SUT 1"@0000:00:08.0
> + # sets up the physical link between "TG 1"@0000:00:08.0 and "SUT 1"@0000:00:08.0
> - pci: "0000:00:08.0"
> os_driver_for_dpdk: rdma
> os_driver: rdma
> peer_node: "SUT 1"
> peer_pci: "0000:00:08.0"
> - # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
> + # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
> - pci: "0000:00:08.1"
> os_driver_for_dpdk: rdma
> os_driver: rdma
> --
> 2.44.0
>
next prev parent reply other threads:[~2024-08-13 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 17:17 Dean Marx
2024-08-13 18:20 ` Nicholas Pratte [this message]
2024-08-19 9:29 ` Luca Vizzarro
2024-08-19 13:29 ` Jeremy Spewock
2024-09-10 8:16 ` Juraj Linkeš
2024-09-11 18:52 ` [PATCH v2] dts: correct typos in user config docstrings Dean Marx
2024-09-18 20:31 ` [PATCH v3] " Dean Marx
2024-09-19 9:33 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKXZ7egnoFHp6VkmXJpMZ-9eCp=VsV4BBQcTrxghhr4uh9SrqA@mail.gmail.com' \
--to=npratte@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).