From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0E2243FD4; Wed, 15 May 2024 17:12:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E6CE402AD; Wed, 15 May 2024 17:12:57 +0200 (CEST) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by mails.dpdk.org (Postfix) with ESMTP id 732CD4021D for ; Wed, 15 May 2024 17:12:55 +0200 (CEST) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2e2da49e86bso10950811fa.0 for ; Wed, 15 May 2024 08:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1715785975; x=1716390775; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vUQhVuJDQcdawObyOVG4BokMNbbFPHe6H+bkCf/K4LY=; b=ZKG5vmVp0aAaHICgbvfkgMtOVgT74G74HG4+187bmOJkeFsA/dpMKuswChZ8Frzbv2 6vmHc24xDgFCcYoA8jeru5KM0DMhacHhhi0H5BlKaC28iflFULNmF9SrK+H1JgDRpBlT nNoD/7SiwKCIjTceNs0Yg002DLiFoLt/jJ9uk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715785975; x=1716390775; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vUQhVuJDQcdawObyOVG4BokMNbbFPHe6H+bkCf/K4LY=; b=saqm8gv7JvxNdJ+f0D0GRyorFIRUP5bwUSgZodOKO/8RX91Qxc4O71LuSAkcBB7vSL 6EHHOF6WVOUdiZs1mrTaLQRdDfmp1iLgb/6FjaW8xBAV1I7vvM7sN6OM9N5w5Va75Jdi DxUBexrG2862yXX0lApIJ2jOe9+fysNjCU63kkcqm5j8d9IC/X3EcOLZtr5F+iJRt60M bwievtNycou/jg+oL57IUrrHbLfpTs/gpcf9scTewg91+TDTWjwBh2DWKsFzmPfVxt10 MXvxA7UDtQzBSwowrPEy0daONYS+2qYkgFkrczDHG/mBZPoq85TdxUI7h07vBXLpJIqV 5gIg== X-Forwarded-Encrypted: i=1; AJvYcCXuxHup0j0qdfIHkTtReQOMAhnGKSqn8M4zqtX77Hs7+N1qfnRQcywgs86yeDn1+k2EpM2ySpxc0GMri24= X-Gm-Message-State: AOJu0YwZcVXevhOYgRB2abCYz2h2mY9DEy/5UQZA6ka3e+NvdVYCDzrF uU6rfymCZzE/L9zZomxhryOmWclU79KfsQoCP1G+NqLJZQCtmdS8CpW/JIOr3tRlY4oPl3BHvh8 osZTQryv6xS/SjQIMDYS5CXHveOWJOQ2J9VOvFw== X-Google-Smtp-Source: AGHT+IEee7k3XnbAu+QotFuJBjiWVtsQnPvRrnQDwX8LwGws339GIadydkqOfL07dl5W2O3uE51atkvmMGsamhfZZ84= X-Received: by 2002:a2e:b015:0:b0:2e3:ba0e:de02 with SMTP id 38308e7fff4ca-2e5205eb315mr119150341fa.5.1715785974775; Wed, 15 May 2024 08:12:54 -0700 (PDT) MIME-Version: 1.0 References: <20240430184533.29247-2-npratte@iol.unh.edu> <20240430184533.29247-3-npratte@iol.unh.edu> In-Reply-To: From: Nicholas Pratte Date: Wed, 15 May 2024 11:12:43 -0400 Message-ID: Subject: Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: Bruce Richardson , Luca Vizzarro , yoan.picchi@foss.arm.com, paul.szczepanek@arm.com, wathsala.vithanage@arm.com, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 13, 2024 at 6:06=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > On Tue, May 7, 2024 at 3:00=E2=80=AFPM Bruce Richardson > wrote: > > > > On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote: > > > On 07/05/2024 13:05, Bruce Richardson wrote: > > > > Sorry to be late to the reviews here, but since this is a countable= value - > > > > as you state in the cover letter- would "number" or "count" not be = better > > > > terms. To me, "quantity" is just a synonym of "amount", and can be = used for > > > > uncountable values too, e.g. "a quantity of water". > > > > > > > > > Hi Bruce, > > > > > > The change is based on the readability and intuitiveness of the > > > configuration file. In which case "number" could be ambiguous: > > > > > > hugepages_2mb: > > > number: 100 > > > > > > And here I could see "count" working: > > > > > > hugepages_2mb: > > > count: 100 > > > > > We could use number_of: but that doesn't look great. Count looks fine. I personally think that number_of is the better option of the two. Count does work, but to me, it's not as immediately clear as number_of; syntactically, it makes more sense. > > > > But since the change is propagated for consistency. "count" would no = longer > > > be well fitting in the rest: > > > > > > "description": "The count of hugepages to configure. Hugepage > > > size will be the system default." > > > > > Whatever term is actually used, the description should definitely refer= to > > "The number of hugepages to configure". > > This makes sense, let's use "number of" in descriptions. I will make the change as requested. > > Ideally we'd also use number in code, but it's a bit ambiguous, such as h= ere: > def _configure_huge_pages(self, number: int, size: int, > force_first_numa: bool) -> None: > > At a first glance it's not quite clear what "number" is here. > "number_of" would be pretty clear, but so would be "count". But using > count would mean we're using different words with the same meaning in > the same context, which I'd also like to avoid - this is the reason > why I was originally ok with quantity. Now I'm not sure what the best > option is :-) Now that you mention it, and given Bruce's comments regarding the use of quantity, I really like the use of number_of throughout the framework and even the conf.yaml. Doing so will create consistency in both the framework's internal documentation (like the 'number of' suggestion above) and the code, removing the ambiguity that you mentioned in some of the definitions.