From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48BDB4554D; Tue, 2 Jul 2024 15:51:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E6DB402EC; Tue, 2 Jul 2024 15:51:11 +0200 (CEST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mails.dpdk.org (Postfix) with ESMTP id 59EF8402D2 for ; Tue, 2 Jul 2024 15:51:09 +0200 (CEST) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52cd9c890f1so568764e87.2 for ; Tue, 02 Jul 2024 06:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1719928269; x=1720533069; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6XB4OL81rg/jHIww9f7j+H/7hdKe5s0c/PfUbVmEpiw=; b=BwPkg7Rnx7cgig9T8mpEbHjNSh2gV33X8aBV9mYzEEMW5OgO2L5tPou2RrCOx/BsZm 578yVqqAoEcUXesVDg1fbpS7cGjRjkRQxjqEL7VhpPe2T2wZ1+1avhE6sroOaZpEIPP4 GbDBPD/eeXOI4dmb8S80kXZh9tjlvPx6SwjVI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719928269; x=1720533069; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6XB4OL81rg/jHIww9f7j+H/7hdKe5s0c/PfUbVmEpiw=; b=RvAZaEQpHXS05+aC2CtojgMDmk8XkkfO8UJ4nIp1DVv7A5CmgBtij/huQgZn1YbOGf hcCGXllxrsCQbiKEPJz+Jr7mYTof8XC5n1VG728QHZ9xsuA16W4vMAhjDFzwK8H0VLZd mbuQsnPLn1CxbohTWkTXap+SoHRPMT93KcoYDXi3axjbzYrF4cOvqVeTOqvgmPnocOcj dMkXvO70RlDmv3OdlzBpdNrcVxM2tddz6KiTuIXI7fZYerx5z9jGYBVoGIAZoSvoI4Qm mf4Zt79uQzZLUzsZPWyeVeZK5GHuVM5VZC1uuTjvUCzLsxQSDGmtQD5YfMl4AY0Lt3Ml cBoA== X-Forwarded-Encrypted: i=1; AJvYcCUI5a79MD9RYHup1oPGz9ahgC1AY6r4Eg1elYayaonQ8xgQI5TbAA+3rOkHzujS+aiemraVto1zf3s+4kE= X-Gm-Message-State: AOJu0Yz7Bl90HETd7oL3LR4f+n9vBkNPYVhQZk1P41Xe7JozUOqz+Z3b VKysje/QS2WM5MGuJY18VBBmxgZfuqHa7VKHJkim4ZB2TbZPA43M3GFM0evMcAttP2d27Y9hN0T GdO1xRf9kTqiNqswWyflLTLiXlCeREAN96dTxUQ== X-Google-Smtp-Source: AGHT+IFJr695/NUXkc7lX13oeOFhKPOeo+NWS7u5pCPuCWkYpYzS3AuI/X3rONwcRoRNg3ISSSaGl0H9CURvQNDZJTU= X-Received: by 2002:a2e:a78b:0:b0:2ec:4ed6:f4a with SMTP id 38308e7fff4ca-2ee5e70ba53mr67218871fa.5.1719928268703; Tue, 02 Jul 2024 06:51:08 -0700 (PDT) MIME-Version: 1.0 References: <20240621172059.8194-2-npratte@iol.unh.edu> <20240621172059.8194-4-npratte@iol.unh.edu> In-Reply-To: From: Nicholas Pratte Date: Tue, 2 Jul 2024 09:50:57 -0400 Message-ID: Subject: Re: [PATCH 1/3] dts: add boolean to adjust addresses To: Jeremy Spewock Cc: juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, yoan.picchi@foss.arm.com, dmarx@iol.unh.edu, luca.vizzarro@arm.com, bruce.richardson@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Yeah. I vaguely remember a conversation regarding the need and validity of the 'adjust_addresses' functionality within DTS, going as far as discussing whether it is needed or not, but maybe I'm wrong? I'm honestly not sure. I'll add the argument to the doc-string. On Wed, Jun 26, 2024 at 11:49=E2=80=AFAM Jeremy Spewock wrote: > > This is funny because I actually ended up trying to solve the same > problem when writing the dynamic queue test suite. We ended up taking > different approaches, so we should probably have a discussion about > the best way to handle this. Now that we have a few use cases for why > this fix is needed, it will probably make the discussion easier since > there is less speculation. > > On Fri, Jun 21, 2024 at 1:22=E2=80=AFPM Nicholas Pratte wrote: > > > > Various test cases in the mac filter test suite called for granular > > manipulation of destination mac addresses to properly test mac address > > filtering functionality. To compensate, there is now an > > adjust_addresses boolean which the user can toggle if they wish to send > > their own addressing; the boolean is true by default. > > > > Bugzilla ID: 1454 > > Signed-off-by: Nicholas Pratte > > --- > > dts/framework/test_suite.py | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py > > index 694b2eba65..5044d5f9bb 100644 > > --- a/dts/framework/test_suite.py > > +++ b/dts/framework/test_suite.py > > @@ -185,6 +185,7 @@ def send_packet_and_capture( > > packet: Packet, > > filter_config: PacketFilteringConfig =3D PacketFilteringConfig= (), > > duration: float =3D 1, > > + adjust_addresses: bool =3D True, > > This should probably get added to the Args section of this doc-string > since it's a public method. > > > > > ) -> list[Packet]: > > """Send and receive `packet` using the associated TG. > > > > @@ -199,7 +200,8 @@ def send_packet_and_capture( > > Returns: > > A list of received packets. > > """ > > - packet =3D self._adjust_addresses(packet) > > + if adjust_addresses: > > + packet =3D self._adjust_addresses(packet) > > return self.tg_node.send_packet_and_capture( > > packet, > > self._tg_port_egress, > > -- > > 2.44.0 > >