From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2035845C26; Thu, 31 Oct 2024 21:52:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E54314028A; Thu, 31 Oct 2024 21:52:14 +0100 (CET) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mails.dpdk.org (Postfix) with ESMTP id 6B2DF40264 for ; Thu, 31 Oct 2024 21:52:14 +0100 (CET) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-539f4fb6312so187947e87.0 for ; Thu, 31 Oct 2024 13:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730407934; x=1731012734; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BRvYBmRQsdwcDcdlcWTZzfY+4YHrsYjEgFsBZJbNt1E=; b=U+tNch8mtB+/NpSEv8Jwq1ejqV16cz9W7fb81ccu+Xoi1R3uCrJ/UJG1+QAwxU2ODG VzB21Fi+wEhpss5Bo20JeJ1NkaTFlLPa89Qv6GnuvlEJnVk2nWHBDkxwzrgbXfGCLeYC 2pafaE2uYIqzhFp2V07jkHypE4OgEw1i7Wff4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730407934; x=1731012734; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BRvYBmRQsdwcDcdlcWTZzfY+4YHrsYjEgFsBZJbNt1E=; b=u4pV8QLZng4mqfp/2iqX7wIz1HMDnC+J9RgB4RI1JOUuQs7xpG79CkONuqGIU3J9m5 t4yYJfZXtHSMZG2+koZnSJI2G8qJPICjOQWT8Dkti3L4g2dPcp0SHj74Pc9icqSZb8uJ NrYcd+2U8CqVpiT9ttqi4LCHOOaEHhH/hmWdHutDv85t1C2sh/obqk5gDtqFCDHjFFQs ByZut32CXu0Yibw0Q0Ld5J4ZgG6R2OtzYAb48iGvCqLIbf/D2omY/Du2Hgb2cR27Se2X S17d+x9vuND/oAgbj/tT8Ntn4QuwSHFkdFNbG/K95/8aSpGEWxukERG3cQ3Af7ANu9Qv 130A== X-Gm-Message-State: AOJu0YwfeaTwrnmjWyPJ+UWLReQiueZwQy4BFmJfuSG8XkWhjn9Pi21k mpYTnD4qJvm/UDgVBdgqd1PZJVLwiXB0VwI6A77FTDachOpcZciEZ86cmqARXWkntpQ6jQmoKHK +LQhxn9LXltrQ8AE03R9RoRU9lFPddLXomrgDaQ== X-Google-Smtp-Source: AGHT+IEBVa6lTnq/vKrtetfVQR3wcV9LJxdUID1z5VtYKmURcdPbxo3mxKz8XACSsC+08Krq84pGJQidA2Nwub9i/Ok= X-Received: by 2002:a05:651c:2223:b0:2f1:75f4:a6a4 with SMTP id 38308e7fff4ca-2fcbdf68823mr35341821fa.3.1730407933694; Thu, 31 Oct 2024 13:52:13 -0700 (PDT) MIME-Version: 1.0 References: <20240822163941.1390326-1-luca.vizzarro@arm.com> <20241028174949.3283701-1-luca.vizzarro@arm.com> <20241028174949.3283701-7-luca.vizzarro@arm.com> In-Reply-To: <20241028174949.3283701-7-luca.vizzarro@arm.com> From: Nicholas Pratte Date: Thu, 31 Oct 2024 16:52:02 -0400 Message-ID: Subject: Re: [PATCH v4 6/8] dts: add autodoc pydantic To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek , Patrick Robb Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Definitely a set in the right direction here! Just a small typo, but otherwise: Reviewed-by: Nicholas Pratte > --- a/doc/guides/tools/dts.rst > +++ b/doc/guides/tools/dts.rst > @@ -204,9 +204,10 @@ node, and then run the tests with the newly built binaries. > Configuring DTS > ~~~~~~~~~~~~~~~ > > -DTS configuration is split into nodes and test runs and build targets within test runs, > -and follows a defined schema as described in `Configuration Schema`_. > -By default, DTS will try to use the ``dts/conf.yaml`` :ref:`config file `, > +DTS configuration is split into nodes and test runs, and must respect the the model definitions as There are two 'the' in the sentence above: "must respect the the model definitions". > +documented in the DTS API docs under the ``config`` page. The root of the configuration is > +represented by the ``Configuration`` model. > +By default, DTS will try to use the ``dts/conf.yaml`` :ref:`config file `, > which is a template that illustrates what can be configured in DTS. >