From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE105460F7; Fri, 24 Jan 2025 20:35:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9791A40267; Fri, 24 Jan 2025 20:35:51 +0100 (CET) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id E0E8640151 for ; Fri, 24 Jan 2025 20:35:49 +0100 (CET) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-53e384d00f4so409460e87.1 for ; Fri, 24 Jan 2025 11:35:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1737747349; x=1738352149; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pZm+RGn/C+YhbQxS8FVSVmvh5ka5v/UNO0PkPrC9730=; b=JGuTjwyFjuUZSlS9rkXB9Dp+cEqS1Rpc1L4JDykxSIEGER/I9U4rV7a/3gb1A82AZ7 GbuXD6uuKnOEt/yNOfswADHNSAmq7cNP0uiH1NvbGY2HSXf702q1o/vL+NcJioFW+HPS YkkJGLUWgN7Oj+a9s0hpiqvptLAOIXINwDiAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737747349; x=1738352149; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pZm+RGn/C+YhbQxS8FVSVmvh5ka5v/UNO0PkPrC9730=; b=cTeBBLP9KVB27Qc1TgWQHfsCp88nXbLoNuC+G/QgiGWEVbbHjJzYnC/b/csphfIah/ +0FoB7XrqSRaLe0bEcDhCC2TrUhMk2PVJIROYwGnprTj53D52C1TLAR36pzRSvsGofBY 8Itj47qQBgj+0q2Yqg/T/2aqrJDX4/X0OX7FhCUVVZVy5KXpDNFtg+ENQUBkya+riP3n vgta2iF8s/Rag6ccdW9J5ySbNvTP4rOEGK7Q9fzykZi1dgzpG4Q7e+M7ZSmlubww/Vow RIRDBQN7FOR6sw8+FfARJKzyMeZ0TFuKE8vdgpQ9YPYk/Lgp7WXJXZt9tXEShnN4mG62 fvAQ== X-Forwarded-Encrypted: i=1; AJvYcCVgKE2JQ27J5Mnk+oDPKpRol3xg7SR+pIaBSARZkoVnUOK9/TZza9fk2DKHJnihZmLm6Ck=@dpdk.org X-Gm-Message-State: AOJu0Yy1ddBGpYfbkT9hCTwoOxadIDQs3N3hf+PHYr81caFwp3rkL6Q1 H1QBJlAJCsMtG4RfFFgxMylKfQQkONiibHOA+gb4ZaQOZ2AjqWBXdBuzQyOMB5o0aC7y6K/k3D0 OmJ02OJ75nm1i7JTh02xOrtkzEv21st0G9MLqHQ== X-Gm-Gg: ASbGnctRKnyV8relQrZPNYu3FshkjM/jv9s46kbGYDXYeX57efuNZf5yNTxq4z1FI+D 7cToR2E1e3CqDagmBqoMc62/bPag6FjB87b1b3cS/i8VQybzzCJOnNJ6J6b3h+y0SCsjnahmQ+j 1Vq+lDSllBl7OrXRrUwjnA X-Google-Smtp-Source: AGHT+IF0/I2O1l5pLA3eFHbkMMhTZo7oBgNN9OqDHSQ+r2xxGcNRU97yF07dsqDOgdRsJz1uBMJCDk+K0yZZizCRmLw= X-Received: by 2002:a05:651c:b29:b0:300:17a3:7ae1 with SMTP id 38308e7fff4ca-3072cb3d847mr39680991fa.9.1737747349314; Fri, 24 Jan 2025 11:35:49 -0800 (PST) MIME-Version: 1.0 References: <20250117145838.40206-1-npratte@iol.unh.edu> <20250117145838.40206-2-npratte@iol.unh.edu> In-Reply-To: From: Nicholas Pratte Date: Fri, 24 Jan 2025 14:35:38 -0500 X-Gm-Features: AWEUYZnKr7q4IpJYjg8PFK5HJumlZk4v7x_qXJzFhCpD02ZUsdWGHBTtexHoo74 Message-ID: Subject: Re: [PATCH v1 1/2] dts: add fwd restart decorator to rx capabilities To: Patrick Robb Cc: yoan.picchi@foss.arm.com, ian.stokes@intel.com, stephen@networkplumber.org, Honnappa.Nagarahalli@arm.com, luca.vizzarro@arm.com, thomas@monjalon.net, thomas.wilks@arm.com, dmarx@iol.unh.edu, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Patrick, Yes! Stop ports is a required decorator because some vendors require that the ports themselves be stopped to change their MTU values during runtime. This is not to be confused with forwarding, which is what my decorator does on top of a given function. That said, I suppose this could be reworked so that forward restarting stops the ports and starts them again as well, but my concern is that there could be other functions created in the future that require forward restarts but also require the ports to be actively started. I'm not 100% sure, On Sun, Jan 19, 2025 at 8:14=E2=80=AFPM Patrick Robb wr= ote: > > > > On Fri, Jan 17, 2025 at 9:58=E2=80=AFAM Nicholas Pratte wrote: >> >> - @requires_started_ports >> >> + @requires_forwarding_restart >> @requires_stopped_ports >> def set_port_mtu(self, port_id: int, mtu: int, verify: bool =3D Tru= e) -> None: >> """Change the MTU of a port using testpmd. > > > Is the requires_stopped_ports decorated still required, or is the require= s_forwarding_restart decorator alone sufficient? > > > Looks good otherwise thanks! > > Reviewed-by: Patrick Robb