From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D061545C79; Mon, 4 Nov 2024 18:56:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD67740281; Mon, 4 Nov 2024 18:56:53 +0100 (CET) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id 593104025F for ; Mon, 4 Nov 2024 18:56:52 +0100 (CET) Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-539e4908837so628606e87.0 for ; Mon, 04 Nov 2024 09:56:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730743012; x=1731347812; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5PtFH/SmXSTHW+s/C2raBHzbXbfsYe8NnKejtFDXDmY=; b=FJ2F/FRnMFe6bEg8P+FKMn+ghA0AF4rGiaQA75P9dzYBnlg6mknMjXmFAWERCi+NO5 EVEEVOLvzfxucYqDk7HIyGmfQ+jo4cRCXh4VjgzoLWgO/P3ldh1+Sv3X3qpnRq1ZdjBn F8ZdlilRTxNDqmy+tmRmCyvbCIAYGaPVrkHl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730743012; x=1731347812; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5PtFH/SmXSTHW+s/C2raBHzbXbfsYe8NnKejtFDXDmY=; b=YcWqaeFy3c0CbIeVxPppPn2gfMeWAHlnSBD6FU+4Zbfauy9lx8s8OTXwftO3x8RGQ1 onVKUG/rbFeEav2Ew9vMZ4EkMxJvx8hAZTjpHH4olK0LO+wXJ4TjFSg46dGrireUYgdt aZfdfsomYhYFwy+LjNksjSZpEDv0xUECNx4YsQHHUJry20yIhaeYSCV2ansUbeu4xpFv q7XRJUG9noSnRwdhAzmSyqOtY+aoZSZw4J5NwLloIyicdnYQZA4PZbITHdPWdZ/HFJJA SOnIKwEfxKuo1rSntHV4Y6HqxF62i83pia+yZTmJEOS8vPHUtD7rZfSv3gCCkY7PAop7 r3LQ== X-Forwarded-Encrypted: i=1; AJvYcCWTfI0SoCQnoP2KtQNGhlPYLI7oPSwAAULiQLgtUPM2dALrUi+Dz5QL+3z3oK1L5E0JFOM=@dpdk.org X-Gm-Message-State: AOJu0Yyw5lw8H9pdAKF7v7MyVbe4K6njUcmXzWKv/M8ad0iy1WuEA4OP Byl4KrjwHGvPOKzH4C1ifly6f2V66vfVJVNekJlF/sOHg6WDaCXO/uz6KMxbmz0E774mjyCNPz9 b+kwJ6dVvu6aAGAXZ/dSmjraKea5ExYtB9Fng3w== X-Google-Smtp-Source: AGHT+IGPom7NGHgu+zt1YsDHP7lWR1g/LWUJiCHovKK8qw2pD5prRLG2ucf9GG/nKQCcxwEieZkexqyHvvwEsaNtXXo= X-Received: by 2002:a05:651c:2123:b0:2fb:565a:d93b with SMTP id 38308e7fff4ca-2fcbe04bb80mr50740081fa.8.1730743011672; Mon, 04 Nov 2024 09:56:51 -0800 (PST) MIME-Version: 1.0 References: <20240812142355.12532-1-dmarx@iol.unh.edu> <20241010184226.4088-1-dmarx@iol.unh.edu> In-Reply-To: <20241010184226.4088-1-dmarx@iol.unh.edu> From: Nicholas Pratte Date: Mon, 4 Nov 2024 12:56:40 -0500 Message-ID: Subject: Re: [PATCH v2] dts: fix verify argument in set forward mode To: Dean Marx Cc: probb@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Reviewed-by: Nicholas Pratte On Thu, Oct 10, 2024 at 2:42=E2=80=AFPM Dean Marx wrote= : > > Fix optional verify argument in set_forward_mode > method in testpmd shell class. > > Bugzilla ID: 1410 > Fixes: fc0f7dc47ee3 ("dts: add testpmd shell params") > > Signed-off-by: Dean Marx > --- > dts/framework/remote_session/testpmd_shell.py | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framewor= k/remote_session/testpmd_shell.py > index dc1bef431d..c43b8b7520 100644 > --- a/dts/framework/remote_session/testpmd_shell.py > +++ b/dts/framework/remote_session/testpmd_shell.py > @@ -1567,11 +1567,12 @@ def set_forward_mode(self, mode: SimpleForwarding= Modes, verify: bool =3D True): > fails to update. > """ > set_fwd_output =3D self.send_command(f"set fwd {mode.value}") > - if f"Set {mode.value} packet forwarding mode" not in set_fwd_out= put: > - self._logger.debug(f"Failed to set fwd mode to {mode.value}:= \n{set_fwd_output}") > - raise InteractiveCommandExecutionError( > - f"Test pmd failed to set fwd mode to {mode.value}" > - ) > + if verify: > + if f"Set {mode.value} packet forwarding mode" not in set_fwd= _output: > + self._logger.debug(f"Failed to set fwd mode to {mode.val= ue}:\n{set_fwd_output}") > + raise InteractiveCommandExecutionError( > + f"Test pmd failed to set fwd mode to {mode.value}" > + ) > > def stop_all_ports(self, verify: bool =3D True) -> None: > """Stops all the ports. > -- > 2.44.0 >