From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E003454F4; Tue, 25 Jun 2024 21:57:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32BEA42796; Tue, 25 Jun 2024 21:57:16 +0200 (CEST) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mails.dpdk.org (Postfix) with ESMTP id F08C840677 for ; Tue, 25 Jun 2024 21:57:14 +0200 (CEST) Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ec4df7077bso2897291fa.0 for ; Tue, 25 Jun 2024 12:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1719345434; x=1719950234; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eifUM+13lO+4g6wuEnnNAbCq5haU2cgvl+6ZFZucmbw=; b=hFzwmWufLXWDs6oyanZgQNyVwSNInrXQc1w1SMMs7xCzBDS8t+IFKhTTxwnjn94ZiX 6HQa69HaoR2xyV34Jn6VfoqCBXLt9dV1Mtldfi80nEUfZabvB3PZYg9x6a0QdJGu2vFg dJzY/ZlOkn347WqQfQzccDvlc+GGUCvvDVp2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719345434; x=1719950234; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eifUM+13lO+4g6wuEnnNAbCq5haU2cgvl+6ZFZucmbw=; b=APs895hSGZgozkeIxo14qPqEKvtAsIcezNPTJvWFzl3YAasn+tt+k2B8ZdB3+LwxGh cwYfhAZk0hazDgD2X83Z2hz1tOuwF7DVYRpTLOlVP04BKjRlJFbUwFkaD5BsRtcLCfgp jdYzZZXjoBV+f/vlBtTLr/xnwi0lOKSU8J4552rKtodGSlQYuMgwm9/vzw/HRMEQnau3 WKvdjKstFeNugMwfRrCDJkpBoZWcVaXGqzwLadp9WGi96g8O4jOIp5zjP5VWfw/00I9f Cy1TnlHMZOwbc8WyR6PdHgvvTyFDZWy4jVCZxRtmo3PoTI+B+ZDSoOoUkXOWqVOumH7E THbA== X-Forwarded-Encrypted: i=1; AJvYcCUUGiRqx1X1v2At/Fg2Eda1iCcpM3jgO5JR1Gn9yebKhR8mUouBTvuTCLEuDwk5Vb8AKcQ1jBZLj33p/SE= X-Gm-Message-State: AOJu0Yzjwsz9JTN84WSttrTBa01VrZf1/PCXjMl+nD4uoEOEny7jZuys Z3o5RPBV/ONaBAZS9up1qKaXrxVNQyln9xLHrGNfXg7MDa0EKrXN3/NDj05WSBOURyiz5WhnTww FVfiwn0iGZ/D54VUE/nBdOOfsW8FUM29Q0Q9CUg== X-Google-Smtp-Source: AGHT+IH5rgjmu4asFIvbWIJ56rMfJBtNKaDoXPtOvKdOHiuuyeo3kaiG4r63Gui7q9neRodJOc9qjxQv/p/6uoYDrjg= X-Received: by 2002:a2e:7a12:0:b0:2ec:3e14:fa1c with SMTP id 38308e7fff4ca-2ec561e8f2fmr50961741fa.5.1719345433930; Tue, 25 Jun 2024 12:57:13 -0700 (PDT) MIME-Version: 1.0 References: <20240524183604.6925-1-npratte@iol.unh.edu> <20240621211920.14286-2-npratte@iol.unh.edu> <20240621151802.33021b4a@hermes.local> In-Reply-To: From: Nicholas Pratte Date: Tue, 25 Jun 2024 15:57:02 -0400 Message-ID: Subject: Re: [RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite To: Honnappa Nagarahalli Cc: Stephen Hemminger , =?UTF-8?Q?Juraj_Linke=C5=A1?= , "dmarx@iol.unh.edu" , "jspewock@iol.unh.edu" , "Richardson, Bruce" , "yoan.picchi@foss.arm.com" , Paul Szczepanek , Luca Vizzarro , Patrick Robb , "dev@dpdk.org" , nd , thomas@monjalon.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The previous comments led me to go on an investigation about how MTUs are allocated in testpmd. --max-pkt-len, which the documentation states is defaulted to 1518, will shave off 18 bytes to account for the 14 byte Ethernet frame and the Dot1Q headers. This is the case when using Mellanox, but for both Intel and Broadcom, when explicitly setting --max-pkt-len to 1518, the MTU listed on 'show port info' is 1492. So there are 26 bytes being shaved off, leaving 8 unknown bytes. Does anyone know what these extra 8 bytes are? I wondered if these might be VXLAN, FCS or something else, but it might just be easier to ask and see if anyone knows; I can't find anything about it in documentation. As far as how this relates to the test suite at hand, the send_packet_and_capture() method will need to be reworked to compensate for the extra 4 Dot1Q header bytes, but I'm still curious about the extra 8 bytes on the Intel and Broadcom devices I've tested on; again, these bytes are not present on Mellanox, which is just bound to their specific kernel drivers. When I manually set the --max-pkt-len to 1518, with the MTU then set to 1492 bytes, packets sent to the SUT can only be, including frame size, 1514 bytes in size. So I'm looking at the DPDK MTU output plus 22, even when using 'port config mtu 0 1500,' for instance, so I'm not sure why 26 bytes is subtracted here. On Fri, Jun 21, 2024 at 7:55=E2=80=AFPM Honnappa Nagarahalli wrote: > > > > > On Jun 21, 2024, at 5:18=E2=80=AFPM, Stephen Hemminger wrote: > > > > On Fri, 21 Jun 2024 17:19:21 -0400 > > Nicholas Pratte wrote: > > > >> +The test suite ensures the consistency of jumbo frames transmission w= ithin > >> +Poll Mode Drivers using a series of individual test cases. If a Poll = Mode > >> +Driver receives a packet that is greater than its assigned MTU length= , then > >> +that packet will be dropped, and thus not received. Likewise, if a Po= ll Mode Driver > >> +receives a packet that is less than or equal to a its designated MTU = length, then the > >> +packet should be transmitted by the Poll Mode Driver, completing a cy= cle within the > >> +testbed and getting received by the traffic generator. Thus, the foll= owing test suite > >> +evaluates the behavior within all possible edge cases, ensuring that = a test Poll > >> +Mode Driver strictly abides by the above implications. > > > > There are some weird drivers where MRU and MTU are not the same thing. > > I believe the e1000 HW only allowed setting buffer size to a power of 2= . > > At least on Linux, that meant that with 1500 byte MTU it would receive = an up to 2K packet. > > This never caused any problem for upper layer protocols, just some pick= y conformance tests. > The test cases should not concern themselves with individual PMD behavior= s. They should be based on the API definition. >