Re: [PATCH v2 0/3] Improve interactive shell output gathering and logging

[Nicholas Pratte <npratte@iol.unh.edu>]

Acked-by: Nicholas Pratte <npratte@iol.unh.edu>

On Thu, May 9, 2024 at 5:59 AM Luca Vizzarro <Luca.Vizzarro@arm.com> wrote:
>
> On 01/05/2024 17:16, jspewock@iol.unh.edu wrote:
> > This version addresses comments from the last and adds an additional
> > improvement to the logging output that comes from interactive shells.
> > The new way of handling logging allows for not only specification of the
> > host that the command is being sent to like before, but also the type of
> > shell that you are addressing. This is beneficial for 2 reasons:
> >
> > 1. Less ambiguity on if a command is being sent to the host directly or
> > into an interactive shell
> > 2. Ability to name shells so that there is distinction in the logs
> > between two different interactive shells of the same type that serve a
> > different purpose (e.g. a python shell and a python shell that is
> > serving and XML-RPC server for scapy interactions)
>
> Hi Jeremy,
>
> Thank you for your patches! Everything looks good to me.
>
> Best,
> Luca