From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB91045972; Thu, 12 Sep 2024 22:33:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAF7F4028F; Thu, 12 Sep 2024 22:33:28 +0200 (CEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id 7A3DF40269 for ; Thu, 12 Sep 2024 22:33:27 +0200 (CEST) Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5356d34ef19so168070e87.2 for ; Thu, 12 Sep 2024 13:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1726173207; x=1726778007; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TtDhuaonGUyK7wvuuWbxLRmyn006XGjBQWGBRCKvJus=; b=gkeljZ+vZAig4fGgsgwM+SoTVAy4fGcub9/V4BIS1zv3AVP24nYK2Msq193GXofWib 4KM7m/SDmn/9GkRJBeceoYCqVlOPhuZD0DB+w4ALh8A16glYgqQkS0CJ6+CijGfQ9LHt J4MQgwoqJ5So6t8sCs2y8FqeovcZTPx/Ql9SA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726173207; x=1726778007; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TtDhuaonGUyK7wvuuWbxLRmyn006XGjBQWGBRCKvJus=; b=YQnDalv2X3Zi4wpdVRiwCLt2n38Em8ZeySxtwtTkcIIZwuRtLFrYQxjAeAKCYDbILK mE+CMs0UFFtG6m3Ux8r2X8vIU90yRDrIbGOvCcIF3PmGUTDA3DKmuD8bB36sZ+gmcQ9Q BvXLc6CuId2Y3a+a8oWZgZ9NRvP719Zr+Xk+LVVo+u7eL4tardmyksyJRc166C1XmZuX OobvxtFuAEcRrcaF6RUgKMpWYn7KeE2nOsOMbr/avqT65pESafvzbY+6bNiQ1PxCSSpZ 2/bYtsVkJnqFi5n2dq1rwThUSgRWTFN21L4rrkRurwOi93mg/9n1Hv80RfOU5dJrDNgR nI3A== X-Forwarded-Encrypted: i=1; AJvYcCWG9OyhcTbfp32bsts5R/ueUFzrMz6a/WhDTG4mObf3VAbG+EGIeM/yUvm3zBO0zolIKkw=@dpdk.org X-Gm-Message-State: AOJu0YyIhvpzIWLM1+arNMIQhkMOcO5ItUPHd8VX5vyfpZmulUc2eOJO zE95FeSpq4UapfnzkPOSID3bSpENlydT0mTg1Vd+FR9FH/bBiR7MR2HSi0+SiX3FvVEMyzogtdC m5S7XKTG5TNUAPWx0SehTAbE5jDlWsqokyvRQ/Q== X-Google-Smtp-Source: AGHT+IH3+mtA6CUXK4T+Vbn6oMJ+B4OWVB0TE/mYbtMWLfqXJdBdBkdQsMTlqRyusefXmDGsaLGXCZGLCXbNsVGzpos= X-Received: by 2002:a05:651c:1502:b0:2f1:5c54:7517 with SMTP id 38308e7fff4ca-2f787f4acddmr6145871fa.7.1726173206653; Thu, 12 Sep 2024 13:33:26 -0700 (PDT) MIME-Version: 1.0 References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240705171341.23894-4-npratte@iol.unh.edu> In-Reply-To: From: Nicholas Pratte Date: Thu, 12 Sep 2024 16:33:15 -0400 Message-ID: Subject: Re: [PATCH v2 1/6] dts: Remove build target config and list of devices To: Jeremy Spewock Cc: probb@iol.unh.edu, dmarx@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > @classmethod > > def from_dict(cls, d: BuildTargetConfigDict) -> Self: > > r"""A convenience method that processes the inputs before creating an instance. > > > > - `arch`, `os`, `cpu` and `compiler` are converted to :class:`Enum`\s and > > - `name` is constructed from `arch`, `os`, `cpu` and `compiler`. > > + `compiler` is converted to :class:`Enum`\s > > Because it's only the one attribute now this should likely just be > "`compiler` is converted to an :class:`Enum`" and because you don't > need this \s, I think you can also remove the "r" from the start of > the doc-string that makes it a string literal. I could have sworn I fixed this before sending this out. I'll take care of it!