From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC517457A1; Mon, 12 Aug 2024 17:17:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3946D402BB; Mon, 12 Aug 2024 17:17:58 +0200 (CEST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by mails.dpdk.org (Postfix) with ESMTP id ECB9A4014F for ; Mon, 12 Aug 2024 17:17:56 +0200 (CEST) Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2f01db9f419so4065401fa.3 for ; Mon, 12 Aug 2024 08:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1723475876; x=1724080676; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qn2K+C55IOBMVrQzvL2Y7p7XpBHjI3pT78jRBYElezs=; b=SzBmy8avUC+fUenJqWpQ6OvFgCAUucQgQpV9uQL0BMPzWcPJqpbvNgsKPythIKLfRa HUkCbwvE3lKLp/Y7J9unf8PhYUZrHFD1A8Ou21OTJTgxmYxEC0HG0yGtF6VppvzR00MX +bFpjj/1/8DmXa977tb4S0/hTpHnz6OhG+YAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723475876; x=1724080676; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qn2K+C55IOBMVrQzvL2Y7p7XpBHjI3pT78jRBYElezs=; b=FxjUufevHPwJcsvhgmy5X+jMSyvtaUr40cvLmAWNHVep9kSVlPiktA5iTNJffJ6jc8 YpcnbiizP/PxsJHCDI8oAz+xc5eeg8WToijwX4mkll2jNGz1oFsZSP1r2IeQEs4GEgQl w5KzDMBhXM2D3ktdrzu9gx53Fr6emgRZh+UizrYfZGMZRim+w+bW4arbV2jGWwyOvzpu K4tcL1xi8S9DkAKnYetmPZn3Ict+W1j4Cd0UqxOFUXRugzvQ0X507cXe2BEPKqHwI6SR IUa5EPxgpzUcBhMApOEPPYosp59uOt4j0PW2ds+uztjrnvdeFxhQ10ci11qMy/a+Npbt x7ow== X-Forwarded-Encrypted: i=1; AJvYcCWskS10XqATzN8n3JiXTXu7yyltHRcvT2O6m3hMHUb8nFWYutjuYNmhCUG79Yux2nsgZzsIiIuz+HEk9NM= X-Gm-Message-State: AOJu0YzEOJtIcJssMPJU+GWnVFmWIDgP/a1TRHFHYrljKNgtM5N2b9Yr XMreHRLmVd+eo/YnpDAlYSxxbXUa/a7etMllLLiLiWf8iteWOxCx6GcSPiOxd0gX6+Siwhp45Ft cww9118aSn9jIuA5ShmMETyFNVGdH2Dasjz8vsw== X-Google-Smtp-Source: AGHT+IFmKoRdXlUm46ObGP1I8Ct2Zgx7UxtxbgUQGGj7TlGrziG2hZW904HSMlYx/PNVAMGt/Z55SDGSIPFqyem0r8g= X-Received: by 2002:a2e:a591:0:b0:2ef:307d:17 with SMTP id 38308e7fff4ca-2f2b71484c0mr2817391fa.1.1723475876138; Mon, 12 Aug 2024 08:17:56 -0700 (PDT) MIME-Version: 1.0 References: <20240812150421.31226-1-jspewock@iol.unh.edu> <20240812150421.31226-2-jspewock@iol.unh.edu> In-Reply-To: <20240812150421.31226-2-jspewock@iol.unh.edu> From: Nicholas Pratte Date: Mon, 12 Aug 2024 11:17:44 -0400 Message-ID: Subject: Re: [PATCH v1 1/1] dts: add admin privileges to hugepage mounting To: jspewock@iol.unh.edu Cc: probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, wathsala.vithanage@arm.com, yoan.picchi@foss.arm.com, thomas@monjalon.net, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, alex.chapman@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Reviewed-by: Nicholas Pratte On Mon, Aug 12, 2024 at 11:04=E2=80=AFAM wrote: > > From: Jeremy Spewock > > There were two different commands in the hugepage mounting process that > were not using super-user privileges; one for unmounting hugepages and > another for re-mounting them. This patch adds the flag that enables > enhanced permissions for both of these actions. > > Bugzilla ID: 1439 > Fixes: b8bdc4c58f57 ("dts: replace pexpect with fabric") > Cc: juraj.linkes@pantheon.tech > > Signed-off-by: Jeremy Spewock > --- > dts/framework/testbed_model/linux_session.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework= /testbed_model/linux_session.py > index 99abc21353..544a665b83 100644 > --- a/dts/framework/testbed_model/linux_session.py > +++ b/dts/framework/testbed_model/linux_session.py > @@ -123,12 +123,12 @@ def _get_numa_nodes(self) -> list[int]: > def _mount_huge_pages(self) -> None: > self._logger.info("Re-mounting Hugepages.") > hugapge_fs_cmd =3D "awk '/hugetlbfs/ { print $2 }' /proc/mounts" > - self.send_command(f"umount $({hugapge_fs_cmd})") > + self.send_command(f"umount $({hugapge_fs_cmd})", privileged=3DTr= ue) > result =3D self.send_command(hugapge_fs_cmd) > if result.stdout =3D=3D "": > remote_mount_path =3D "/mnt/huge" > - self.send_command(f"mkdir -p {remote_mount_path}") > - self.send_command(f"mount -t hugetlbfs nodev {remote_mount_p= ath}") > + self.send_command(f"mkdir -p {remote_mount_path}", privilege= d=3DTrue) > + self.send_command(f"mount -t hugetlbfs nodev {remote_mount_p= ath}", privileged=3DTrue) > > def _supports_numa(self) -> bool: > # the system supports numa if self._numa_nodes is non-empty and = there are more > -- > 2.45.2 >