From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06B8A43FCC; Tue, 7 May 2024 19:46:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E795E43460; Tue, 7 May 2024 19:46:17 +0200 (CEST) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by mails.dpdk.org (Postfix) with ESMTP id 27F43402DF for ; Tue, 7 May 2024 19:46:17 +0200 (CEST) Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2e2da49e86bso7111931fa.0 for ; Tue, 07 May 2024 10:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1715103976; x=1715708776; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BQ6cgifVkSC0AsTvLQzMLPGIMmTdBWcAnzTFCk1qQ2o=; b=QW6MLcdO3OlhSkX4O7OKtxZ1mMxL3b+foiC2ZzVDw8Sw6Jcwwm8Ds6h/isG7giRq77 zqBSzss0Lh+H03q5NIXLrXZ9/6hwQMiT9Fqw3AwymL269W9FfFkTm58lGO4ORHKPHjsr cpwJDrpwbGWWfbK5gxfny+DIWB/enMfdto+QM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715103976; x=1715708776; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BQ6cgifVkSC0AsTvLQzMLPGIMmTdBWcAnzTFCk1qQ2o=; b=xK+cQHyT1IiPpDRlGYkscOHxgvOELhcW0mPuS62D8qGwAAk1IhDMDgCHxREei0aRMt jOR2rQJsxarymF3vLEoGdwqxupU72Q/OFd7lUSogpFfXjbBOkmteMR/JeFiJ/VlqxqAp ZiD/MuWHx81wJirnEd6vp+vmN4U1ZQYussjwnAWiqK88kOVzG1Wu1aQ2ObXLtRUMR5T6 pVODlw8ta9bZOkHjveTeK0j14inrixi1dzUvlR6uYNjUe3NRkq1mw9EPzRTxMfn02uLM eoEgfDlkS+8CmH0LugILB3/AqtVlIP/zo34YcV88QBYJhBk+DYJpQBnn/iu4C5WP09TM YEKQ== X-Gm-Message-State: AOJu0Ywkj5Y876vRFCufy6f3tHtevDob2AXracEExlk5hJokM6/XnnRY WCf8oW0oVNmmGsu4ZQJDKDa/1Y+DGXcDFhXwT0hZsnRbvTnL4487GeAIwRCyHlBwT8XaCnghPiI RzJj3g2ow0x+ekxrqYkoqVQfC/s4kXN6AvCg0aQ== X-Google-Smtp-Source: AGHT+IEnYiwQ3KYFExmCefiDjV+PEoHzZbyiWhyJFLQeJfZE8DMhRiog3KTCRewog9o1KdO8UX4MIXLwh1RCOjkTvCs= X-Received: by 2002:a2e:b004:0:b0:2e2:9416:a65b with SMTP id 38308e7fff4ca-2e446079b14mr1905851fa.0.1715103976569; Tue, 07 May 2024 10:46:16 -0700 (PDT) MIME-Version: 1.0 References: <20240430184533.29247-4-npratte@iol.unh.edu> <20240507174430.29403-1-npratte@iol.unh.edu> In-Reply-To: <20240507174430.29403-1-npratte@iol.unh.edu> From: Nicholas Pratte Date: Tue, 7 May 2024 13:46:05 -0400 Message-ID: Subject: Re: [PATCH v6 0/2] Methodology change for hugepage configuration To: probb@iol.unh.edu, bruce.richardson@intel.com, Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, thomas@monjalon.net, jspewock@iol.unh.edu, yoan.picchi@foss.arm.com, mb@smartsharesystems.com, wathsala.vithanage@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Resending the patch and superseding the old one on patchwork. I accidentally sent this patch series through some kind of container instance. On Tue, May 7, 2024 at 1:44=E2=80=AFPM Nicholas Pratte wrote: > > In order to prevent accidental misconfiguration of hugepages at runtime, > the following changes are made to only allow for configuration of 2MB > hugepages within the DTS config.yaml. In the previous implementation, a > default hugepage size was selected via the size listed in /proc/meminfo. > The problem with this implementation is that, assuming the end-user has > made prior modifications to the system, /proc/meminfo may default to > hugepage sizes that are not recommended to be configured at runtime > (i.e. 1GB hugepages). This can lead to two problems: overallocation of > hugepages (which may crash the remote host) configuration of hugepages > sizes that are not recommended during runtime. In this new implementation= , > we stipulate that any runtime hugepage configuration size that is not 2MB > is considered an outlier. If the end-user would like to configure either > 1GB hugepages or any unique hugepage size outside of 2MB, then they shoul= d > make these configurations either at startup (in the case of 1GB hugepages= ) > or runtime outside of DTS configuration (if a user would like hugepages > that are not 2MB). In either case, the expectation is that, if wish to > use hugepage sizes that are not 2MB, you will make these changes outside > and prior to the initialization of DTS. > > The end-user has two options: remove the option for hugepage > configuration in the conf.yaml, or keep the option and specify the > amount of 2MB hugepages desired. In the case of the former, then we assum= e > that hugepages are already configured prior to DTS initialization. In > the latter case, the user must define the amount of 2MB hugepages to be > configured at runtime. If the amount of 2MB hugepages requested exceeds > the amount of 2MB hugepages already configured on the system, then the > system will remount hugepages to cover the difference. If the amount of > hugepages requested is either greater than or equal to the amount > already configured on the system, then nothing is done. > > Nicholas Pratte (2): > dts: Change hugepage runtime config to 2MB Exclusively > dts: Change hugepage 'amount' to a different term > > doc/guides/tools/dts.rst | 6 ++++- > dts/conf.yaml | 8 +++--- > dts/framework/config/__init__.py | 8 +++--- > dts/framework/config/conf_yaml_schema.json | 12 ++++----- > dts/framework/config/types.py | 4 +-- > dts/framework/testbed_model/linux_session.py | 28 +++++++++++--------- > dts/framework/testbed_model/node.py | 4 ++- > dts/framework/testbed_model/os_session.py | 7 ++++- > 8 files changed, 45 insertions(+), 32 deletions(-) > > -- > 2.44.0 >