From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F7D445741; Mon, 5 Aug 2024 15:20:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D2D5402CA; Mon, 5 Aug 2024 15:20:25 +0200 (CEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id 9627D402B7 for ; Mon, 5 Aug 2024 15:20:24 +0200 (CEST) Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2ef301eabe4so6323661fa.0 for ; Mon, 05 Aug 2024 06:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1722864024; x=1723468824; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LZIR3GiDqGHF2IS+lsZsiKZ6whINeVU8QmhlsK9Remc=; b=hTFX0EOzOC4GgmjUEmtgJynDEY6p4GC80NNVqh12SOJ6bToXgR/Ze0yqjBuKqVVaB5 Qnkdw29eeYxChwri9KNsbki8avgqklYpSJnLx/vU3RXMsrwZVgmH5sb36YaNvLc75lYq LObIxo+z0/iEjsD1QoRme9nTnQ2t9S7lAwZuw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722864024; x=1723468824; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LZIR3GiDqGHF2IS+lsZsiKZ6whINeVU8QmhlsK9Remc=; b=Xr1s0o7f0uNG5jrJ0ILo59QxCpXkK2UQ2Cu1QNdth9rtflLgMUjc8hZLgzSvM72Lbe OrrCon7mZzCaKoDIBVPxbVG9tc1WApmd8dUUfYxZUTT9HBTErt9e+RycQlzTtW1AyuhA Zq2qLNjuJUZyfuPYzxbL1DPVJTSIiQadp8WACnLZucJSla7Yc27rJwrdm81Y0bETSwmF rfpxyLB4uQf+EE82JZ0i+Wr5tSBay4x3Ver/h+LFkwM/f6svRRP4b8xUAte7+UguI0Sg ksYkJDZykhR3c/EfIJTdY1JTWhHdAEWtuhNI0BOYIy1K5WKh3Ya/6O1YRa0NG3G6gvGF 153A== X-Forwarded-Encrypted: i=1; AJvYcCVCrb3sK3nJiwAmLbHwybEHU8KqIAZd33lng1QQLGdDHy0ZIvXnXhTiW7/Kg5IJLOgDtaI=@dpdk.org X-Gm-Message-State: AOJu0YwHMKDwcc/6wQvLkkvpxmyL4v5qQxP8um7PBy8Use/QafSazKpz L0DPhKKkD+8G599ZifwoVnFfSnELhhbNM0qmbNaL0gwJ79X2V2M8WaTc5W2yqF8OXy3P8rw9QS4 1esPKbt1xW4eWOKDLdcjHICAYgI6N3kjDjHXz8A== X-Google-Smtp-Source: AGHT+IENcSoHLHQ/G//U8goUgLJT5FOiFSIT5b/9yHsGWPnb7RS+uvGq9ATVDREJWNAt3MTbRleDsje3MgTcQ5gMi2I= X-Received: by 2002:a2e:958d:0:b0:2ef:226e:bc6d with SMTP id 38308e7fff4ca-2f15aa74724mr40990801fa.2.1722864023501; Mon, 05 Aug 2024 06:20:23 -0700 (PDT) MIME-Version: 1.0 References: <20240729203955.267942-1-jspewock@iol.unh.edu> <20240730133459.21907-1-jspewock@iol.unh.edu> <20240730133459.21907-2-jspewock@iol.unh.edu> In-Reply-To: From: Nicholas Pratte Date: Mon, 5 Aug 2024 09:20:12 -0400 Message-ID: Subject: Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output To: Jeremy Spewock Cc: yoan.picchi@foss.arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, Luca.Vizzarro@arm.com, juraj.linkes@pantheon.tech, wathsala.vithanage@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > I like the sound of this idea a lot actually since it would remove the > chance of the output just completely being thrown away. In my own test > suite I managed to dance around this by strategically placing my > testpmd commands, but this could save people some headache in the > future. I feel like this wouldn't be something overly complicated to > implement either, all we would have to do is extend the send_command > method in the TestpmdShell class and check a boolean for if verbose is > on, extract this output. If/how to clear this list would be something > to think about, but I would say that, in general, the idea of making > sure we don't lose information is something that I'm all for. That's a good point that you could just modify the send_command method. In my head I was thinking that we'd have to modify each individual method! Totally forget that all those testpmd methods I was thinking about stem from send_command().