From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 75E752BCE; Sat, 10 Nov 2018 12:03:42 +0100 (CET) Received: by mail-ot1-f68.google.com with SMTP id n46so3967904otb.9; Sat, 10 Nov 2018 03:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IZp5sc+F8nlAHVsu5qB7p75t8M8GDJr5E/cNkCyUBbY=; b=L5u9Eo1EiI20Pq6K/W5yw/NR6pH3j7uUSBkMy3ubPYHh7xiylcUps6IxdaFQLJLRtY nkEvnx8mgMUSKZrE4+c81kbZa8Ef7dZvAtOlNPjfzGiXBUx3GGze9+d4mIqisyCyy+Tx nRbXAWQCnq3d5GGpINfsOB6oqDWYeBTktxqIkrzUR8Pt3mYkvAAolKYc0UVP6XFL9+NS +zxD+xEJVWjwexPew0satWm7ccOJDvpouJSKT7+cXgdWNwe3NqwwGVbL4Unk7rz7tnPg mBBNn5u/7C1WJ1iqs8bv5XVezkpXvA1TEZanxAfAT7NOwX+4+ITSDnc9N6YBNurQDniI dokQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IZp5sc+F8nlAHVsu5qB7p75t8M8GDJr5E/cNkCyUBbY=; b=anE23uZkabwuz3D4KSWBuJsAviEZqbDBgN8o/PL6P1gg6dqL/iGbo/rJG3PqhWqPm9 Ml8BaVy0UQO1HJa6YXmqAbC3/Dl6YwsKeFOlQUydzH/RiHXJBYCDkkIzFG/gqsGQYJXp aIeDLSdxRr8G1725g3jKuNveeZp/KAi/122a9Py2boRQwkCbeI1SKrMiIdSOlHT77BR2 hxXCFyN7c8sWmxWil2R4NrGBYBOqoBJVJ4lT3eLf1kg8Hf4SVSZlU0f1KOZq8G0ruTRO GNeQ9rzL/lSZ846+5+vMN7yBbE+i32vq2jxzsJ6I8JAAY3QhQ5iwX3bfkVjrweJp5qFk XOuQ== X-Gm-Message-State: AGRZ1gLxHijByPzAfkQw3beqHzn0HPg+uiIm8a7N+sQ29iQBTL1HutYz EXq0i5sF0GGReHA5gg03cqTpHthlYGwsQb0nH40= X-Google-Smtp-Source: AJdET5c8TGsDYdGRMQRhEtFYaLG49Fwrnsmfq/AzY7mhJgY8/ZQuVj6ZBxD2VrIu3lxoCJCeTbqGp91A71se/Y2wcuc= X-Received: by 2002:a9d:7ac6:: with SMTP id m6mr7599772otn.62.1541847821621; Sat, 10 Nov 2018 03:03:41 -0800 (PST) MIME-Version: 1.0 References: <9e7f9bd5-b71b-4758-133e-16b1c8e6abbe@intel.com> In-Reply-To: <9e7f9bd5-b71b-4758-133e-16b1c8e6abbe@intel.com> From: Rami Rosen Date: Sat, 10 Nov 2018 13:03:29 +0200 Message-ID: To: "Burakov, Anatoly" Cc: Ferruh Yigit , dev@dpdk.org, john.mcnamara@intel.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2018 11:03:42 -0000 HI Anatoly, >Do all other distros have lspci in package called pciutils? If not, i >prefer to keep it the way it is. Your original patch have: + if ret != 0: + print("'lspci' not found - please install 'lspci'") And I suggest to consider changing it to: >> + if ret != 0: >> + print("'lspci' not found - please install pciutils') > Sorry about my ignorance: which distro has a package named "lspci", if at all? The official project that include the lspci utility is called "pciutils": see: http://mj.ucw.cz/sw/pciutils/ You can see that a package named "pciutils" is available in great many distros, like: Fedora, OpenSuSE, CentOS, RHEL, Ubuntu, Debian, Mandriva and Mageia, according to the following links: http://www.rpmfind.net/linux/rpm2html/search.php?query=pciutils&submit=Search+... https://packages.ubuntu.com/trusty/pciutils https://packages.debian.org/search?keywords=pciutils https://rpms.remirepo.net/rpmphp/zoom.php?rpm=pciutils Regards, Rami Rosen