Re: [dpdk-dev] [PATCH v1 2/2] examples/vdpa: add a new sample for vdpa

[Rami Rosen <roszenrami@gmail.com>]

Hi all,
First, thanks for the vdpa example patches.
Second, I am getting a compilation error under Ubuntu 18.04, with gcc
version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)
...
  CC main.o
/work/src/dpdk/examples/vdpa/main.c: In function ‘main’:
/work/src/dpdk/examples/vdpa/main.c:321:5: error: ignoring return
value of ‘scanf’, declared with attribute warn_unused_result
[-Werror=unused-result]
     scanf("%c", &ch);
     ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
/work/src/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target
'main.o' failed
make[1]: *** [main.o] Error 1

Also, it would be nice to have as part of this patch series adding the
relevant info in
MAINTAINERS, doc/guides/sample_app_ug/index.rst , examples/Makefile
and adding a doc/guides/sample_app_ug/vdpa.rst, like most  patches for
examples do.
See for example,

commit f5188211c721688bf8530d1648d623205246e1da
Author: Fan Zhang <roy.fan.zhang@intel.com>
Date:   Thu Apr 5 17:01:36 2018 +0100
    examples/vhost_crypto: add sample application

Regards,
Rami Rosen