From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roszenrami@gmail.com>
Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com
 [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id A3F952BE5;
 Thu,  8 Nov 2018 21:38:19 +0100 (CET)
Received: by mail-ot1-f67.google.com with SMTP id 40so19209083oth.4;
 Thu, 08 Nov 2018 12:38:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=orxbM+p5ncXv9HM7JWniMbIOYaufmtqenJ+trxCpKTQ=;
 b=WlVn5CmstwarAgH4eCAp4FzB2bGRbmpnFxl4as67SJebmjj+w7zpFSD29p+jijOWGO
 dcp79SbJla4Kk3PQD5VG+nngwxbY3/EQsvFMaE+pm4FOwWblNNxe/e/zHSZcG4uimFG5
 U1ciqg1CMf7ZPkX4meQ9pXHksz4fcP5pLBf98A95g8CoI2ewuLS3ouxki72HaLkSSW1J
 2HSMhUQFN+W+l/5nzjmHBuyaVbMGfIoTQjcKohkpSL+TBih39QwBHyVJ2VDV+/ZccStH
 jXdX4lndmJi9jkDvWkyN4KatoCe3YGFXQBYa231RRxjkV+4RyPPpvBqN3L13tTjCFPeo
 KyjA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=orxbM+p5ncXv9HM7JWniMbIOYaufmtqenJ+trxCpKTQ=;
 b=jN7NggBcntyMwQVOtTb2clinDDDbsaxOpOaElexaU1ZGDChni6PVksdkPvBg3QGo6N
 yxJYOfKhMJD3yzft0ktsoPdwMlz6ME0ig7HvZasp329XtDWkoAUvzY7ymB6qU6ZOQCGN
 3JSeJN6k1+3U1jfIsGXaXHj8kfGkst1foMQY0ph5/fcIH0uY0jR2x5q3yfAwYXq7ghtX
 0c7EdcUhqBwjMNRAvYdLh2oKJzKwQCfHtTAM9CS/Y4L00pd4aG3DqBslh3FFJ4P3dkL8
 GfNdwaeyfUWR2PQkgwq6a3CflTW8Z0Nrd62/0NIDkBYPC50VtEdyOU6E8qh/IWv+tRjN
 KeEw==
X-Gm-Message-State: AGRZ1gI85nAKoXQSqZqa1pzNDh0PM8/kGjzVfWz44DuGmh98X3qhdX1R
 qSjVTjBukyq7xZ9wORgBsvLapGkLbqkSxo+XtIw=
X-Google-Smtp-Source: AJdET5fB1tm+TYal9cK+JhHsuAbNQ+ncmOU7lbu5jdA2YmbuULZIG3AdfgtjzKPWOzuSh/Btdl9g4Ezwau/ZYLfju40=
X-Received: by 2002:a9d:2f66:: with SMTP id h93mr3902907otb.165.1541709498940; 
 Thu, 08 Nov 2018 12:38:18 -0800 (PST)
MIME-Version: 1.0
References: <d2749a0c9f18188c56e02e61c602e65ca88e099d.1541598755.git.anatoly.burakov@intel.com>
 <e6f3dbb8-8cea-515e-e872-50be49edd3d0@intel.com>
 <b544afca-9f01-331c-d8a6-9b85e2c1a8bd@intel.com>
In-Reply-To: <b544afca-9f01-331c-d8a6-9b85e2c1a8bd@intel.com>
From: Rami Rosen <roszenrami@gmail.com>
Date: Thu, 8 Nov 2018 22:38:09 +0200
Message-ID: <CAKoUArmSpd7wz6d-ho-dcbWPpSnW01-Nd_wX8x_y_Jy_Lp5_xw@mail.gmail.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
 john.mcnamara@intel.com, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Nov 2018 20:38:19 -0000

Hi, Anatoly,

This is really minor nitpick, but in case you decide to send V2, I believe
it should say
>> + if ret != 0:
>> +            print("'lspci' not found - please install pciutils')

as the name of the package containing lspci is pciutils in centos.

Regards,
Rami Rosen


>