From: Rami Rosen <roszenrami@gmail.com>
To: Jeff Shaw <jeffrey.b.shaw@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include
Date: Mon, 17 Dec 2018 17:42:55 +0200 [thread overview]
Message-ID: <CAKoUArnTHFe6eFM=RaFsZjZbCNxaVA4BFf+ZDKV+dQ-eh6wBgw@mail.gmail.com> (raw)
In-Reply-To: <20181214164000.9667-1-jeffrey.b.shaw@intel.com>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>
> Prior to this patch, the two affected .c files include <dirent.h>
> unnecessarily. This commit removes the include lines.
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> ---
> lib/librte_eal/common/eal_common_lcore.c | 1 -
> lib/librte_eal/common/rte_service.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
> index 3167e9d79..1cbac4228 100644
> --- a/lib/librte_eal/common/eal_common_lcore.c
> +++ b/lib/librte_eal/common/eal_common_lcore.c
> @@ -5,7 +5,6 @@
> #include <unistd.h>
> #include <limits.h>
> #include <string.h>
> -#include <dirent.h>
>
> #include <rte_errno.h>
> #include <rte_log.h>
> diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
> index 0f3695c4b..03fde97a9 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -7,7 +7,6 @@
> #include <inttypes.h>
> #include <limits.h>
> #include <string.h>
> -#include <dirent.h>
>
> #include <rte_compat.h>
> #include <rte_service.h>
> --
> 2.14.3
>
next prev parent reply other threads:[~2018-12-17 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 16:40 Jeff Shaw
2018-12-17 15:42 ` Rami Rosen [this message]
2018-12-17 23:58 ` Ferruh Yigit
2018-12-19 0:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKoUArnTHFe6eFM=RaFsZjZbCNxaVA4BFf+ZDKV+dQ-eh6wBgw@mail.gmail.com' \
--to=roszenrami@gmail.com \
--cc=dev@dpdk.org \
--cc=jeffrey.b.shaw@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).